All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Maxwell Doose <m32285159@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"Tomasz Duszynski" <tduszyns@gmail.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS),
	linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH] iio: chemical: scd30: remove kernel.h header
Date: Sun, 12 Jul 2026 18:52:37 +0200	[thread overview]
Message-ID: <20260712185237.6a60e112@systembl0wer> (raw)
In-Reply-To: <20260712164225.358852-1-m32285159@gmail.com>

On Sun, 12 Jul 2026 11:42:25 -0500
Maxwell Doose <m32285159@gmail.com> wrote:

> kernel.h is no longer recommended for usage because it can cause longer
> build times and pull in transient dependencies. In addition, it's not
> being used by the SCD30 driver. Remove it.
> 
> Signed-off-by: Maxwell Doose <m32285159@gmail.com>
> ---
>  drivers/iio/chemical/scd30_core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/chemical/scd30_core.c b/drivers/iio/chemical/scd30_core.c
> index f85cdd8bd84f..40bbf26a667b 100644
> --- a/drivers/iio/chemical/scd30_core.c
> +++ b/drivers/iio/chemical/scd30_core.c
> @@ -23,7 +23,6 @@
>  #include <linux/interrupt.h>
>  #include <linux/irqreturn.h>
>  #include <linux/jiffies.h>
> -#include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/mutex.h>
>  #include <linux/regulator/consumer.h>

Since you're doing IWYU stuff, you should also remove errno.h and
add err.h instead, as the code uses IS_ERR() etc. and err.h includes
errno.h

Also consider grouping the iio headers and asm headers separately.
(separate patch though). The include list looks overwhelming!

-- 
Kind regards

CJD

  reply	other threads:[~2026-07-12 16:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-12 16:42 [PATCH] iio: chemical: scd30: remove kernel.h header Maxwell Doose
2026-07-12 16:52 ` Joshua Crofts [this message]
2026-07-12 18:47   ` Maxwell Doose
2026-07-13  0:53     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260712185237.6a60e112@systembl0wer \
    --to=joshua.crofts1@gmail.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m32285159@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=tduszyns@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.