From: Gianluca Boiano <morf3089@gmail.com>
To: "Krzysztof Kozlowski" <krzk@kernel.org>
Cc: Gianluca Boiano <morf3089@gmail.com>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
Baojun Xu <baojun.xu@ti.com>, "Wang, Sen" <sen@ti.com>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: sound: add Texas Instruments TAS2557
Date: Sun, 12 Jul 2026 23:01:47 +0200 [thread overview]
Message-ID: <20260712210148.384870-1-morf3089@gmail.com> (raw)
In-Reply-To: <20260712-cyber-gorilla-of-acumen-19070e@quoll>
> + ti,channel:
>
> ti,audio-channel
>
> Most speakers do not need such property, especially that what do you do
> in 4-speaker configuration? I found only two references: awinic,aw87390
> and awinic,aw88395.yaml.
Dropped in v3. A node now takes a `reg` array of 1 or 2 addresses;
the device at each index applies that half (DEV_A/DEV_B) of the
stereo firmware. Device order is the only configuration needed - no
property. This matches tas2781.c/tas2781-fmwlib.c's architecture for
the same firmware toolchain.
`reg` is capped at two because the firmware container itself only
defines two device types (DEV_A/DEV_B). A 4-speaker board would need
two independent stereo pairs on two nodes, same as with tas2781.
> + $ref: /schemas/types.yaml#/definitions/string
>
> Wrong type - there is basically no syntax like that (except a few
> left-overs which I remove now), so please kindly do not upstrem some old
> code. Drop.
>
> You need maxItems.
Fixed in v3: maxItems: 1.
Gianluca
next prev parent reply other threads:[~2026-07-12 21:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-11 14:57 [PATCH v2 0/2] ASoC: codecs: add Texas Instruments TAS2557 smart amplifier driver Gianluca Boiano
2026-07-11 14:57 ` [PATCH v2 1/2] dt-bindings: sound: add Texas Instruments TAS2557 Gianluca Boiano
2026-07-12 14:52 ` Krzysztof Kozlowski
2026-07-12 21:01 ` Gianluca Boiano [this message]
2026-07-13 13:32 ` Mark Brown
2026-07-11 14:57 ` [PATCH v2 2/2] ASoC: codecs: add TAS2557 mono smart amplifier driver Gianluca Boiano
2026-07-11 15:10 ` sashiko-bot
2026-07-13 13:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260712210148.384870-1-morf3089@gmail.com \
--to=morf3089@gmail.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kevin-lu@ti.com \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=sen@ti.com \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.