From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BB7A25B090 for ; Sun, 12 Jul 2026 05:55:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783835725; cv=none; b=WI0UtmpnntyV8MZxk3v/DKKfn432BnjqYlDTKico0Clujtof4vLugxmDl7ptZUmFDrQ7GIQ1bY1ZLlbLNUTR33GELXpEVs6ng9XfwDovvu4FaEK58lCNNamv8uDD1FhQUAjSLGR1kxAtqz6mHioHhUMBWc6hWXGiO+H+0r8utcE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783835725; c=relaxed/simple; bh=FHIqMzZe0AXToo6ubAtAolb75BO/wYxos9q5qax0qAU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UxDoiCMnGUDQr3UdLie9UabbBxwFHG9FDJSN+WGTv3Gn/UayIm0pY4FNzwm7eg3ZWj9N0NBLQaHMYG74LjzBlQBsVP85JOkdYZ3AS2UQVJt7x94wrire0r4aMKXdeKRYQDN/prhNpY7wDj8VsC1UkOUCrTVuvno9nx+jDun/en8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=LmR6witP; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="LmR6witP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8013E1F000E9; Sun, 12 Jul 2026 05:55:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1783835724; bh=GlMEjvpkD3e4x+OXZj7W0SoGpxx/Z1MxVDlKF7QM3c4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=LmR6witPUgxBN+uFGy32vUrjbgadJSzdIQ0UzjsPxsjoQM0zpcC38pc3oW2qVCmJW 4Pgz9PWNnsYGpvG+IX4gE6SP9mRDtaZN5EODY3DHhjVi/T11jbj5fLfQ9Dk5oEL9Tz capVpRcZClGdIijdZlqm5j8MJNRtV6w6WwrD/AMo= Date: Sun, 12 Jul 2026 07:54:05 +0200 From: Greg KH To: Florian Westphal Cc: Jaeyeong Lee , netfilter-devel@vger.kernel.org, pablo@netfilter.org, phil@nwl.cc Subject: Re: [PATCH nf] netfilter: nf_nat: do not reuse an unexpected expectation on RTCP clash Message-ID: <2026071235-geometric-snowdrift-bb4c@gregkh> References: <2026071134-turkey-detonator-0d87@gregkh> <178377968720.33756.12204817361601593230@proton.me> Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Jul 11, 2026 at 06:29:31PM +0200, Florian Westphal wrote: > Jaeyeong Lee wrote: > > Since commit b8b09dc2bf35 ("netfilter: nf_conntrack_expect: use conntrack > > GC to reap expectations") nf_ct_unexpect_related() no longer unlinks the > > expectation from the global hash and from the per-master list. It only > > marks it with NF_CT_EXPECT_DEAD and defers the unlink to the conntrack GC > > [..] > > > and then continues the loop, reusing the very same rtp_exp object: > > > > ret = nf_ct_expect_related(rtcp_exp, ...); > > ... > > I think this function should WARN_ON_ONCE when one tries to reinsert a > dead expectation (and return -EINVAL or another appropriate error). > > (This is indenpendent of the real fix). If you do that, then the machine will reboot, loosing everything. Are you sure you want that to happen? Why not just properly handle the issue if it possibly could happen? thanks, greg k-h