From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 623D328CF4A; Mon, 13 Jul 2026 02:46:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783910819; cv=none; b=CeESXfB19mq6yY7T7qmuOGgHhwmMyFH2fc8wYKVEi/OMin6M6ejnuDfIzVWXoP8g3RxG1rXAYeboKu4GVQkCm5iollKCxnIl8cZzbrH8YuqFfd6FG139KwayzimO2HChhEcKNy5ToGDRop1UIEZTdnKHLTOQsoQQUNMqHTlN6GY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783910819; c=relaxed/simple; bh=/b3kJbOFF0E/b/f4VSpOrBDVMaZaC4kFhGCvRcd8O7I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WV3srUYL4bQERyQl7CoJRx7Wlzqu5B0JpU9nAddjmzWF/2ML6VaTIgWXpORn/vJq7OnipPaWZ6D5i9vA2gUP27yQ9dT+S2v1bPwgD4s8bYuxwNSoiTxSyZPHnbTqwqgzcs34Ygvo84imzsORwSresPky+699Za52pYRZUL+bPu8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=P7GWtJzn; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P7GWtJzn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B99B61F000E9; Mon, 13 Jul 2026 02:46:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783910816; bh=NVNxpvdr75jR60pjmjlxX2uPtAPAPcc1WMu92AUb6WE=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=P7GWtJznmtHWeTVEJdLRSnknDOYL6w64XGx9CnpdLMTXshE4Sc452duIZd+egY966 tLG4RSFlntGawHD/OQOjE9ckNNvMPqql4mL7WjZjE7bkdJS3WOd6EH+/A27KX5RsP4 kaes39SomNTK12GW39eimt3iuhCVVuBYygVLEApYdpGg2tfc3Xlj0fGRSnOsyOjzGI OeBmeFmYAF0ZVxXoga5lBC9Hj7oymysD5vljL+2G6KWzz/XrtZxroJo2zNK9W297MW W7EeXY2KZMWETv/6C6qPn2bNFtx+KhYciT/tM24I+hgjVl2kpCmMFuDY/lrtWtyQys IOldlMvx2RFxA== Date: Sun, 12 Jul 2026 22:46:54 -0400 From: Eric Biggers To: Herbert Xu Cc: Thomas Huth , Steffen Klassert , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] crypto: pcrypt - Disallow nesting of the pcrypt wrapper Message-ID: <20260713024654.GE4362@quark> References: <20260701143947.944593-1-thuth@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jul 13, 2026 at 12:30:18PM +1000, Herbert Xu wrote: > This doesn't fix the problem completely since you can nest in other > ways, e.g., pcrypt(cryptd(pcrypt(...))). How about handling the name- > too-long error more gracefully? Could we just delete pcrypt instead of continuing to try to fix all the weird problems it has? A web search for pcrypt just finds CVEs and advice not to use it, e.g. https://github.com/libreswan/libreswan/wiki/Internals:-Cryptographic-Acceleration#obsoleted-ipsec-accelerations What is the rationale for keeping it? Who cares about it, other than people looking for vulnerabilities? - Eric