From: "Michał Grzelak" <michal.grzelak@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Mohammed Thasleem" <mohammed.thasleem@intel.com>,
"Michał Grzelak" <michal.grzelak@intel.com>
Subject: [PATCH i-g-t v1 06/16] tests/kms_frontbuffer_tracking: remove TEST_MODE_ITER_BEGIN() from `fliptrack`
Date: Mon, 13 Jul 2026 10:55:05 +0200 [thread overview]
Message-ID: <20260713085515.463575-7-michal.grzelak@intel.com> (raw)
In-Reply-To: <20260713085515.463575-1-michal.grzelak@intel.com>
igt@kms_frontbuffer_tracking uses TEST_MODE_ITER_BEGIN(t) which consists
of nested for loops. However many loops can be omitted due to continue
statements. This obfuscates following the execution of any given
codepath. Replace TEST_MODE_ITER_BEGIN(t) for fliptrack tests with macro
definition and remove loops that are skipped.
Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
---
tests/intel/kms_frontbuffer_tracking.c | 24 ++++++++++++++++++------
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
index f5c2a81434..c41f97bd34 100644
--- a/tests/intel/kms_frontbuffer_tracking.c
+++ b/tests/intel/kms_frontbuffer_tracking.c
@@ -4511,11 +4511,21 @@ int igt_main_args("", long_options, help_str, opt_handler, NULL)
}
TEST_MODE_ITER_END
- TEST_MODE_ITER_BEGIN(t)
- if (t.plane != PLANE_PRI ||
- t.screen != SCREEN_PRIM ||
- t.method != IGT_DRAW_MMAP_GTT ||
- (t.feature & FEATURE_FBC) == 0)
+ t.format = FORMAT_DEFAULT;
+ t.flip = FLIP_PAGEFLIP;
+ t.tiling = opt.tiling;
+ t.plane = PLANE_PRI;
+ t.screen = SCREEN_PRIM;
+ t.method = IGT_DRAW_MMAP_GTT;
+
+ for (t.feature = 0; t.feature < FEATURE_COUNT; t.feature++) {
+ for (t.pipes = 0; t.pipes < PIPE_COUNT; t.pipes++) {
+ for (t.fbs = 0; t.fbs < FBS_COUNT; t.fbs++) {
+ if (!opt.show_hidden && t.feature == FEATURE_NONE)
+ continue;
+ if ((t.feature & FEATURE_PSR) && (t.feature & FEATURE_DRRS))
+ continue;
+ if ((t.feature & FEATURE_FBC) == 0)
continue;
igt_subtest_f("%s-%s-%s-fliptrack-%s",
@@ -4527,7 +4537,9 @@ int igt_main_args("", long_options, help_str, opt_handler, NULL)
igt_require(igt_draw_supports_method(drm.fd, t.method));
fliptrack_subtest(&t, FLIP_PAGEFLIP);
}
- TEST_MODE_ITER_END
+ }
+ }
+ }
TEST_MODE_ITER_BEGIN(t)
if (t.screen == SCREEN_OFFSCREEN ||
--
2.45.2
next prev parent reply other threads:[~2026-07-13 9:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 8:54 [PATCH i-g-t v2 00/16] limiting suspend tests Michał Grzelak
2026-07-13 8:55 ` [PATCH i-g-t v2 01/16] lib/igt_aux: remove typos Michał Grzelak
2026-07-16 5:46 ` Karthik B S
2026-07-13 8:55 ` [PATCH i-g-t v1 02/16] lib/igt_kms: s/pipe/crtc/ Michał Grzelak
2026-07-16 5:46 ` Karthik B S
2026-07-13 8:55 ` [PATCH i-g-t v1 03/16] tests/kms_async_flips: split outer test loop into two Michał Grzelak
2026-07-13 8:55 ` [PATCH i-g-t v1 04/16] tests/kms_async_flips: limit #outputs tested during suspend Michał Grzelak
2026-07-16 8:07 ` Karthik B S
2026-07-13 8:55 ` [PATCH i-g-t v1 05/16] tests/kms_frontbuffer_tracking: remove TEST_MODE_ITER_BEGIN() from `suspend` Michał Grzelak
2026-07-13 8:55 ` Michał Grzelak [this message]
2026-07-13 8:55 ` [PATCH i-g-t v1 07/16] tests/kms_pipe_crc_basic: limit #crtcs tested during suspend Michał Grzelak
2026-07-13 8:55 ` [PATCH i-g-t v1 08/16] tests/kms_psr: limit #outputs " Michał Grzelak
2026-07-13 8:55 ` [PATCH i-g-t v2 09/16] tests/kms_vblank: split outer test loop into two Michał Grzelak
2026-07-13 8:55 ` [PATCH i-g-t v1 10/16] tests/kms_vblank: limit #outputs tested during suspend Michał Grzelak
2026-07-13 8:55 ` [PATCH i-g-t v1 11/16] tests/kms_sharpness_filter: fix typo Michał Grzelak
2026-07-14 10:05 ` Garg, Nemesa
2026-07-13 8:55 ` [PATCH i-g-t v1 12/16] tests/kms_sharpness_filter: limit #outputs tested during suspend Michał Grzelak
2026-07-14 13:03 ` Garg, Nemesa
2026-07-16 8:41 ` Michał Grzelak
2026-07-13 8:55 ` [PATCH i-g-t v1 13/16] tests/kms_sharpness_filter: limit #crtcs " Michał Grzelak
2026-07-13 8:55 ` [PATCH i-g-t v1 14/16] tests/kms_ccs: split outer test loop into two Michał Grzelak
2026-07-13 8:55 ` [PATCH i-g-t v1 15/16] tests/kms_ccs: limit #outputs tested during suspend Michał Grzelak
2026-07-13 8:55 ` [PATCH i-g-t v1 16/16] tests/kms_ccs: limit #crtcs " Michał Grzelak
2026-07-13 12:04 ` ✓ Xe.CI.BAT: success for limiting suspend tests Patchwork
2026-07-13 12:24 ` ✓ i915.CI.BAT: " Patchwork
2026-07-13 14:39 ` ✓ Xe.CI.FULL: " Patchwork
2026-07-13 16:40 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713085515.463575-7-michal.grzelak@intel.com \
--to=michal.grzelak@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=mohammed.thasleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.