Re: [PATCH for-next 1/2] RDMA/efa: Extend page-shift field in MR registration

[Leon Romanovsky <leon@kernel.org>]

On Sun, Jul 12, 2026 at 01:44:12PM +0000, Michael Margolin wrote:
> Update device interface adding one more bit from reserved to enable
> >4GB page sizes that can be supported on 0xefa4 devices.
> 
> Reviewed-by: Yonatan Nachum <ynachum@amazon.com>
> Signed-off-by: Michael Margolin <mrgolin@amazon.com>
> ---
>  drivers/infiniband/hw/efa/efa_admin_cmds_defs.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/efa/efa_admin_cmds_defs.h b/drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
> index 826790ca9d83..3eb3a4de8912 100644
> --- a/drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
> +++ b/drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
> @@ -367,10 +367,10 @@ struct efa_admin_reg_mr_cmd {
>  
>  	/*
>  	 * flags and page size
> -	 * 4:0 : phys_page_size_shift - page size is (1 <<
> +	 * 5:0 : phys_page_size_shift - page size is (1 <<
>  	 *    phys_page_size_shift). Page size is used for
>  	 *    building the Virtual to Physical address mapping
> -	 * 6:5 : reserved - MBZ
> +	 * 6 : reserved - MBZ
>  	 * 7 : mem_addr_phy_mode_en - Enable bit for physical
>  	 *    memory registration (no translation), can be used
>  	 *    only by privileged clients. If set, PBL must
> @@ -1103,7 +1103,7 @@ struct efa_admin_host_info {
>  #define EFA_ADMIN_MODIFY_QP_CMD_RNR_RETRY_MASK              BIT(5)
>  
>  /* reg_mr_cmd */
> -#define EFA_ADMIN_REG_MR_CMD_PHYS_PAGE_SIZE_SHIFT_MASK      GENMASK(4, 0)
> +#define EFA_ADMIN_REG_MR_CMD_PHYS_PAGE_SIZE_SHIFT_MASK      GENMASK(5, 0)

How will the new kernel behave on non-0xefa4 devices? The new
kernel sets one additional bit that these devices do not expect.

Thanks