From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2] nvme: fix cdev lifetime
Date: Mon, 13 Jul 2026 11:48:41 +0200 [thread overview]
Message-ID: <20260713094841.GA10083@lst.de> (raw)
In-Reply-To: <92db8054-c7b0-4517-873e-8c0fb18c02ba@oracle.com>
On Mon, Jul 13, 2026 at 10:46:26AM +0100, John Garry wrote:
>>> + nvme_tryget_ns_head(head); /* Undone in nvme_cdev_rel() */
>> I think we need to do a real get and not a tryget here.
>>
>
> ok, np.
>
> Then I am going to propose adding nvme_get_ns_head() also. It can be used
> elsewhere and it would match better with nvme_put_ns_head() (rather than
> using kref_fget(&head->kref) here)
Fine with me.
prev parent reply other threads:[~2026-07-13 9:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 9:15 [PATCH v2] nvme: fix cdev lifetime John Garry
2026-07-13 9:30 ` Christoph Hellwig
2026-07-13 9:46 ` John Garry
2026-07-13 9:48 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713094841.GA10083@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=john.g.garry@oracle.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.