From: Christoph Hellwig <hch@lst.de>
To: Zhang Yi <yi.zhang@huaweicloud.com>
Cc: Pankaj Raghav <p.raghav@samsung.com>,
zlang@kernel.org, linux-xfs@vger.kernel.org, hch@lst.de,
pankaj.raghav@linux.dev, fstests@vger.kernel.org,
djwong@kernel.org, yi.zhang@huawei.com,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH v2] generic/795: add unaligned boundary test cases for WRITE_ZEROES
Date: Mon, 13 Jul 2026 12:04:14 +0200 [thread overview]
Message-ID: <20260713100414.GA11013@lst.de> (raw)
In-Reply-To: <1adabe60-17d5-49ff-a6e6-33f90debf6fe@huaweicloud.com>
On Fri, Jul 10, 2026 at 04:23:27PM +0800, Zhang Yi wrote:
> Thank you for the test! The changes look good to me, and it works well
> with my ext4 fixes as well.
>
> Reviewed-by: Zhang Yi <yi.zhang@huawei.com>
>
> Unfortunately, I've found a bug in filefrag that causes delalloc extents
> to be reported with a length of 0. This means this test case can miss
> delalloc extents. The issue is in misc/filefrag.c's print_extent_info(),
> where ext_len is incorrectly set to 0 for the FIEMAP_EXTENT_UNKNOWN or
> EXT4_FIEMAP_EXTENT_HOLE cases. Could you please send a patch to fix this
> as well?
We can't really rely on having a bleeding edge filefrag for xfstests
(well, at least without a feature check for it, but even that
would not a good usability story). I guess at least for now
we might have to add a little tool that just calls FIEMAP for
us to xfstests?
next prev parent reply other threads:[~2026-07-13 10:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 8:30 [PATCH v2] generic/795: add unaligned boundary test cases for WRITE_ZEROES Pankaj Raghav
2026-07-10 8:23 ` Zhang Yi
2026-07-13 7:28 ` Pankaj Raghav
2026-07-13 10:04 ` Christoph Hellwig [this message]
2026-07-13 13:21 ` Pankaj Raghav
2026-07-13 13:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713100414.GA11013@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=p.raghav@samsung.com \
--cc=pankaj.raghav@linux.dev \
--cc=yi.zhang@huawei.com \
--cc=yi.zhang@huaweicloud.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.