Re: [PATCH v2] PCI: vmd: Only assign OSC features in bare metal OS.

[Nirmal Patel <nirmal.patel@linux.intel.com>]

On Sun, 12 Jul 2026 15:30:01 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Fri, Jul 10, 2026 at 08:05:58PM +0000, Nirmal Patel wrote:
> > Copy valid OSC flags from root bridge only when OS can provide
> > correct values. In virtual machine, all of the control features are
> > disabled as hypervisor will not passthrough root bridge information
> > to VM.  
> 
> ...
> 
> > v2 : Added descriptive boolean and removed period from commit
> > message.  
> 
> It's still in the $Subject. You probably misinterpreted the
> comment(s).
My bad, i removed (_). Let me correct. Is (_OSC) in subject okay?
> 
> ...
> 
> > +	/* Non-zero offset means guest/direct assign view. */
> > +	vmd_in_guest = offset[0] || offset[1];  
> 
> + Blank line?
Ack.
> 
> >  	/*
> >  	 * Currently MSI remapping must be enabled in guest
> > passthrough mode
> >  	 * due to some missing interrupt remapping plumbing. This
> > is probably
> >  	 * acceptable because the guest is usually CPU-limited and
> > MSI
> >  	 * remapping doesn't become a performance bottleneck.
> >  	 */
> > -	if (!(features & VMD_FEAT_CAN_BYPASS_MSI_REMAP) ||
> > -	    offset[0] || offset[1]) {
> > +	if (!(features & VMD_FEAT_CAN_BYPASS_MSI_REMAP) ||
> > vmd_in_guest) { ret = vmd_alloc_irqs(vmd);
> >  		if (ret)
> >  			return ret;  
> 
> ...
> 
> > -
> > vmd_copy_host_bridge_flags(pci_find_host_bridge(vmd->dev->bus),
> > -
> > to_pci_host_bridge(vmd->bus->bridge));
> > +	/* Don't copy OSC control flags in VM, it disables
> > features.*/  
> 
> Missing space before */.
Ack.
> 
> > +	if (!vmd_in_guest)
> > +
> > vmd_copy_host_bridge_flags(pci_find_host_bridge(vmd->dev->bus),
> > +
> > to_pci_host_bridge(vmd->bus->bridge));  
>