From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 645D7408604 for ; Mon, 13 Jul 2026 12:11:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783944674; cv=none; b=tLQ8iO2BclWftpkGMbr3cmmrAqLjkJaXmgKr+o0jRn/LjtQyCraBvph40KRoyPMxOEXo9E5E2C2gcHevnd1XcI7/RjNUUMTeMLa0OJ6BOD/8cAqQZYzSaROOdx/hVhpSbPYns7cVAnYLkJxGXjxhFbqvmVAnNHtQEN7mTqnMvVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783944674; c=relaxed/simple; bh=zCGdfwgN+TNG39gAmZu2s6yLUo3JyS1qCB3nKCP6UcU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S8dRaZsC5CxR5caKauOGmV9iel7xwJL7PJoJ/TiQeLV5jQUWtf5vBuN5hKM+VytfMErTnCPfF9NHtBzt+TzK2f3oplF4EyWrORXhXzTNWShUGnrZ4p9NoUpM9NcrQcOEDuJ2M097zCAAtVoADRyzLbEaLVamM+mDQVMrC56Z+nE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mPwzuza2; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mPwzuza2" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2cc7ef7ec27so33191695ad.1 for ; Mon, 13 Jul 2026 05:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783944671; x=1784549471; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vnt3ypfWeNL23UY1KrHNZewux6mQtgVXM5HeMULrIrY=; b=mPwzuza2XbnFq8pu0Nd38dTNkNHN/vfxSxTeEAupHDoPIM4vclbtDWpNYP5fjRn7jv +BEALwYHoHP7t1TAcIlQpikyNYY92RgPd3GSfB9qNXQ0JM8kK/A3gpSM6+8otmBfT5Hf YrBMsSQ8Ksmglp8oE+jgBI8gmQc+KW+sEo2F7JI2yK5shv0CO0dkw64ZLNMT3AXhy0rs Javxd4z2gwNq7t/Y0lWVtATQwCp4Nub4dZjEsSjfDKKJLuEKGN5BtHpOQOlLcSBwKoHh MUL5eugQktOI6OWR0TQED8nUUitl8adB3ewVTdtriGJ7TwynPO108nFv5zOVjf5iaN7P EAxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783944671; x=1784549471; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=vnt3ypfWeNL23UY1KrHNZewux6mQtgVXM5HeMULrIrY=; b=DeSltjJgSrPCeYK80MOxijosSb2sv7sto1eOCy2Cb1y/Rh+iLE0MdRxMVSVEvCn8kX 6OSfug3Uz0HiOmYA/esxknyfEM5mJeXo7AiWi0ST7R/alv3r6tkTWHFOcZC1IcXT6TLu J67ZGriIiO9dr8fvOQQIJsJp6dyasUpaBfHSKHi5piFCdzxOuAJ/ySjYsM5b58qSRcSe TEerhR1YHl+HYsXP57WRcW+XlZUF3DIQNdeh12LU/kAr1nt3IERZPQH3emSMMzv/1rkG w8gKrAHD9yrfxPeU3Ivg0uqzysujcGs24KOk2dAWnfmdZLIfT1JtfAFGdDs1n8MRSgAa MXFg== X-Forwarded-Encrypted: i=1; AHgh+RrSAIBA/r1yasWYozeKQZZE3qPWriJi464jb7wvJ6SC5VIRQhzx83TP257k6gdDw86+XxkTyWp1i1GYXPg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywvm+XxLrd7sT17gYnpGEbg63YBLugeiJixEoaAlswe+GAFNADx wN5S9C3H+RW+WCEAVHE9B2TX+5Y7HWpp4ZuG202ovGpXc/w5HNbyedvr X-Gm-Gg: AfdE7ckwt7lminiJ4r+Plm+trH5kU5g+6jYjzB1fQCnZ1AHAWGscO0oILzYjc3MsdqE Bzm1uoK7nyu8WnVEk6u3BM8j/wiER9VRUJiZ4rcbosoqfG882ipPRazPMpBUAJO3b8zJeuDKnKi +MtM2v6+yTrsS7omH3x/mijgJakSelkNatJ9h37wbWuZ6VCfqbPaxEdmye+62uD7J/6RMqxmxvK ogmfP0m3EHWonef9d/ft7dObHNv1PnNK7Ppj+X6pV6lz46PkGHc+KKiH+GTWYdUjm7LrVHmbjB3 TBhJZHcWMKh5mEMehitXDGSkw7nAyl3gVV+ujFwf8G0HbCazpldy4zamXNpBKVObFHf1mvQ5dD8 +TN34mr/TrR/Ty17YUsH2JGVxq2AuZeP2V4bfDil6EeHRj51agj9nAIkgcYOSjpuDnXv59vpplo op+HDrue2xKfbmNy+aVfDA X-Received: by 2002:a17:90b:4990:b0:36a:a16b:5f6d with SMTP id 98e67ed59e1d1-38dc74c4c2cmr9218450a91.7.1783944671501; Mon, 13 Jul 2026 05:11:11 -0700 (PDT) Received: from rockpi-5b ([45.112.0.180]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311747f7293sm67756935eec.3.2026.07.13.05.11.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 05:11:10 -0700 (PDT) From: Anand Moon To: Neil Armstrong , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Mauro Carvalho Chehab , Greg Kroah-Hartman , dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR AMLOGIC SOCS), linux-amlogic@lists.infradead.org (open list:DRM DRIVERS FOR AMLOGIC SOCS), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Amlogic Meson SoC support), linux-kernel@vger.kernel.org (open list), linux-media@vger.kernel.org (open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS), linux-staging@lists.linux.dev (open list:STAGING SUBSYSTEM) Cc: Anand Moon , Doruk Tan Ozturk , Nicolas Dufresne Subject: [PATCH v7 13/19] media: meson: vdec: Fix race conditions in job abort sequence Date: Mon, 13 Jul 2026 17:37:08 +0530 Message-ID: <20260713120840.17427-14-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260713120840.17427-1-linux.amoon@gmail.com> References: <20260713120840.17427-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Implement proper cleanup inside vdec_m2m_job_abort to safely stop the hardware job sequence during a streaming abort or teardown. Without this, if a job is aborted right after being triggered, the deferred work item (esparser_queue_work) scheduled by device_run could continue running concurrently. This leads to unexpected behavior and potential use-after-free bugs if session structures are cleared. Fix this by flagging the session to stop via WRITE_ONCE, synchronously canceling any pending parser work, and safely clearing the active core session pointer under the core lock protection. Cc: Nicolas Dufresne Signed-off-by: Anand Moon --- drivers/staging/media/meson/vdec/vdec.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c index b3e1d99e8889f..ac86a9c4febff 100644 --- a/drivers/staging/media/meson/vdec/vdec.c +++ b/drivers/staging/media/meson/vdec/vdec.c @@ -167,6 +167,17 @@ static void vdec_m2m_device_run(void *priv) static void vdec_m2m_job_abort(void *priv) { struct amvdec_session *sess = priv; + struct amvdec_core *core = sess->core; + + WRITE_ONCE(sess->should_stop, 1); + + cancel_work_sync(&sess->esparser_queue_work); + + mutex_lock(&core->lock); + if (core->cur_sess == sess) + /* Safely clear hardware ownership since we were confirmed as the owner */ + smp_store_release(&core->cur_sess, NULL); + mutex_unlock(&core->lock); v4l2_m2m_job_finish(sess->core->m2m_dev, sess->m2m_ctx); } -- 2.50.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1DF2C43458 for ; Mon, 13 Jul 2026 12:11:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eiS3OqDU8Ap0bEq3/FS7UYKRKhJxTzbo37Xo95/gyEE=; b=XKF9/hZJGEODsY oowtVMBOo9ePEkWnaQ/BytV2PQ8uwpfX4JYMaV6sK0oq7bRYxUKyZLyYuzhw02/AYRpnjqxfFjJ8w 5xPokEF85O1pXfg6xjrRulEzbaSdhv5uTr2tQ87Weyx3M3VHC6kk0b8t8TC1NGEFAC7G8O9+7dsc4 P5k42dBz521iHXF7ilH1XKyrJDNEfnbCaYSeIFh2iFq6IAkXGyX0ZDtNeDj/5leT4Ve4EUj+ozMdS WU83hGxj2AKlN4uw/nUfrASPqQUTxilwCvyHYYZkklGn/0BdfwV2/s6gF86THpgQz9F4ErabRCkfX L4Ae7YWTQnAh/L4orqWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjFVG-000000099K0-05EN; Mon, 13 Jul 2026 12:11:18 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjFVA-000000099HB-0VEo for linux-amlogic@lists.infradead.org; Mon, 13 Jul 2026 12:11:16 +0000 Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-381018b9375so3450827a91.0 for ; Mon, 13 Jul 2026 05:11:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783944671; x=1784549471; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vnt3ypfWeNL23UY1KrHNZewux6mQtgVXM5HeMULrIrY=; b=jmTHSFhxWLaBI3/sFEYikae/aACqqNvHCHVyB99f/1nfTXhg9nI29il6PtbdxVFGBv ZMY+AzCWIpcQCXEe1xWm9WcRxpFGHOJ/jJ7OWdLEK6D8nJdFH5sp+BUjgManyPjPcux7 y+vkjWneKLFRoJBxuq70+1bni49YISCPivTvUrpL5sID/YSpaOvk0sm0HQ+CgTiRCbRG i7CQGenuuBy++tzsWoPvmZFfhc8nxg3J81gEla/4YL0fZgSlku9JPw1AhtyHr3Ajl8Ch 4wddTNcd31308IX4/CO9Ln6X1kcELwZTiKxJT229HLtXyxBt44lBz8fxLCAdH/iCOP70 ZBMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783944671; x=1784549471; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=vnt3ypfWeNL23UY1KrHNZewux6mQtgVXM5HeMULrIrY=; b=ryQ0Qd6atx/1QjohHmZ8MdG51+cSpv7TtbOugqVsntSHwTMvz2zk2dm0h+8xcd86Uc y0dE2dl8SNfhvGvrFtz1h3NalAHRRfNck6LWjwrRYtTOj91kDkRkb7Az2iFpGAbMK30S Bm6eQ+7RwmanWlA2HSHz+MAWRlkvZoiJ5P6wDAbdfnXZ+RQeLC1mM/ELSEMsJ2MYYlK5 BvkAFov+b9HrJlQWC50ff7LI7RpGDww6zlUxnHCeX/9FArH8gEFtu5KQI2xIWIrwOiTy 8qg3fhkoa2kBB7EAXIsyFROBB22eOH7WCcmPIjOHnUHCuJcE+dQSlPnxM67quLxsd4Gu GdYQ== X-Forwarded-Encrypted: i=1; AHgh+RryoxSL2LUDVHek/mHAoZk1HQONgVwPzUyGJxBxS0CB+uiuPE8bTKwqIjYfgjxk1BSQRksY9Z/4KaJJ+jBj@lists.infradead.org X-Gm-Message-State: AOJu0YzKc8DAEA76Q4GkaJEe7LIl0a8ZBVwd4S2CbWyS3ULJXFjcyo9c d9BEDTIhM3HE3DZ6AwK1Zk+2b7KG7nzH2nYn4Ai+DJmQfHO2/v+liyjW X-Gm-Gg: AfdE7cnv7Cj8C1T6Kl7M5gCBJvAPTyBLXxoXhdc9EHOQtQ4sZ+T3XMOv6j+y6q/KkEt Tk/SYkxbdsyeLTC+ljh+HAJFi5TrC805M2CDFkqn8gikkb/1FSzNJAjkNT0DtdU7EVbCFGVtcAB kKQ1HKVkw1vOpMeaTS19uO+IrnSXKDt4z+b5S9Az31HE65papPtx29u62f+65eGIDp36K9yffaQ 2E0Yz8Z5Ug/9zprfoA+KlYHNRKqO3umslhtI034EsgCD8WnEJFR5nzPcpooSS7AgQmqyloYTzfY HTBwLVglBlkqaoWwegYnXW33wEXIIfY0ElpoFSCfIQVMV1PkAQNSCnPWiJtf8nkI55MGVXzngqK keZ5Iv68apkT6rBemXAH59aIIKLdVc8xUpy+PIS8KW2C4MQ4ltFi3uGQP2dTHuFusKjPPVg4Rlv 5GFGduiCnWpKqRmm1l9xnU X-Received: by 2002:a17:90b:4990:b0:36a:a16b:5f6d with SMTP id 98e67ed59e1d1-38dc74c4c2cmr9218450a91.7.1783944671501; Mon, 13 Jul 2026 05:11:11 -0700 (PDT) Received: from rockpi-5b ([45.112.0.180]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311747f7293sm67756935eec.3.2026.07.13.05.11.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 05:11:10 -0700 (PDT) From: Anand Moon To: Neil Armstrong , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Mauro Carvalho Chehab , Greg Kroah-Hartman , dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR AMLOGIC SOCS), linux-amlogic@lists.infradead.org (open list:DRM DRIVERS FOR AMLOGIC SOCS), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Amlogic Meson SoC support), linux-kernel@vger.kernel.org (open list), linux-media@vger.kernel.org (open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS), linux-staging@lists.linux.dev (open list:STAGING SUBSYSTEM) Subject: [PATCH v7 13/19] media: meson: vdec: Fix race conditions in job abort sequence Date: Mon, 13 Jul 2026 17:37:08 +0530 Message-ID: <20260713120840.17427-14-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260713120840.17427-1-linux.amoon@gmail.com> References: <20260713120840.17427-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260713_051114_806269_68A3A449 X-CRM114-Status: GOOD ( 13.70 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Doruk Tan Ozturk , Nicolas Dufresne Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Implement proper cleanup inside vdec_m2m_job_abort to safely stop the hardware job sequence during a streaming abort or teardown. Without this, if a job is aborted right after being triggered, the deferred work item (esparser_queue_work) scheduled by device_run could continue running concurrently. This leads to unexpected behavior and potential use-after-free bugs if session structures are cleared. Fix this by flagging the session to stop via WRITE_ONCE, synchronously canceling any pending parser work, and safely clearing the active core session pointer under the core lock protection. Cc: Nicolas Dufresne Signed-off-by: Anand Moon --- drivers/staging/media/meson/vdec/vdec.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c index b3e1d99e8889f..ac86a9c4febff 100644 --- a/drivers/staging/media/meson/vdec/vdec.c +++ b/drivers/staging/media/meson/vdec/vdec.c @@ -167,6 +167,17 @@ static void vdec_m2m_device_run(void *priv) static void vdec_m2m_job_abort(void *priv) { struct amvdec_session *sess = priv; + struct amvdec_core *core = sess->core; + + WRITE_ONCE(sess->should_stop, 1); + + cancel_work_sync(&sess->esparser_queue_work); + + mutex_lock(&core->lock); + if (core->cur_sess == sess) + /* Safely clear hardware ownership since we were confirmed as the owner */ + smp_store_release(&core->cur_sess, NULL); + mutex_unlock(&core->lock); v4l2_m2m_job_finish(sess->core->m2m_dev, sess->m2m_ctx); } -- 2.50.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5DB6CC44501 for ; Mon, 13 Jul 2026 12:11:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:To:From:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vnt3ypfWeNL23UY1KrHNZewux6mQtgVXM5HeMULrIrY=; b=e0JzVVDOQsgjP8 S/Rt3QRmdbQKSAY4CQNs2RXrKfAaH3y1Bb0GQb5i+YMMkKljKcrmc9x2UF8DJhpmqDtUsDCvGROr4 q11PsSeE9oPSWjk5bYbC2p0Oks4c4FjN8mV98yRc1PMZGVGpNrag/nFV35cv10oYxupw8rPXSiM/j TBkFBtQMtzYlKPKsJwPrm6nKQrbJI+uf3qvqXBG5R0ANQ7oSVc96LKUUXjTn5FhKka94QkDf7B3G9 MgZgHqhtGQTL5tGMaGRGj9BRz8todMEXfPpkcJnQa3wh5fT4MBYEqF9IouuiwBXpAMhAaJwWfKvnI yp5qeavgz6oFQlJgRPjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjFVF-000000099Jq-3sLI; Mon, 13 Jul 2026 12:11:17 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjFVA-000000099HC-0V8I for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2026 12:11:15 +0000 Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-38deea72eebso932180a91.1 for ; Mon, 13 Jul 2026 05:11:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783944671; x=1784549471; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vnt3ypfWeNL23UY1KrHNZewux6mQtgVXM5HeMULrIrY=; b=jmTHSFhxWLaBI3/sFEYikae/aACqqNvHCHVyB99f/1nfTXhg9nI29il6PtbdxVFGBv ZMY+AzCWIpcQCXEe1xWm9WcRxpFGHOJ/jJ7OWdLEK6D8nJdFH5sp+BUjgManyPjPcux7 y+vkjWneKLFRoJBxuq70+1bni49YISCPivTvUrpL5sID/YSpaOvk0sm0HQ+CgTiRCbRG i7CQGenuuBy++tzsWoPvmZFfhc8nxg3J81gEla/4YL0fZgSlku9JPw1AhtyHr3Ajl8Ch 4wddTNcd31308IX4/CO9Ln6X1kcELwZTiKxJT229HLtXyxBt44lBz8fxLCAdH/iCOP70 ZBMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783944671; x=1784549471; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=vnt3ypfWeNL23UY1KrHNZewux6mQtgVXM5HeMULrIrY=; b=DsTeQLWBOumyK7sPv9OR5TP00WXFOJzUNW21sqFuZquMcyqWSFUPHBI8YNHaWIVnkl 5UYf6BEBkiTWLhn9Pz66alMxevJNjWK1kqBMYudtBTx6m6rrpMfU8GicY2aNrlBCxggh dudsQ7cObAXKSDRJLuBjB+2Lfm7jmZzUma9Mx2wBQYfcqyMWU8vAVerMJFh6wC8KfHFQ xadDhX9J9HguQytNSwVybmGTCjJgetM/X027/cdKfIRvf1G3FtXHW+bcXCriLA/PxLMP B4zdxAP/IPY9+ucWYSka9S8EsIiRK4wqawKlLv2GmOtvjCacPGmkexabhC+Ur54S8+XV vdyg== X-Forwarded-Encrypted: i=1; AHgh+Rqt8IL5K8LfDaRAoD0WmEjyp2p00GXKZqzKmc/1fEUxtqd1ngWoZ4iQ6x2BqbGORzjYOEDYJjDqAiSvsafm/zlP@lists.infradead.org X-Gm-Message-State: AOJu0YzyiOBHI6PI6re+XwG7E5ouwtDkgU1jBESW8uOJ4oipKuihoA4V OhS+7ZHaKeHDG5PvwOoe4DeUisP3zWWF1Z2f9VnToXZM2H4h1MLc63oeRGJEIQ== X-Gm-Gg: AfdE7cl+FB6TVKa8Kt5bWje1J+/XBjfh9rtlCdOKervLRLZGcRxHQN1FU7k8NUKWjEy yfYwEene22MkcUxf8aN4xhaCfasK8cfx42zbx0tDK9DWFEmTmzmSqIlds6mtADoVgFhZQkQ/mqy h9ueM0HRNDNSweocTspNzMGXQAY4icFLVcbpvbV/NfwK0lhz+6sdzuRbUWDbjmgV0PA4Ml1B065 FxSK/cItuMP+aw7isXoH/vkKBXVVRFRD31Y+LVK5v+HWpovyKlXYjUOAmYYvfWMW6smAI+BQYiz ag1b+5dfUewtRmLN6jq852r+Q93+w5V8gtgc+a/kqwsH8oczOnEgc2r17E6ofBin86ZUtbHNmYY s44aEJkYoOBJsRFWM/XAnlk5TDQCjRSw4FsIGkhxMxKOWVNSU7hPDA8NW0QLl4WsXCkfu1y/fvH jFdQUKfRcHbei8nvcWh+Sd X-Received: by 2002:a17:90b:4990:b0:36a:a16b:5f6d with SMTP id 98e67ed59e1d1-38dc74c4c2cmr9218450a91.7.1783944671501; Mon, 13 Jul 2026 05:11:11 -0700 (PDT) Received: from rockpi-5b ([45.112.0.180]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311747f7293sm67756935eec.3.2026.07.13.05.11.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 05:11:10 -0700 (PDT) From: Anand Moon To: Neil Armstrong , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Mauro Carvalho Chehab , Greg Kroah-Hartman , dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR AMLOGIC SOCS), linux-amlogic@lists.infradead.org (open list:DRM DRIVERS FOR AMLOGIC SOCS), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Amlogic Meson SoC support), linux-kernel@vger.kernel.org (open list), linux-media@vger.kernel.org (open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS), linux-staging@lists.linux.dev (open list:STAGING SUBSYSTEM) Subject: [PATCH v7 13/19] media: meson: vdec: Fix race conditions in job abort sequence Date: Mon, 13 Jul 2026 17:37:08 +0530 Message-ID: <20260713120840.17427-14-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260713120840.17427-1-linux.amoon@gmail.com> References: <20260713120840.17427-1-linux.amoon@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260713_051114_797321_3CB843B7 X-CRM114-Status: GOOD ( 15.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Doruk Tan Ozturk , Nicolas Dufresne Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Implement proper cleanup inside vdec_m2m_job_abort to safely stop the hardware job sequence during a streaming abort or teardown. Without this, if a job is aborted right after being triggered, the deferred work item (esparser_queue_work) scheduled by device_run could continue running concurrently. This leads to unexpected behavior and potential use-after-free bugs if session structures are cleared. Fix this by flagging the session to stop via WRITE_ONCE, synchronously canceling any pending parser work, and safely clearing the active core session pointer under the core lock protection. Cc: Nicolas Dufresne Signed-off-by: Anand Moon --- drivers/staging/media/meson/vdec/vdec.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c index b3e1d99e8889f..ac86a9c4febff 100644 --- a/drivers/staging/media/meson/vdec/vdec.c +++ b/drivers/staging/media/meson/vdec/vdec.c @@ -167,6 +167,17 @@ static void vdec_m2m_device_run(void *priv) static void vdec_m2m_job_abort(void *priv) { struct amvdec_session *sess = priv; + struct amvdec_core *core = sess->core; + + WRITE_ONCE(sess->should_stop, 1); + + cancel_work_sync(&sess->esparser_queue_work); + + mutex_lock(&core->lock); + if (core->cur_sess == sess) + /* Safely clear hardware ownership since we were confirmed as the owner */ + smp_store_release(&core->cur_sess, NULL); + mutex_unlock(&core->lock); v4l2_m2m_job_finish(sess->core->m2m_dev, sess->m2m_ctx); } -- 2.50.1