Re: [PATCH v5 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The schema incorrectly forbids `mode-*` properties for `pmk8350-pon` and its fallbacks, breaking reboot mode configuration.
--

--- Patch [1]: [PATCH v5 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU ---
commit c59d0da4493e27ba6b287b072dffcd65652a9310
Author: Rakesh Kota <rakesh.kota@oss.qualcomm.com>

dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU

This commit introduces the PMM8654AU compatible string as a fallback to the
baseline PMK8350 PON implementation. It also updates the schema to enforce
that both the hlos and pbs register address spaces are always present for
the Gen3 PON peripherals.

> diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> index 979a377cb4ffd..09eea48c709e5 100644
> --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> @@ -17,12 +17,16 @@ description: |
>  
>  properties:
>    compatible:
> -    enum:
> -      - qcom,pm8916-pon
> -      - qcom,pm8941-pon
> -      - qcom,pms405-pon
> -      - qcom,pm8998-pon
> -      - qcom,pmk8350-pon
> +    oneOf:
> +      - enum:
> +          - qcom,pm8916-pon
> +          - qcom,pm8941-pon
> +          - qcom,pms405-pon
> +          - qcom,pm8998-pon
> +          - qcom,pmk8350-pon
> +      - items:
> +          - const: qcom,pmm8654au-pon
> +          - const: qcom,pmk8350-pon

[Severity: High]
This is a pre-existing issue, but does the current schema incorrectly forbid
mode-* properties for pmk8350-pon and its fallbacks, breaking reboot mode
configuration?

Because the Gen3 compatibles are missing from the earlier allOf if condition
that matches pm8916-pon, pms405-pon, and pm8998-pon, they fall into the else
branch:

    else:
      patternProperties:
        "^mode-.*$": false

Will this cause dtbs_check to spuriously reject valid mode-* properties for
the newly added pmm8654au-pon PMIC?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713-b4-add_pwrkey_and_resin-v5-0-3bea476e1453@oss.qualcomm.com?part=1