Re: [PATCH v3 09/10] dt-bindings: display: mediatek: wdma: Add compatibles for more SoCs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The compatible string `mediatek,mt6893-disp-wdma` is incorrectly placed in the standalone `enum` block instead of the fallback `items` block, which either prevents driver binding or fails schema validation.
--

--- Patch [9]: [PATCH v3 09/10] dt-bindings: display: mediatek: wdma: Add compatibles for more SoCs ---
commit c59d6955686a17afe19c1a5b4dee46c913103970
Author: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

dt-bindings: display: mediatek: wdma: Add compatibles for more SoCs

This commit adds missing compatibles for Write DMA hardware on Dimensity
1200 and Kompanio 500/520/820/1200 SoCs.

> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.yaml
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.yaml
> @@ -22,11 +22,16 @@ properties:
>    compatible:
>      oneOf:
>        - enum:
> +          - mediatek,mt6893-disp-wdma
>            - mediatek,mt8173-disp-wdma

[Severity: Medium]
Will this cause an issue for device trees trying to probe the mt6893 hardware?

Since this compatible string is placed in the standalone enum block instead
of the fallback items block, a device tree node providing only this string
will pass schema validation but fail to probe in the kernel, as the driver
only matches the mediatek,mt8173-disp-wdma fallback.

Conversely, if a device tree provides the necessary fallback string to
enable the driver to probe, it will fail schema validation because the
array of strings won't match this single-item enum block. 

Should this be moved to the fallback items list below alongside the other
newly added SoC variants?

>        - items:
>            - enum:
>                - mediatek,mt6795-disp-wdma
>                - mediatek,mt8167-disp-wdma
> +              - mediatek,mt8183-disp-wdma
> +              - mediatek,mt8186-disp-wdma
> +              - mediatek,mt8192-disp-wdma
> +              - mediatek,mt8195-disp-wdma
>            - const: mediatek,mt8173-disp-wdma

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713130103.34654-1-angelogioacchino.delregno@collabora.com?part=9