From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8E53C43458 for ; Mon, 13 Jul 2026 14:04:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 58232407E5; Mon, 13 Jul 2026 14:04:27 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id EXYFtvFz0teK; Mon, 13 Jul 2026 14:04:25 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 383DD407D2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1783951465; bh=iEWBIXSUZSuaWbancgt7Nm/gcjHCwECQpYUbCavS7bc=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=PKe7LHrqV9LKHWr9W8MLjpU/rEUbauBBhzzv5JLjtpvP7cmlAh4EpYeSUTDRBp4In hKIHCqUAircWYtHTHZIdqandpz06QFU9HcupqKGbcBnx7RFqsz9QGt7i64NszPLl5d N8Kx5Fe2Hb3SpBYeZGHc1qJiwM1xG56S+O4cZkv9xlwZpQ6aA/ROwIK9+tjMMIZ747 822jF9QpWRkPk9wtsgcGCKZAsz174dt1lAYSNpvm2vXE1nh6mdiG3fc0FiSAXNtz0z ueoPgKrvAfawXOTWPcQ9gcML56ngAm/5MwZcZhR2F0IuS+7kApThq6Kw8kRqI+sJI/ z+HyJ2Vvif9iQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 383DD407D2; Mon, 13 Jul 2026 14:04:25 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists1.osuosl.org (Postfix) with ESMTP id 870B02EE for ; Mon, 13 Jul 2026 14:04:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 6CF2D400D3 for ; Mon, 13 Jul 2026 14:04:23 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 29OiOYyziPS7 for ; Mon, 13 Jul 2026 14:04:22 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 97300400C7 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 97300400C7 Received: from tor.source.kernel.org (tor.source.kernel.org [IPv6:2600:3c04:e001:324:0:1991:8:25]) by smtp2.osuosl.org (Postfix) with ESMTPS id 97300400C7 for ; Mon, 13 Jul 2026 14:04:22 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 9B24B6004E; Mon, 13 Jul 2026 14:04:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCA901F000E9; Mon, 13 Jul 2026 14:04:18 +0000 (UTC) Date: Mon, 13 Jul 2026 15:04:16 +0100 From: Simon Horman To: Przemek Kitszel Message-ID: <20260713140416.GG1364329@horms.kernel.org> References: <20260706224346.22546-1-przemyslaw.kitszel@intel.com> <20260706224346.22546-2-przemyslaw.kitszel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260706224346.22546-2-przemyslaw.kitszel@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783951461; bh=iEWBIXSUZSuaWbancgt7Nm/gcjHCwECQpYUbCavS7bc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=be6rjXPlsF12RiytNIWlQ27Kji7tACddBoYG4nIetBtEGnUxE8CnxkGTcAWbkScAY 30Dui7DsiuAnpUUfKaNg7r59/5k898DQvNuvTtVlEWH5gxsWP1Ra2+aj/iDCD6Ohys FYNkQtW8FakQ9bXvdaRoXNYG+nMDQC5t4LL0hZk/cSFhQhyNF45hOB/tRFvCjxWIO3 9ZvL7LbMygx3jWtOnlJbrWY2vyEmWHGwSVRh7yRpc1jN6nNGYE0mSlV+4eqXiQuN6V p/ldtDbZC4HNRILC30I8NNPWaPXM2e8eI9yni5IRda2kpnOeuMEzEIVH0O6Q4Wvsq6 s4qXJhgN6JXSg== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=be6rjXPl Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2 2/2] ice: fix stats array overflow via proper realloc X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Piotr Kwapulinski , Paolo Abeni , netdev@vger.kernel.org, Jedrzej Jagielski , Aleksandr Loktionov , Andrew Lunn , Eric Dumazet , Marcin Szycik , Tony Nguyen , Jakub Kicinski , intel-wired-lan@lists.osuosl.org, "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Jul 07, 2026 at 12:43:31AM +0200, Przemek Kitszel wrote: > Integrate ice_vsi_alloc_stat_arrays() with realloc variant. > > Instead of keeping two functions for stat arrays allocation, change the > ice_vsi_realloc_stat_arrays() to handle initial condition (no vsi_stat > entry) and replace ice_vsi_alloc_stat_arrays() by the more generic > ice_vsi_realloc_stat_arrays(). > > Note that VSIs of ICE_VSI_CHNL type are ignored in realloc variant as they > were in the replaced ice_vsi_alloc_stat_arrays(). > > This is a fix for stats array overflow that occurs when VF is given more > queues (an operation that will be more frequent, and by bigger increase, > when we will merge my "XLVF" series). > > Splat for increasing number of queues thanks to Michal Schmidt: > KASAN detects the bug: ... > Fixes: 2a2cb4c6c181 ("ice: replace ice_vf_recreate_vsi() with ice_vf_reconfig_vsi()") > Closes: https://redhat.atlassian.net/browse/RHEL-164321 > Reviewed-by: Marcin Szycik > Signed-off-by: Przemek Kitszel > --- > This is an alternative to the fix [1] by Michal Schmidt, which were > blocked due to AI feedback. My fix was already developed before Michal's, > just not public back then. We have agreed to go on with my version. > > [1] https://lore.kernel.org/netdev/20260520183501.3360810-3-anthony.l.nguyen@intel.com Reviewed-by: Simon Horman ... From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99AF4381EA6 for ; Mon, 13 Jul 2026 14:04:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783951462; cv=none; b=J90HZzQ9qHQ4YrHP61O4UEIzn10u/79su/A3q1t2LUozSP3L/rxmgoJpvmYxm9VL9e4ww2Kfge5k218fGn1zlFcT4v51OQscUXONWJtoZCTMAQnBG6NeFcBWiFNHp2D5z//nMMQ3MiPZKZ2UcH4DvE6sjhFpUPhku4CPjGjBz8A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783951462; c=relaxed/simple; bh=rhLBkBLyavTbrkhr2wKD2LjV1TR+KnkRUBTYwaUrkhw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZH9zWim7Kjy+/cPnGH0YW+EsSoerZlSpve5OEAgDzBwUSZl1+n2h9+dpX7WbMr22wtNk8gjtDSs7CFogjc5gIVn5WYljb/YImLSabX29UZ107V1OkASqo0N4KLFiIzan8wdeyXZ9eqzkgT3g2MUdZA8Ca0GzwCWSHp6dFt5wt9I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=be6rjXPl; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="be6rjXPl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCA901F000E9; Mon, 13 Jul 2026 14:04:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783951461; bh=iEWBIXSUZSuaWbancgt7Nm/gcjHCwECQpYUbCavS7bc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=be6rjXPlsF12RiytNIWlQ27Kji7tACddBoYG4nIetBtEGnUxE8CnxkGTcAWbkScAY 30Dui7DsiuAnpUUfKaNg7r59/5k898DQvNuvTtVlEWH5gxsWP1Ra2+aj/iDCD6Ohys FYNkQtW8FakQ9bXvdaRoXNYG+nMDQC5t4LL0hZk/cSFhQhyNF45hOB/tRFvCjxWIO3 9ZvL7LbMygx3jWtOnlJbrWY2vyEmWHGwSVRh7yRpc1jN6nNGYE0mSlV+4eqXiQuN6V p/ldtDbZC4HNRILC30I8NNPWaPXM2e8eI9yni5IRda2kpnOeuMEzEIVH0O6Q4Wvsq6 s4qXJhgN6JXSg== Date: Mon, 13 Jul 2026 15:04:16 +0100 From: Simon Horman To: Przemek Kitszel Cc: intel-wired-lan@lists.osuosl.org, Michal Schmidt , Jakub Kicinski , netdev@vger.kernel.org, Tony Nguyen , Aleksandr Loktionov , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Jedrzej Jagielski , Piotr Kwapulinski , Marcin Szycik Subject: Re: [PATCH iwl-net v2 2/2] ice: fix stats array overflow via proper realloc Message-ID: <20260713140416.GG1364329@horms.kernel.org> References: <20260706224346.22546-1-przemyslaw.kitszel@intel.com> <20260706224346.22546-2-przemyslaw.kitszel@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260706224346.22546-2-przemyslaw.kitszel@intel.com> On Tue, Jul 07, 2026 at 12:43:31AM +0200, Przemek Kitszel wrote: > Integrate ice_vsi_alloc_stat_arrays() with realloc variant. > > Instead of keeping two functions for stat arrays allocation, change the > ice_vsi_realloc_stat_arrays() to handle initial condition (no vsi_stat > entry) and replace ice_vsi_alloc_stat_arrays() by the more generic > ice_vsi_realloc_stat_arrays(). > > Note that VSIs of ICE_VSI_CHNL type are ignored in realloc variant as they > were in the replaced ice_vsi_alloc_stat_arrays(). > > This is a fix for stats array overflow that occurs when VF is given more > queues (an operation that will be more frequent, and by bigger increase, > when we will merge my "XLVF" series). > > Splat for increasing number of queues thanks to Michal Schmidt: > KASAN detects the bug: ... > Fixes: 2a2cb4c6c181 ("ice: replace ice_vf_recreate_vsi() with ice_vf_reconfig_vsi()") > Closes: https://redhat.atlassian.net/browse/RHEL-164321 > Reviewed-by: Marcin Szycik > Signed-off-by: Przemek Kitszel > --- > This is an alternative to the fix [1] by Michal Schmidt, which were > blocked due to AI feedback. My fix was already developed before Michal's, > just not public back then. We have agreed to go on with my version. > > [1] https://lore.kernel.org/netdev/20260520183501.3360810-3-anthony.l.nguyen@intel.com Reviewed-by: Simon Horman ...