Re: [LTP] madvise09: Reset cgroup limits before retrying test

[linuxtestproject.agent@gmail.com]

Hi Wake,

On Mon Jul 13 11:42:20 2026, Wake Liu wrote:
> madvise09: Reset cgroup limits before retrying test

> Reset both memory.max and memory.swap.max to "max" at the start of
> child() to ensure each retry run begins in an unconstrained cgroup.

The description says "reset both" unconditionally, but memory.swap.max
is only reset when swap_accounting_enabled is true:

> +	SAFE_CG_PRINT(tst_cg, "memory.max", "max");
> +	if (swap_accounting_enabled)
> +		SAFE_CG_PRINT(tst_cg, "memory.swap.max", "max");

The code itself is correct -- it mirrors the conditional set pattern
already in child().  The commit message just omits the conditional.
Something like:

  Reset memory.max unconditionally, and memory.swap.max when swap
  accounting is enabled, to "max" at the start of child() ...

would match the code more accurately.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp