All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Andrey Albershteyn <aalbersh@kernel.org>
Cc: linux-xfs@vger.kernel.org, hch@lst.de
Subject: [PATCH] xfs_scrub: fix spacemap scan for data volume
Date: Mon, 13 Jul 2026 08:55:10 -0700	[thread overview]
Message-ID: <20260713155510.GD7195@frogsfrogsfrogs> (raw)

From: Darrick J. Wong <djwong@kernel.org>

I don't know why this hunk got copied into scan_ag_rmaps on merge.  The
original patch only touched scan_rtg_rmaps.  Get rid of this new
inclusion because now it's broken for the data device.

Cc: <linux-xfs@vger.kernel.org> # v7.1.0
Fixes: 074c18165ea339 ("xfs_scrub: fix spacemap scan for internal rt devices")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
 scrub/spacemap.c |   13 -------------
 1 file changed, 13 deletions(-)

diff --git a/scrub/spacemap.c b/scrub/spacemap.c
index 26d05163bde971..65d716374c9eb3 100644
--- a/scrub/spacemap.c
+++ b/scrub/spacemap.c
@@ -111,19 +111,6 @@ scan_ag_rmaps(
 	keys[1].fmr_offset = ULLONG_MAX;
 	keys[1].fmr_flags = UINT_MAX;
 
-	/*
-	 * fsmap for an internal rt volume treats physical ranges as offsets
-	 * into the underlying block device.  Shift the query range up by
-	 * @rtstart here to skip the synthetic "internal filesystem" fsmap.
-	 */
-	if (ctx->mnt.fsgeom.rtstart) {
-		uint64_t	offset = ctx->mnt.fsgeom.rtstart *
-					 ctx->mnt.fsgeom.blocksize;
-
-		keys[0].fmr_physical += offset;
-		keys[1].fmr_physical += offset;
-	}
-
 	if (sbx->aborted)
 		return;
 

             reply	other threads:[~2026-07-13 15:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-13 15:55 Darrick J. Wong [this message]
2026-07-14  7:45 ` [PATCH] xfs_scrub: fix spacemap scan for data volume Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260713155510.GD7195@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=aalbersh@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.