From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFAA534C9A6 for ; Mon, 13 Jul 2026 17:54:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783965277; cv=none; b=GBaV6mRKE1McR45rwHbjE5Go8U+tvMynbPfH+KxCn8t42ehdDqwhHqXrk8eAhY5SRPrZSFW6DThaLx9fN9SGcy+PrMvIHpoNgzh6cb7seQDvaGDhlZ7kSDdekVM1cBzD2qsa6rjHFf9qah4IxzUEsrJP2mWY16nrp7UdsmMhjkY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783965277; c=relaxed/simple; bh=K2KZlv8DzBtV03E/TVL3MeUwYAAgOJe/Vo9Rt0OvASs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MmVcaYialGyrEW/nj/yOZcehdS48cS1dKJToaB1COzlIEA0jcvfa86CzmPMz27b42/v/UK6VtSrulYwKipokuNTZ9a2pjP0n+CKCBvyl3z8X6Xn3xIcPmnXVXsmvhjUk9THuy2AqSFfYxXy+89+9fAGrFYYZf1bp3a98fy8WXE4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=VwE9LL26; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="VwE9LL26" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-92e57a753f9so265013085a.2 for ; Mon, 13 Jul 2026 10:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1783965275; x=1784570075; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Yflr35iQtozkrKsWPSXMB3haiCYqPE+VDxf/660hH9k=; b=VwE9LL26Wmj3Bic97jnDe0FdhlxJKNHI8GF5oPUVFEzjHop6rveZn25da/L2GWKkXr sSnBTm7wvTMgjGmMCwv6qvZJP4hUUADTspmHja544fGTlGVAxs1fJRp19KPWi+jDJFTg cm+sm6zVXebpXv3cNYFdQzmd66mejtVPfokoETaVS49213pzGpJ5CzRMihCvh/kXJuUu /8w2V1ZaSCBbYS0W1PxynFlBIjoKn1fM6X5myfw+amdRuSpsYq7Qe3dCd+V2qoCY9iug bzU60uHdF8XiEUZ3MzWyy3mMUVU9i8EQS0Xx70hgHbrxZvnROMHz1ZJA5P4EXhkTIfVX I/Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783965275; x=1784570075; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Yflr35iQtozkrKsWPSXMB3haiCYqPE+VDxf/660hH9k=; b=FAHRXPmOeaLxbzo++kvV3v/4wlCpILoNI4s9Og+QM3odNAjCrmUB8bHsUm1rrqKSw7 FkzJSDN9Fib2LGieblbPW/cHRkVB2vB3+RiD5mb56Uy/siDl57/+W2IVaibpQpfswz4q pYFZ6iDkS3A3u2NuP1qWDYsTZEAMztklQRZ7yosklTUTGye8HPCLAYkxKvB2vh0hydVl rgjxXTkmzEw+Xuz0S/PdassPU4kweq6VYsEMo1y8ciaLKWoQRsHbDjbp6KYRVru5Tow8 ukSQ8I9nAUy5EH7qdMLf1LbhJRXUUG7Ewxsod4vXBb7/SYdPcGlIhMh0cx9CdMFDtcTV UkdQ== X-Forwarded-Encrypted: i=1; AHgh+Rq4poOKTdkHKELrr7wFdCZx+DfWsH+ySoKzFlfakf77ZLTwLTkHg/juHicHK5/A9GRCwqR95MoB7A5rRjU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8/dBCc9zwgGojiOChLlA0LSXt4/hlt2C4PIAQhyOPn3sooZp2 9hmjn3EgNT4wzd9xdV9Y6qROv/XtOiFp15r8wF5hu/XDf0IO2zHp6wcartYmj5N/qNs= X-Gm-Gg: AfdE7clY2cMBNGrTaCrqms38t794s5LLxMSDVBoZ7qTVDqrZrFkhxLag8fY5Mi1ayaI YuORB7Pe7j/aEV5WQwzsCtFI3WgtU1hseN5fad4kMfA0ZcGboGbezOgjPqayrTeXOR3b/tX0/Xm 9ho62lishpqhUp/FCDhjwIOlGQKRNfbDY+1oUXgK56SGplA9lHIvLt0CAA+ke8hvWmrN9e3J+q2 P/Vt9z1YRrbpqaw9OFBUhPrvzCHPRQMsAaCGOhEaoHSgtDpHhQfd/gU8rvqh0ajUoJBcEybjR1E TRPVayrl7Of3p/eARaWQJZsEp5wH4TgxE3n8OjpfdCaus6TjqI/lKGSMnfvh805t2Q7nJ5Y77FU C4lh805VLPBixlvfLcQVwQaOpf6IdKDYbRfCMUn4Nas03FkNYcE+tnuX1ZxYJ X-Received: by 2002:a05:620a:469e:b0:915:94f7:55df with SMTP id af79cd13be357-92ef2bd609cmr983527785a.20.1783965274729; Mon, 13 Jul 2026 10:54:34 -0700 (PDT) Received: from ziepe.ca ([159.2.72.92]) by smtp.gmail.com with ESMTPSA id af79cd13be357-92ee5cfdf6fsm1229104285a.24.2026.07.13.10.54.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 10:54:34 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wjKrR-0000000DwzJ-2as1; Mon, 13 Jul 2026 14:54:33 -0300 Date: Mon, 13 Jul 2026 14:54:33 -0300 From: Jason Gunthorpe To: "Aneesh Kumar K.V (Arm)" Cc: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, Robin Murphy , Marek Szyprowski , Will Deacon , Marc Zyngier , Steven Price , Suzuki K Poulose , Catalin Marinas , Jiri Pirko , Mostafa Saleh , Petr Tesarik , Alexey Kardashevskiy , Dan Williams , Xu Yilun , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , x86@kernel.org, Michael Kelley Subject: Re: [PATCH v7 02/22] dma-pool: fix page leak in atomic_pool_expand() cleanup Message-ID: <20260713175433.GI3133966@ziepe.ca> References: <20260701054926.825925-1-aneesh.kumar@kernel.org> <20260701054926.825925-3-aneesh.kumar@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260701054926.825925-3-aneesh.kumar@kernel.org> On Wed, Jul 01, 2026 at 11:19:06AM +0530, Aneesh Kumar K.V (Arm) wrote: > @@ -115,8 +116,10 @@ static int atomic_pool_expand(struct gen_pool *pool, size_t pool_size, > */ > ret = set_memory_decrypted((unsigned long)page_to_virt(page), > 1 << order); > - if (ret) > + if (ret) { > + leak_pages = true; > goto remove_mapping; > + } Truely these _set_memory_decrypted() things are an insane API. So a if it fails to decrypt it can be in any messy state? > @@ -130,14 +133,15 @@ static int atomic_pool_expand(struct gen_pool *pool, size_t pool_size, > 1 << order); > if (WARN_ON_ONCE(ret)) { > /* Decrypt succeeded but encrypt failed, purposely leak */ > - goto out; > + leak_pages = true; At least this one makes some sense.. Reviewed-by: Jason Gunthorpe Jason