From: "Alexey V. Vissarionov" <gremlin@altlinux.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: "Alexey V. Vissarionov" <gremlin@altlinux.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <linux@roeck-us.net>,
Casey Connolly <casey.connolly@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] usb: typec: tcpm: qcom: initialize currsrc explicitly
Date: Mon, 13 Jul 2026 21:22:57 +0300 [thread overview]
Message-ID: <20260713182257.GA22956@altlinux.org> (raw)
In-Reply-To: <a205f7ee-7894-4d6d-a752-b10b036b6c36@linaro.org>
Good ${greeting_time}!
On 2026-07-13 09:34:22 +0100, Bryan O'Donoghue wrote:
> On 13/07/2026 09:06, Alexey V. Vissarionov wrote:
>> When regmap_read() fails, the execution goes to done: label,
>> where currsrc is passed to rp_sel_to_name() and used as an
>> index after a proper check. However, to make this situation
>> easier to notice, an explicit initialization of currsrc with
>> obviously impossible value is suggested.
>> [...]
>> Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC
>> Type-C driver")
>> Signed-off-by: Alexey V. Vissarionov <gremlin@altlinux.org>
> This patch makes sense but doesn't require a Fixes: tag.
> With that changed.
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
ACK. Updated patch follows.
--
Alexey V. Vissarionov
gremlin ПРИ altlinux ТЧК org; +vii-cmiii-ccxxix-lxxix-xlii
GPG: 0D92F19E1C0DC36E27F61A29CD17E2B43D879005 @ hkp://keys.gnupg.net
prev parent reply other threads:[~2026-07-13 18:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 8:06 [PATCH] usb: typec: tcpm: qcom: initialize currsrc explicitly Alexey V. Vissarionov
2026-07-13 8:34 ` Bryan O'Donoghue
2026-07-13 18:22 ` Alexey V. Vissarionov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713182257.GA22956@altlinux.org \
--to=gremlin@altlinux.org \
--cc=bryan.odonoghue@linaro.org \
--cc=casey.connolly@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lvc-project@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.