Re: [PATCH v1 01/12] perf vendor events intel: Update alderlake events from 1.39 to 1.40

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The metric `tma_uc_bound` is referenced as a 'Related metric' in the PublicDescription of several metrics, but it is never defined for Alderlake.
--

--- Patch [1]: [PATCH v1 01/12] perf vendor events intel: Update alderlake events from 1.39 to 1.40 ---
commit 681de70c22f5f71f00cbba2dad4cf02fb3e6da9d
Author: Chun-Tse Shao <ctshao@google.com>

perf vendor events intel: Update alderlake events from 1.39 to 1.40

This commit updates the Alderlake performance events from version 1.39 to 1.40,
incorporating changes published in the intel/perfmon repository.

> diff --git a/tools/perf/pmu-events/arch/x86/alderlake/adl-metrics.json b/tools/perf/pmu-events/arch/x86/alderlake/adl-metrics.json
> index cae7c0cf02f22..e76d679a784b0 100644
> --- a/tools/perf/pmu-events/arch/x86/alderlake/adl-metrics.json
> +++ b/tools/perf/pmu-events/arch/x86/alderlake/adl-metrics.json
> @@ -800,16 +800,16 @@
>      },
>      {
>          "BriefDescription": "Total pipeline cost of external Memory- or Cache-Bandwidth related bottlenecks",
[ ... ]
>          "MetricGroup": "BvMB;Mem;MemoryBW;Offcore;tma_issueBW",
>          "MetricName": "tma_bottleneck_data_cache_memory_bandwidth",
>          "MetricThreshold": "tma_bottleneck_data_cache_memory_bandwidth > 20",
> -        "PublicDescription": "Total pipeline cost of external Memory- or Cache-Bandwidth related bottlenecks. Related metrics: tma_fb_full, tma_info_system_dram_bw_use, tma_mem_bandwidth, tma_sq_full",
> +        "PublicDescription": "Total pipeline cost of external Memory- or Cache-Bandwidth related bottlenecks. Related metrics: tma_fb_full, tma_info_system_dram_bw_use, tma_mem_bandwidth, tma_sq_full, tma_uc_bound",

[Severity: Low]
Does this reference a missing metric? The metric tma_uc_bound is listed as a
related metric here (and in a few other places), but it doesn't appear to be
defined in the Alderlake metric files. Could this cause confusion for users
viewing the metric descriptions?

>          "Unit": "cpu_core"
>      },

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713181757.481164-1-ctshao@google.com?part=1