Re: [PATCH v2 4/4] xfs: mark internal metadir file creation helpers static

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Jul 13, 2026 at 02:42:50PM +0200, Johannes Thumshirn wrote:
> Now that there is xfs_metadir_create_file() mark
> xfs_metadir_start_create(), xfs_metadir_create() and xfs_metadir_cancel()
> as static and remove them from xfs_metadir.h.
> 
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/libxfs/xfs_metadir.c | 6 +++---
>  fs/xfs/libxfs/xfs_metadir.h | 4 ----
>  2 files changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_metadir.c b/fs/xfs/libxfs/xfs_metadir.c
> index 0d6a153bc9e9..7c6b086b73db 100644
> --- a/fs/xfs/libxfs/xfs_metadir.c
> +++ b/fs/xfs/libxfs/xfs_metadir.c
> @@ -182,7 +182,7 @@ xfs_metadir_teardown(
>   * Begin the process of creating a metadata file by allocating transactions
>   * and taking whatever resources we're going to need.
>   */
> -int
> +static int
>  xfs_metadir_start_create(
>  	struct xfs_metadir_update	*upd)
>  {
> @@ -236,7 +236,7 @@ xfs_metadir_start_create(
>   * a negative error code.  If an inode is passed back, the caller must finish
>   * setting up the inode before releasing it.
>   */
> -int
> +static int
>  xfs_metadir_create(
>  	struct xfs_metadir_update	*upd,
>  	umode_t				mode)
> @@ -425,7 +425,7 @@ xfs_metadir_commit(
>  }
>  
>  /* Cancel a metadir update and unlock/drop all resources. */
> -void
> +static void
>  xfs_metadir_cancel(
>  	struct xfs_metadir_update	*upd,
>  	int				error)
> diff --git a/fs/xfs/libxfs/xfs_metadir.h b/fs/xfs/libxfs/xfs_metadir.h
> index a795a2d0e3fe..e434b9d1c932 100644
> --- a/fs/xfs/libxfs/xfs_metadir.h
> +++ b/fs/xfs/libxfs/xfs_metadir.h
> @@ -32,9 +32,6 @@ int xfs_metadir_load(struct xfs_trans *tp, struct xfs_inode *dp,
>  		const char *path, enum xfs_metafile_type metafile_type,
>  		struct xfs_inode **ipp);
>  
> -int xfs_metadir_start_create(struct xfs_metadir_update *upd);
> -int xfs_metadir_create(struct xfs_metadir_update *upd, umode_t mode);
> -
>  typedef int (*xfs_metadir_createfn)(struct xfs_metadir_update *upd, void *priv);
>  
>  int xfs_metadir_create_file(struct xfs_metadir_update *upd, umode_t mode,
> @@ -45,7 +42,6 @@ int xfs_metadir_start_link(struct xfs_metadir_update *upd);
>  int xfs_metadir_link(struct xfs_metadir_update *upd);
>  
>  int xfs_metadir_commit(struct xfs_metadir_update *upd);
> -void xfs_metadir_cancel(struct xfs_metadir_update *upd, int error);
>  
>  int xfs_metadir_mkdir(struct xfs_inode *dp, const char *path,
>  		struct xfs_inode **ipp);
> -- 
> 2.54.0
> 
>