From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C67C42E8B9B; Mon, 13 Jul 2026 23:57:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783987066; cv=none; b=t1JS698JUO5zrFigJwX+4ID9ngTW5efY6bD4TWcA9dSc/oAtuZQ7Mo7wZWECC9gPoyq6/NkqgGHC0pvTt+s7/c4ouzmciHUkqi6PG4DnOtYf64NdM3kzACaFUz63uEuqpjVmgd1AbowOWDNwchIsZXJIlsC1Pz6OQQLlzPT+0Kw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783987066; c=relaxed/simple; bh=024uMThOd6cyS6qgBSZV8Ud/4QoWdnppLmUJ/jWWSvg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K4KOOi2zjaqoatnQ19zM5hcAiQ6GjUWiO5rP04lUPhtJPk+Zbzeq1SfeKrEvjUYoXEeBo5nTNvwnGdkxIIS1Mw6djRe802IJy8rRTr454qI1EOxQgP9XnUXhvwHozpF0mPq419YtSf+kUPnmBx2I8Lnvf07y66lJ54yyot8XPm0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fq7zOW9x; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fq7zOW9x" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1FE21F000E9; Mon, 13 Jul 2026 23:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783987064; bh=xIhyR3zgIocehUTam0YtcBB6EqA+r73EXcnFWOui1a4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=fq7zOW9xN/onRd4/dFSQRSTXLCOxG14Xv/GM3rN4tHxAaVmnlvkQkaMZvRc5tkni/ OmgLQuza8B/thbJq8udck8bYCe2DrMcooTzy28LTcKkDE6c43PVO8w52FDiqolhibu wTPypcN3vs9GoQRP32YsTmjSVfcJkS78xZc8HjTn/uwtr0TGKMirpvK7d63tASXw90 GCXbPFkqqySHnXWKNDb7GNCHj0111QOz+PBD/2cx7YOGADFadkD92F0lEmAkoPoz9O pnbIGwJYdNUSdP7qBrxzem0u5tGaLwtXuqBh40GVMuLLzL+d4LfEI7cY/6TZmNMGCy Vq2LNGgiUdlcA== Date: Mon, 13 Jul 2026 23:57:42 +0000 From: Yixun Lan To: Anirudh Srinivasan Cc: Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "James E.J. Bottomley" , "Martin K. Petersen" , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] Add UFS Host driver support for SpacemiT K3 SoC Message-ID: <20260713235742-GKE106000@kernel.org> References: <20260702-08-k3-ufs-support-v1-0-1a64a3ab128f@kernel.org> <20260713123759-GKD106000@kernel.org> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi Anirudh, On 09:56 Mon 13 Jul , Anirudh Srinivasan wrote: > Hi Yixun, > > On Mon, Jul 13, 2026 at 7:38 AM Yixun Lan wrote: > > > > Hi Anirudh, > > > > On 22:40 Sun 12 Jul , Anirudh Srinivasan wrote: > > > Hi Yixun, > > > > > > On Thu, Jul 02, 2026 at 02:31:34AM +0000, Yixun Lan wrote: > > > > This series try to add UFS support for SpacemiT K3 SoC, the controller > > > > components consists of System Bus Interface Unit, UFS Host Controller > > > > Interface, UFS Transport Protocol Layer, UFS Host Registers, Device > > > > Management Entity (DME), Transport Layer, Network Layer, Data Link > > > > Layer, PHY Adapter Layer, and M-PHY Interface. A more detail functional > > > > block diagram can be found in SpacemiT website, chapter 9.7.3 [1] > > > > > > > > Please note, in order to test this driver, the UFS clock driver[2] here > > > > should be applied first as a prerequisite patch. > > > > > > > > One known issue is that the device will occasionally raise BKOPS interrupt > > > > when doing some high load test, log from dmesg shows > > > > > > > > [ 806.710763] ufshcd-spacemit c0e00000.ufshc: ufshcd_bkops_exception_event_handler: device raised urgent BKOPS exception for bkops status 1 > > > > > > > > Link: https://spacemit.com/community/document/info?nodepath=hardware/key_stone/k3/k3_docs/k3_usermanual/09_memory_storage.md&lang=en [1] > > > > Link: https://lore.kernel.org/all/20260630-06-clk-ufs-support-v1-0-cf7521d1d0fe@kernel.org/ [2] > > > > Signed-off-by: Yixun Lan > > > > > > I see this during probe on a k3-pico-itx. Does the UFS chip on board > > > have an RPMB block on it? Is this error of any concern. > > > > > It's probably true of having a RPMB block, but not used in K3 platform, so can ignore > > > > > [ 5.957864] ufshcd-spacemit c0e00000.ufshc: ufshcd_scsi_add_wlus: BOOT WLUN not found .. > > > [ 5.963319] bus_add_device: cannot add device 'ufs_rpmb0' to unregistered bus 'ufs_rpmb' Just checked code under drivers/ufs/, and couldn't find where ufs_rpmb bus is registered, so this kind of warning/error message is expected, or could UFS maintainer confirm this? > > > [ 5.971155] ufshcd-spacemit c0e00000.ufshc: Failed to register UFS RPMB device 0 > > > > > Maybe disable CONFIG_RPMB to silent this? I've not tested this option locally > > I'm testing on a distro defconfig, so it has this option enabled. > > Is there anything we can do in the driver to have it ignore the RPMB? No, but why not disable CONFIG_RPMB in the first place > If the error is a red-herring, we shouldn't be displaying it at all in > the first place. > Either fix the code or just ignore it.. -- Yixun Lan (dlan) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DD0BC43458 for ; Mon, 13 Jul 2026 23:58:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c6UqJUcix8O/5aTI1AJ8M0La1EqfRVRHNs5YfJrukzc=; b=LU/TJgDE+H84Qn 9STAYNz93TOvAQ1YzBsIr30MNEzH1+3btr+FlyrCudZcQxYTvO9Mv8BbSoDmihvfm9SnLVaO/S2id BT8TC0SFZeWeQ96WeU8JRKgyuS5/vGG+gVrKFbnEpfcIuDutP/OL9Ez3WPBwmrLztZNw2BAQ/hIQK f9KzZT4YQEt68Nt96R5UkUVYFDJlbahwj3DD4qMYuVHFY1sxFVnFR8dp+Um8SzZ9rqFcEKYKixScp xPLHyLzwF7O6V2di9ksG6a2gFf9q6Xu+YM5dVhY50PEQhH1s1ReVYFkuhd2HFty/5DE0Kr1JfiCRz sHeRrziirQrRCN8zA2NA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjQWx-0000000AZds-04uZ; Mon, 13 Jul 2026 23:57:47 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjQWv-0000000AZdm-3MCZ for linux-riscv@lists.infradead.org; Mon, 13 Jul 2026 23:57:45 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 961074175D; Mon, 13 Jul 2026 23:57:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1FE21F000E9; Mon, 13 Jul 2026 23:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783987064; bh=xIhyR3zgIocehUTam0YtcBB6EqA+r73EXcnFWOui1a4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=fq7zOW9xN/onRd4/dFSQRSTXLCOxG14Xv/GM3rN4tHxAaVmnlvkQkaMZvRc5tkni/ OmgLQuza8B/thbJq8udck8bYCe2DrMcooTzy28LTcKkDE6c43PVO8w52FDiqolhibu wTPypcN3vs9GoQRP32YsTmjSVfcJkS78xZc8HjTn/uwtr0TGKMirpvK7d63tASXw90 GCXbPFkqqySHnXWKNDb7GNCHj0111QOz+PBD/2cx7YOGADFadkD92F0lEmAkoPoz9O pnbIGwJYdNUSdP7qBrxzem0u5tGaLwtXuqBh40GVMuLLzL+d4LfEI7cY/6TZmNMGCy Vq2LNGgiUdlcA== Date: Mon, 13 Jul 2026 23:57:42 +0000 From: Yixun Lan To: Anirudh Srinivasan Cc: Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "James E.J. Bottomley" , "Martin K. Petersen" , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] Add UFS Host driver support for SpacemiT K3 SoC Message-ID: <20260713235742-GKE106000@kernel.org> References: <20260702-08-k3-ufs-support-v1-0-1a64a3ab128f@kernel.org> <20260713123759-GKD106000@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org SGkgQW5pcnVkaCwKCk9uIDA5OjU2IE1vbiAxMyBKdWwgICAgICwgQW5pcnVkaCBTcmluaXZhc2Fu IHdyb3RlOgo+IEhpIFlpeHVuLAo+IAo+IE9uIE1vbiwgSnVsIDEzLCAyMDI2IGF0IDc6MzjigK9B TSBZaXh1biBMYW4gPGRsYW5Aa2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4gSGkgQW5pcnVkaCwK PiA+Cj4gPiBPbiAyMjo0MCBTdW4gMTIgSnVsICAgICAsIEFuaXJ1ZGggU3Jpbml2YXNhbiB3cm90 ZToKPiA+ID4gSGkgWWl4dW4sCj4gPiA+Cj4gPiA+IE9uIFRodSwgSnVsIDAyLCAyMDI2IGF0IDAy OjMxOjM0QU0gKzAwMDAsIFlpeHVuIExhbiB3cm90ZToKPiA+ID4gPiBUaGlzIHNlcmllcyB0cnkg dG8gYWRkIFVGUyBzdXBwb3J0IGZvciBTcGFjZW1pVCBLMyBTb0MsIHRoZSBjb250cm9sbGVyCj4g PiA+ID4gY29tcG9uZW50cyBjb25zaXN0cyBvZiBTeXN0ZW0gQnVzIEludGVyZmFjZSBVbml0LCBV RlMgSG9zdCBDb250cm9sbGVyCj4gPiA+ID4gSW50ZXJmYWNlLCBVRlMgVHJhbnNwb3J0IFByb3Rv Y29sIExheWVyLCBVRlMgSG9zdCBSZWdpc3RlcnMsIERldmljZQo+ID4gPiA+IE1hbmFnZW1lbnQg RW50aXR5IChETUUpLCBUcmFuc3BvcnQgTGF5ZXIsIE5ldHdvcmsgTGF5ZXIsIERhdGEgTGluawo+ ID4gPiA+IExheWVyLCBQSFkgQWRhcHRlciBMYXllciwgYW5kIE0tUEhZIEludGVyZmFjZS4gQSBt b3JlIGRldGFpbCBmdW5jdGlvbmFsCj4gPiA+ID4gYmxvY2sgZGlhZ3JhbSBjYW4gYmUgZm91bmQg aW4gU3BhY2VtaVQgd2Vic2l0ZSwgY2hhcHRlciA5LjcuMyBbMV0KPiA+ID4gPgo+ID4gPiA+IFBs ZWFzZSBub3RlLCBpbiBvcmRlciB0byB0ZXN0IHRoaXMgZHJpdmVyLCB0aGUgVUZTIGNsb2NrIGRy aXZlclsyXSBoZXJlCj4gPiA+ID4gc2hvdWxkIGJlIGFwcGxpZWQgZmlyc3QgYXMgYSBwcmVyZXF1 aXNpdGUgcGF0Y2guCj4gPiA+ID4KPiA+ID4gPiBPbmUga25vd24gaXNzdWUgaXMgdGhhdCB0aGUg ZGV2aWNlIHdpbGwgb2NjYXNpb25hbGx5IHJhaXNlIEJLT1BTIGludGVycnVwdAo+ID4gPiA+IHdo ZW4gZG9pbmcgc29tZSBoaWdoIGxvYWQgdGVzdCwgbG9nIGZyb20gZG1lc2cgc2hvd3MKPiA+ID4g Pgo+ID4gPiA+IFsgIDgwNi43MTA3NjNdIHVmc2hjZC1zcGFjZW1pdCBjMGUwMDAwMC51ZnNoYzog dWZzaGNkX2Jrb3BzX2V4Y2VwdGlvbl9ldmVudF9oYW5kbGVyOiBkZXZpY2UgcmFpc2VkIHVyZ2Vu dCBCS09QUyBleGNlcHRpb24gZm9yIGJrb3BzIHN0YXR1cyAxCj4gPiA+ID4KPiA+ID4gPiBMaW5r OiBodHRwczovL3NwYWNlbWl0LmNvbS9jb21tdW5pdHkvZG9jdW1lbnQvaW5mbz9ub2RlcGF0aD1o YXJkd2FyZS9rZXlfc3RvbmUvazMvazNfZG9jcy9rM191c2VybWFudWFsLzA5X21lbW9yeV9zdG9y YWdlLm1kJmxhbmc9ZW4gWzFdCj4gPiA+ID4gTGluazogaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcv YWxsLzIwMjYwNjMwLTA2LWNsay11ZnMtc3VwcG9ydC12MS0wLWNmNzUyMWQxZDBmZUBrZXJuZWwu b3JnLyBbMl0KPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBZaXh1biBMYW4gPGRsYW5Aa2VybmVsLm9y Zz4KPiA+ID4KPiA+ID4gSSBzZWUgdGhpcyBkdXJpbmcgcHJvYmUgb24gYSBrMy1waWNvLWl0eC4g RG9lcyB0aGUgVUZTIGNoaXAgb24gYm9hcmQKPiA+ID4gaGF2ZSBhbiBSUE1CIGJsb2NrIG9uIGl0 PyBJcyB0aGlzIGVycm9yIG9mIGFueSBjb25jZXJuLgo+ID4gPgo+ID4gSXQncyBwcm9iYWJseSB0 cnVlIG9mIGhhdmluZyBhIFJQTUIgYmxvY2ssIGJ1dCBub3QgdXNlZCBpbiBLMyBwbGF0Zm9ybSwg c28gY2FuIGlnbm9yZQo+ID4KPiA+ID4gWyAgICA1Ljk1Nzg2NF0gdWZzaGNkLXNwYWNlbWl0IGMw ZTAwMDAwLnVmc2hjOiB1ZnNoY2Rfc2NzaV9hZGRfd2x1czogQk9PVCBXTFVOIG5vdCBmb3VuZAou Lgo+ID4gPiBbICAgIDUuOTYzMzE5XSBidXNfYWRkX2RldmljZTogY2Fubm90IGFkZCBkZXZpY2Ug J3Vmc19ycG1iMCcgdG8gdW5yZWdpc3RlcmVkIGJ1cyAndWZzX3JwbWInCgpKdXN0IGNoZWNrZWQg Y29kZSB1bmRlciBkcml2ZXJzL3Vmcy8sIGFuZCBjb3VsZG4ndCBmaW5kIHdoZXJlIHVmc19ycG1i IGJ1cyBpcyByZWdpc3RlcmVkLApzbyB0aGlzIGtpbmQgb2Ygd2FybmluZy9lcnJvciBtZXNzYWdl IGlzIGV4cGVjdGVkLCBvciBjb3VsZCBVRlMgbWFpbnRhaW5lciBjb25maXJtIHRoaXM/Cgo+ID4g PiBbICAgIDUuOTcxMTU1XSB1ZnNoY2Qtc3BhY2VtaXQgYzBlMDAwMDAudWZzaGM6IEZhaWxlZCB0 byByZWdpc3RlciBVRlMgUlBNQiBkZXZpY2UgMAo+ID4gPgo+ID4gTWF5YmUgZGlzYWJsZSBDT05G SUdfUlBNQiB0byBzaWxlbnQgdGhpcz8gSSd2ZSBub3QgdGVzdGVkIHRoaXMgb3B0aW9uIGxvY2Fs bHkKPiAKPiBJJ20gdGVzdGluZyBvbiBhIGRpc3RybyBkZWZjb25maWcsIHNvIGl0IGhhcyB0aGlz IG9wdGlvbiBlbmFibGVkLgo+IAo+IElzIHRoZXJlIGFueXRoaW5nIHdlIGNhbiBkbyBpbiB0aGUg ZHJpdmVyIHRvIGhhdmUgaXQgaWdub3JlIHRoZSBSUE1CPwoKTm8sIGJ1dCB3aHkgbm90IGRpc2Fi bGUgQ09ORklHX1JQTUIgaW4gdGhlIGZpcnN0IHBsYWNlCgo+IElmIHRoZSBlcnJvciBpcyBhIHJl ZC1oZXJyaW5nLCB3ZSBzaG91bGRuJ3QgYmUgZGlzcGxheWluZyBpdCBhdCBhbGwgaW4KPiB0aGUg Zmlyc3QgcGxhY2UuCj4gCgpFaXRoZXIgZml4IHRoZSBjb2RlIG9yIGp1c3QgaWdub3JlIGl0Li4K Ci0tIApZaXh1biBMYW4gKGRsYW4pCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LXJpc2N2Cg==