diff for duplicates of <202607140512.I7Hcmuea-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 89deca7..547f12a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,12 +1,6 @@ -BCC: lkp@intel.com -CC: oe-kbuild-all@lists.linux.dev -TO: Amir Goldstein <amir73il@gmail.com> - tree: https://github.com/amir73il/linux ovl_copy_file_range head: 4421f88f42bb20b8a6f9fd56c5c877a1088d0e00 commit: b86e287575a3f81b04ef92b5bb46f87329fc314f [3/6] fs: add support for copy file range from another fs -:::::: branch date: 9 hours ago -:::::: commit date: 9 hours ago config: i386-randconfig-141-20260714 (https://download.01.org/0day-ci/archive/20260714/202607140512.I7Hcmuea-lkp@intel.com/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 smatch: v0.5.0-9185-gbcc58b9c @@ -25,31 +19,27 @@ fs/read_write.c:1631 vfs_copy_file_range() error: we previously assumed 'file_ou vim +1499 fs/read_write.c -cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1482 -cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1483 /* -cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1484 * Check if src and dst file are on the same filesystem. -cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1485 * nfs and cifs define several different file_system_type structures -cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1486 * and several different sets of file_operations, but they all end up -cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1487 * using the same ->copy_file_range() function pointer. -cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1488 * COPY_FILE_SPLICE is an opt-in flag for cross-fs copy (e.g. from nfsd), -cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1489 * so do not compare src<->dst filesystems in this case. -cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1490 */ cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1491 static int copy_file_fs_cmp(struct file *f_in, struct file *f_out, cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1492 unsigned int flags) cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1493 { cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1494 if (flags & COPY_FILE_SPLICE) cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1495 return FS_COPY_SPLICE; cd6e8d0dbe33ef Amir Goldstein 2026-07-13 @1496 else if (f_out->f_op && f_out->f_op->copy_file_range && + ^^^^^^^^^^^ +if ->f_op is NULL + cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1497 f_out->f_op->copy_file_range == f_in->f_op->copy_file_range) cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1498 return FS_COPY_SAME_FS; b86e287575a3f8 Amir Goldstein 2026-07-13 @1499 else if (f_out->f_op->fop_flags & FOP_CROSS_FS_COPY) + ^^^^^^^^^^^^^^^^^^^^^^ +then we are toasted. + b86e287575a3f8 Amir Goldstein 2026-07-13 1500 return FS_COPY_FROM_OTHER_FS; cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1501 else if (file_inode(f_in)->i_sb == file_inode(f_out)->i_sb) cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1502 return FS_COPY_SAME_SB; cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1503 else cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1504 return FS_COPY_CROSS_FS; cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1505 } -cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1506 -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index 628cad8..486d062 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,20 +1,15 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0[amir73il:ovl_copy_file_range 3/6] fs/read_write.c:1499 copy_file_fs_cmp() error: we previously assumed 'f_out->f_op' could be null (see line 1496)\0" - "Date\0Tue, 14 Jul 2026 06:05:01 +0800\0" - "To\0oe-kbuild@lists.linux.dev\0" + "Date\0Tue, 14 Jul 2026 10:16:46 +0300\0" + "To\0oe-kbuild@lists.linux.dev" + " Amir Goldstein <amir73il@gmail.com>\0" "Cc\0lkp@intel.com" - " Dan Carpenter <error27@gmail.com>\0" + " oe-kbuild-all@lists.linux.dev\0" "\00:1\0" "b\0" - "BCC: lkp@intel.com\n" - "CC: oe-kbuild-all@lists.linux.dev\n" - "TO: Amir Goldstein <amir73il@gmail.com>\n" - "\n" "tree: https://github.com/amir73il/linux ovl_copy_file_range\n" "head: 4421f88f42bb20b8a6f9fd56c5c877a1088d0e00\n" "commit: b86e287575a3f81b04ef92b5bb46f87329fc314f [3/6] fs: add support for copy file range from another fs\n" - ":::::: branch date: 9 hours ago\n" - ":::::: commit date: 9 hours ago\n" "config: i386-randconfig-141-20260714 (https://download.01.org/0day-ci/archive/20260714/202607140512.I7Hcmuea-lkp@intel.com/config)\n" "compiler: gcc-14 (Debian 14.2.0-19) 14.2.0\n" "smatch: v0.5.0-9185-gbcc58b9c\n" @@ -33,34 +28,30 @@ "\n" "vim +1499 fs/read_write.c\n" "\n" - "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1482 \n" - "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1483 /*\n" - "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1484 * Check if src and dst file are on the same filesystem.\n" - "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1485 * nfs and cifs define several different file_system_type structures\n" - "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1486 * and several different sets of file_operations, but they all end up\n" - "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1487 * using the same ->copy_file_range() function pointer.\n" - "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1488 * COPY_FILE_SPLICE is an opt-in flag for cross-fs copy (e.g. from nfsd),\n" - "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1489 * so do not compare src<->dst filesystems in this case.\n" - "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1490 */\n" "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1491 static int copy_file_fs_cmp(struct file *f_in, struct file *f_out,\n" "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1492 \t\t\t unsigned int flags)\n" "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1493 {\n" "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1494 \tif (flags & COPY_FILE_SPLICE)\n" "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1495 \t\treturn FS_COPY_SPLICE;\n" "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 @1496 \telse if (f_out->f_op && f_out->f_op->copy_file_range &&\n" + " ^^^^^^^^^^^\n" + "if ->f_op is NULL\n" + "\n" "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1497 \t\t f_out->f_op->copy_file_range == f_in->f_op->copy_file_range)\n" "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1498 \t\treturn FS_COPY_SAME_FS;\n" "b86e287575a3f8 Amir Goldstein 2026-07-13 @1499 \telse if (f_out->f_op->fop_flags & FOP_CROSS_FS_COPY)\n" + " ^^^^^^^^^^^^^^^^^^^^^^\n" + "then we are toasted.\n" + "\n" "b86e287575a3f8 Amir Goldstein 2026-07-13 1500 \t\treturn FS_COPY_FROM_OTHER_FS;\n" "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1501 \telse if (file_inode(f_in)->i_sb == file_inode(f_out)->i_sb)\n" "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1502 \t\treturn FS_COPY_SAME_SB;\n" "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1503 \telse\n" "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1504 \t\treturn FS_COPY_CROSS_FS;\n" "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1505 }\n" - "cd6e8d0dbe33ef Amir Goldstein 2026-07-13 1506 \n" "\n" "--\n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -214ad61b7e8149a42cdd560801b25f7bd386d845f9e7c0a5d3a9b3e67fe8ef1a +c01e42f88f1e01a39fbd4597666909c7a8c2aff8237b838d6f24a423dead72ab
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.