All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: syyang@lontium.com
Cc: conor+dt@kernel.org, dri-devel@lists.freedesktop.org,
	robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v15 1/2] dt-bindings: bridge: Add Lontium LT7911EXC eDP to MIPI DSI bridge
Date: Tue, 14 Jul 2026 06:58:20 +0000	[thread overview]
Message-ID: <20260714065821.0950F1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260714064822.2753289-2-syyang@lontium.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Non-standard generic node name used in the device tree example. The Devicetree specification recommends using standard generic names for device nodes to represent the class of the device rather than the specific model or bus type (e.g., `bridge@` instead of `mipi-bridge@`).
--

--- Patch [1]: [PATCH v15 1/2] dt-bindings: bridge: Add Lontium LT7911EXC eDP to MIPI DSI bridge ---
commit 5c0643686f137815285d63f46eecfcaaaad55330
Author: Sunyun Yang <syyang@lontium.com>

dt-bindings: bridge: Add Lontium LT7911EXC eDP to MIPI DSI bridge

This commit adds the device tree binding schema for the Lontium LT7911EXC.
It documents an I2C-controlled bridge that converts eDP 1.4 input to MIPI
DSI output.

> diff --git a/Documentation/devicetree/bindings/display/bridge/lontium,lt7911exc.yaml b/Documentation/devicetree/bindings/display/bridge/lontium,lt7911exc.yaml
> new file mode 100644
> index 0000000000000..3290b10ce8835
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/lontium,lt7911exc.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        mipi-bridge@41 {

[Severity: Low]
This isn't a bug, but should this node name use a standard generic name like
bridge@41 instead of mipi-bridge@41? The Devicetree specification recommends
using standard generic names to represent the class of the device rather
than the specific bus type, which helps avoid dt-schema warnings.

> +            compatible = "lontium,lt7911exc";
> +            reg = <0x41>;
> +            reset-gpios = <&gpy8 8 GPIO_ACTIVE_LOW>;

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260714064822.2753289-1-syyang@lontium.com?part=1

  reply	other threads:[~2026-07-14  6:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14  6:48 [PATCH v15 0/2] Add Lontium LT7911EXC eDP to MIPI DSI bridge syyang
2026-07-14  6:48 ` [PATCH v15 1/2] dt-bindings: bridge: " syyang
2026-07-14  6:58   ` sashiko-bot [this message]
2026-07-14  6:48 ` [PATCH v15 2/2] drm/bridge: " syyang
2026-07-14  6:58   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260714065821.0950F1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=syyang@lontium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.