Re: [PATCH v1 07/20] gpio: Add missing OF module annotations

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Missing MODULE_DEVICE_TABLE export for the mpc52xx_simple_gpiochip_match table.
--

--- Patch [7]: [PATCH v1 07/20] gpio: Add missing OF module annotations ---
commit 292bbbdcede3ce86fe1309d514a852f272c27bac
Author: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>

gpio: Add missing OF module annotations

A driver module matching devices using an of device id table is supposed
to declare that in the module's metadata. Add this information for
several drivers that failed to declare these.

[ ... ]

> diff --git a/drivers/gpio/gpio-mpc5200.c b/drivers/gpio/gpio-mpc5200.c
> index 00f209157fd0f..2c828bc922ae3 100644
> --- a/drivers/gpio/gpio-mpc5200.c
> +++ b/drivers/gpio/gpio-mpc5200.c
> @@ -180,6 +180,7 @@ static const struct of_device_id mpc52xx_wkup_gpiochip_match[] = {
>  	{ .compatible = "fsl,mpc5200-gpio-wkup", },
>  	{}
>  };
> +MODULE_DEVICE_TABLE(of, mpc52xx_wkup_gpiochip_match);
>  
>  static struct platform_driver mpc52xx_wkup_gpiochip_driver = {
>  	.driver = {

[Severity: High]
This isn't a bug introduced by this patch, but since the patch focuses on
adding missing OF module annotations, should it also add one for the second
match table in this same file?

Further down in drivers/gpio/gpio-mpc5200.c, mpc52xx_simple_gpiochip_match
is also missing an export:

static const struct of_device_id mpc52xx_simple_gpiochip_match[] = {
	{ .compatible = "fsl,mpc5200-gpio", },
	{}
};

static struct platform_driver mpc52xx_simple_gpiochip_driver = {
	.driver = {
		.name = "mpc5200-gpio",
		.of_match_table = mpc52xx_simple_gpiochip_match,
    ...

Without exporting this second match table, the module lacks the modalias for
"fsl,mpc5200-gpio". Could this prevent it from automatically loading if the
system's device tree only contains the simple GPIO node (such as when the
wakeup node is absent or disabled)?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1784013063.git.u.kleine-koenig@baylibre.com?part=7