From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A83E6370D4F for ; Tue, 14 Jul 2026 10:30:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784025004; cv=none; b=gZCvSiqWB/yPEv2t4NdeOzX4wg0RZRnCXMSrge3BkrbRKwtgUke56A62GtCwDADG/PWQYn+fRpnnWlx1f90tl0ohz2LddzcVTIwHdmrr9IvwL4ZlvgKVWyBhcWfhNFJGpTvJnfITma1Z+V4Z6Op79NxDCSCaKGOCETPSbYbvl4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784025004; c=relaxed/simple; bh=q0ZGOFUJLsXLvegeJxYlGQBs1GV578olOBdASNhBjpg=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=tVMdPxDFrWGhVSh1u7bX80nH/mcLrePtRgnNa5JcpMDuaYz1HzuDaWzPEKvKWwYcdlSy/Pd9JIA6NMdmJKyxLiYPouPJyPecSJWKXJUd/9uw418NFtfEF5l0emMKMYCJh+xOGuGDuFFJV8KBWYGQjXckaTcdzCdysBwHbNRD+xc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=e+ZMbfQD; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="e+ZMbfQD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C10321F000E9; Tue, 14 Jul 2026 10:30:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784025003; bh=p8RLdnSKJCXFr+QjVEBumsnKkui+2iyJwpyxzgCjpUE=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=e+ZMbfQDQwpghnLVwQhusmQrAijKkwxcJuZ2HKB6chlBEQHRUB/8OlcbGPeGBSlYQ kwzCQud721cn9KY+zkZPFfpqzj8HkwpXaN6L20uSoDc55RtQpQDzn3eWJJpq+l/qR9 GAo3/44qsxXEWtZ2HhpyO6oT4sXunaKpvqfI/TZ6djYSf5kyXQQBILqXtVRkiNje0T oY0mXTRKxyvkoqZpMZfcjjkqFc7Cmv1cNFK5Uq+52AZT2hglaqjj+1lG3YM0Td3Neu GcwUWj7UO0e1KiUpAQdWSoIW62X32aWYl0rYruaZbqLmDcdnhEmHOWPQnJzVmqR3ew yrY8/ohKIRoqg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v14 3/8] dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support Reply-To: sashiko-reviews@lists.linux.dev To: "Lakshay Piplani" Cc: linux-i3c@lists.infradead.org, Frank.Li@kernel.org, "Alexandre Belloni" , robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260714092053.2461482-4-lakshay.piplani@nxp.com> References: <20260714092053.2461482-1-lakshay.piplani@nxp.com> <20260714092053.2461482-4-lakshay.piplani@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 14 Jul 2026 10:30:01 +0000 Message-Id: <20260714103002.C10321F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 3 potential issue(= s) to consider: - [Medium] The binding documents GPIO provider capabilities for the target = ports but omits the corresponding required standard properties (`gpio-contr= oller`, `#gpio-cells`) from the schema. - [Medium] The schema artificially restricts the compatible string to a sin= gle part number (`nxp,p3h2840`), failing to support the full hardware famil= y declared in the commit message. - [Low] The `maximum: 7` constraint is incorrectly applied directly to the = `reg` property for child nodes, rendering it ineffective. -- --- Patch [3]: [PATCH v14 3/8] dt-bindings: i3c: Add NXP P3H2x4x i3c-hub su= pport --- commit de643e91ed7cd5797dc3f49d8564e4fab44c0789 Author: Aman Kumar Pandey dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support Add bindings for the NXP P3H2x4x (P3H2440/P3H2441/P3H2840/P3H2841) multiport I3C hub family. These devices connect to a host via I3C/I2C/SMBus and allow communication with multiple downstream peripherals. > diff --git a/Documentation/devicetree/bindings/i3c/nxp,p3h2840.yaml b/Doc= umentation/devicetree/bindings/i3c/nxp,p3h2840.yaml > new file mode 100644 > index 0000000000000..f7f0752de5333 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i3c/nxp,p3h2840.yaml > @@ -0,0 +1,291 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright 2025 NXP > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/i3c/nxp,p3h2840.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP P3H2X4X I3C HUB > + > +maintainers: > + - Aman Kumar Pandey > + - Vikash Bansal > + - Lakshay Piplani > + > +description: | > + P3H2x4x (P3H2440/P3H2441/P3H2840/P3H2841) is a family of multiport I3C > + hub devices that connect to:- > + 1. A host CPU via I3C/I2C/SMBus bus on upstream side and connect to mu= ltiple > + peripheral devices on the downstream side. > + 2. Have two Controller Ports which can support either > + I2C/SMBus or I3C buses and connect to a CPU, BMC or SOC. > + 3. P3H2840/ P3H2841 are 8 port I3C hub with eight I3C/I2C Target Port. > + 4. P3H2440/ P3H2441 are 4 port I3C hub with four I3C/I2C Target Port. > + Target ports can be configured as I2C/SMBus, I3C or GPIO and connec= t to > + peripherals. [Severity: Medium] The description notes that target ports can be configured as GPIO providers, but the schema does not seem to include the corresponding required standard properties. Should gpio-controller and #gpio-cells be added to the schema to support this capability and avoid incomplete device trees passing valida= tion? > + > +properties: > + compatible: > + const: nxp,p3h2840 [Severity: Medium] The commit message indicates this binding supports the broader P3H2x4x fami= ly (P3H2440, P3H2441, P3H2840, P3H2841), but this strictly restricts the compatible string to a single part number. Should this be an enum allowing the other family members, or use an enum alongside a fallback? [ ... ] > +patternProperties: > + "^i3c@[0-7]$": > + type: object > + $ref: /schemas/i3c/i3c.yaml# > + unevaluatedProperties: false > + > + properties: > + reg: > + description: > + The I3C HUB Target Port number. > + maximum: 7 [Severity: Low] Is this maximum: 7 constraint effective here? The reg property structurally evaluates as an array, whereas the maximum keyword only applies to numeric scalar types in JSON schema validation. Does this limit need to be structur= ed differently (for example, applying it to items) to be evaluated? [ ... ] > + "^(i2c|smbus)@[0-7]$": > + type: object > + $ref: /schemas/i2c/i2c-controller.yaml# > + unevaluatedProperties: false > + > + properties: > + reg: > + description: > + The I3C HUB Target Port number. > + maximum: 7 [Severity: Low] Similarly for the i2c/smbus nodes, is applying maximum: 7 directly to the reg property array valid for JSON schema validation? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260714092053.2461= 482-1-lakshay.piplani@nxp.com?part=3D3 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 385EBC43458 for ; Tue, 14 Jul 2026 10:30:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4ZHPQLRBJke7Vok2ySdU5o4GqZmC3ErE2vsDFOBBxeU=; b=vpD9dwJvaX2nRm etPfxRcwkYIK7ctwTvuous2bNrgsgu9vT7l/rQlbF4I+Mb4fizIqx+bGk1E6g5Zv6it6NjIdWJ5v6 vvqy7KqHOfHRLbIL8I1neKfdkPqXG2jzie2kiKpjVR8gvcnCpulIiXg2ZZKM1guzV8PeO/DAfGmgW BPcuFEx2iSgpbGBSfRvHLE5wVUC0JUTTynD9SyGK58A6W33L/0boCWRwtEJ/RfcxCv3rEbzEHaEUl 7iIN3ZD9Wx3sgHfjdWaH7qUKXZeajYtLv6CHSq53hQOw+paoA1ZrqXAVSvuv1dan18se18y+4Gfyf eBZM0sWX0mqqr//FxNzw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjaOr-0000000BZuP-3UM6; Tue, 14 Jul 2026 10:30:05 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjaOp-0000000BZu3-3RFg for linux-i3c@lists.infradead.org; Tue, 14 Jul 2026 10:30:03 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 9069A42BAD; Tue, 14 Jul 2026 10:30:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C10321F000E9; Tue, 14 Jul 2026 10:30:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784025003; bh=p8RLdnSKJCXFr+QjVEBumsnKkui+2iyJwpyxzgCjpUE=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=e+ZMbfQDQwpghnLVwQhusmQrAijKkwxcJuZ2HKB6chlBEQHRUB/8OlcbGPeGBSlYQ kwzCQud721cn9KY+zkZPFfpqzj8HkwpXaN6L20uSoDc55RtQpQDzn3eWJJpq+l/qR9 GAo3/44qsxXEWtZ2HhpyO6oT4sXunaKpvqfI/TZ6djYSf5kyXQQBILqXtVRkiNje0T oY0mXTRKxyvkoqZpMZfcjjkqFc7Cmv1cNFK5Uq+52AZT2hglaqjj+1lG3YM0Td3Neu GcwUWj7UO0e1KiUpAQdWSoIW62X32aWYl0rYruaZbqLmDcdnhEmHOWPQnJzVmqR3ew yrY8/ohKIRoqg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v14 3/8] dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support To: "Lakshay Piplani" Cc: linux-i3c@lists.infradead.org, Frank.Li@kernel.org, "Alexandre Belloni" , robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260714092053.2461482-4-lakshay.piplani@nxp.com> References: <20260714092053.2461482-1-lakshay.piplani@nxp.com> <20260714092053.2461482-4-lakshay.piplani@nxp.com> Date: Tue, 14 Jul 2026 10:30:01 +0000 Message-Id: <20260714103002.C10321F000E9@smtp.kernel.org> X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MyBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gVGhlIGJpbmRpbmcg ZG9jdW1lbnRzIEdQSU8gcHJvdmlkZXIgY2FwYWJpbGl0aWVzIGZvciB0aGUgdGFyZ2V0IHBvcnRz IGJ1dCBvbWl0cyB0aGUgY29ycmVzcG9uZGluZyByZXF1aXJlZCBzdGFuZGFyZCBwcm9wZXJ0aWVz IChgZ3Bpby1jb250cm9sbGVyYCwgYCNncGlvLWNlbGxzYCkgZnJvbSB0aGUgc2NoZW1hLgotIFtN ZWRpdW1dIFRoZSBzY2hlbWEgYXJ0aWZpY2lhbGx5IHJlc3RyaWN0cyB0aGUgY29tcGF0aWJsZSBz dHJpbmcgdG8gYSBzaW5nbGUgcGFydCBudW1iZXIgKGBueHAscDNoMjg0MGApLCBmYWlsaW5nIHRv IHN1cHBvcnQgdGhlIGZ1bGwgaGFyZHdhcmUgZmFtaWx5IGRlY2xhcmVkIGluIHRoZSBjb21taXQg bWVzc2FnZS4KLSBbTG93XSBUaGUgYG1heGltdW06IDdgIGNvbnN0cmFpbnQgaXMgaW5jb3JyZWN0 bHkgYXBwbGllZCBkaXJlY3RseSB0byB0aGUgYHJlZ2AgcHJvcGVydHkgZm9yIGNoaWxkIG5vZGVz LCByZW5kZXJpbmcgaXQgaW5lZmZlY3RpdmUuCi0tCgotLS0gUGF0Y2ggWzNdOiBbUEFUQ0ggdjE0 IDMvOF0gZHQtYmluZGluZ3M6IGkzYzogQWRkIE5YUCBQM0gyeDR4IGkzYy1odWIgc3VwcG9ydCAt LS0KY29tbWl0IGRlNjQzZTkxZWQ3Y2Q1Nzk3ZGMzZjQ5ZDg1NjRlNGZhYjQ0YzA3ODkKQXV0aG9y OiBBbWFuIEt1bWFyIFBhbmRleSA8YW1hbi5rdW1hcnBhbmRleUBueHAuY29tPgoKZHQtYmluZGlu Z3M6IGkzYzogQWRkIE5YUCBQM0gyeDR4IGkzYy1odWIgc3VwcG9ydAoKQWRkIGJpbmRpbmdzIGZv ciB0aGUgTlhQIFAzSDJ4NHggKFAzSDI0NDAvUDNIMjQ0MS9QM0gyODQwL1AzSDI4NDEpCm11bHRp cG9ydCBJM0MgaHViIGZhbWlseS4gVGhlc2UgZGV2aWNlcyBjb25uZWN0IHRvIGEgaG9zdCB2aWEK STNDL0kyQy9TTUJ1cyBhbmQgYWxsb3cgY29tbXVuaWNhdGlvbiB3aXRoIG11bHRpcGxlIGRvd25z dHJlYW0KcGVyaXBoZXJhbHMuCgo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRy ZWUvYmluZGluZ3MvaTNjL254cCxwM2gyODQwLnlhbWwgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRy ZWUvYmluZGluZ3MvaTNjL254cCxwM2gyODQwLnlhbWwKPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+ IGluZGV4IDAwMDAwMDAwMDAwMDAuLmY3ZjA3NTJkZTUzMzMKPiAtLS0gL2Rldi9udWxsCj4gKysr IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2kzYy9ueHAscDNoMjg0MC55YW1s Cj4gQEAgLTAsMCArMSwyOTEgQEAKPiArIyBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogKEdQTC0y LjAtb25seSBPUiBCU0QtMi1DbGF1c2UpCj4gKyMgQ29weXJpZ2h0IDIwMjUgTlhQCj4gKyVZQU1M IDEuMgo+ICstLS0KPiArJGlkOiBodHRwOi8vZGV2aWNldHJlZS5vcmcvc2NoZW1hcy9pM2Mvbnhw LHAzaDI4NDAueWFtbCMKPiArJHNjaGVtYTogaHR0cDovL2RldmljZXRyZWUub3JnL21ldGEtc2No ZW1hcy9jb3JlLnlhbWwjCj4gKwo+ICt0aXRsZTogTlhQIFAzSDJYNFggSTNDIEhVQgo+ICsKPiAr bWFpbnRhaW5lcnM6Cj4gKyAgLSBBbWFuIEt1bWFyIFBhbmRleSA8YW1hbi5rdW1hcnBhbmRleUBu eHAuY29tPgo+ICsgIC0gVmlrYXNoIEJhbnNhbCA8dmlrYXNoLmJhbnNhbEBueHAuY29tPgo+ICsg IC0gTGFrc2hheSBQaXBsYW5pIDxsYWtzaGF5LnBpcGxhbmlAbnhwLmNvbT4KPiArCj4gK2Rlc2Ny aXB0aW9uOiB8Cj4gKyAgUDNIMng0eCAoUDNIMjQ0MC9QM0gyNDQxL1AzSDI4NDAvUDNIMjg0MSkg aXMgYSBmYW1pbHkgb2YgbXVsdGlwb3J0IEkzQwo+ICsgIGh1YiBkZXZpY2VzIHRoYXQgY29ubmVj dCB0bzotCj4gKyAgMS4gQSBob3N0IENQVSB2aWEgSTNDL0kyQy9TTUJ1cyBidXMgb24gdXBzdHJl YW0gc2lkZSBhbmQgY29ubmVjdCB0byBtdWx0aXBsZQo+ICsgICAgIHBlcmlwaGVyYWwgZGV2aWNl cyBvbiB0aGUgZG93bnN0cmVhbSAgc2lkZS4KPiArICAyLiBIYXZlIHR3byBDb250cm9sbGVyIFBv cnRzIHdoaWNoIGNhbiBzdXBwb3J0IGVpdGhlcgo+ICsgICAgIEkyQy9TTUJ1cyBvciBJM0MgYnVz ZXMgYW5kIGNvbm5lY3QgdG8gYSBDUFUsIEJNQyBvciBTT0MuCj4gKyAgMy4gUDNIMjg0MC8gUDNI Mjg0MSBhcmUgOCBwb3J0IEkzQyBodWIgd2l0aCBlaWdodCBJM0MvSTJDIFRhcmdldCBQb3J0Lgo+ ICsgIDQuIFAzSDI0NDAvIFAzSDI0NDEgYXJlIDQgcG9ydCBJM0MgaHViIHdpdGggZm91ciBJM0Mv STJDIFRhcmdldCBQb3J0Lgo+ICsgICAgIFRhcmdldCBwb3J0cyBjYW4gYmUgY29uZmlndXJlZCBh cyBJMkMvU01CdXMsIEkzQyBvciBHUElPIGFuZCBjb25uZWN0IHRvCj4gKyAgICAgcGVyaXBoZXJh bHMuCgpbU2V2ZXJpdHk6IE1lZGl1bV0KVGhlIGRlc2NyaXB0aW9uIG5vdGVzIHRoYXQgdGFyZ2V0 IHBvcnRzIGNhbiBiZSBjb25maWd1cmVkIGFzIEdQSU8gcHJvdmlkZXJzLApidXQgdGhlIHNjaGVt YSBkb2VzIG5vdCBzZWVtIHRvIGluY2x1ZGUgdGhlIGNvcnJlc3BvbmRpbmcgcmVxdWlyZWQgc3Rh bmRhcmQKcHJvcGVydGllcy4gU2hvdWxkIGdwaW8tY29udHJvbGxlciBhbmQgI2dwaW8tY2VsbHMg YmUgYWRkZWQgdG8gdGhlIHNjaGVtYQp0byBzdXBwb3J0IHRoaXMgY2FwYWJpbGl0eSBhbmQgYXZv aWQgaW5jb21wbGV0ZSBkZXZpY2UgdHJlZXMgcGFzc2luZyB2YWxpZGF0aW9uPwoKPiArCj4gK3By b3BlcnRpZXM6Cj4gKyAgY29tcGF0aWJsZToKPiArICAgIGNvbnN0OiBueHAscDNoMjg0MAoKW1Nl dmVyaXR5OiBNZWRpdW1dClRoZSBjb21taXQgbWVzc2FnZSBpbmRpY2F0ZXMgdGhpcyBiaW5kaW5n IHN1cHBvcnRzIHRoZSBicm9hZGVyIFAzSDJ4NHggZmFtaWx5CihQM0gyNDQwLCBQM0gyNDQxLCBQ M0gyODQwLCBQM0gyODQxKSwgYnV0IHRoaXMgc3RyaWN0bHkgcmVzdHJpY3RzIHRoZQpjb21wYXRp YmxlIHN0cmluZyB0byBhIHNpbmdsZSBwYXJ0IG51bWJlci4gU2hvdWxkIHRoaXMgYmUgYW4gZW51 bSBhbGxvd2luZwp0aGUgb3RoZXIgZmFtaWx5IG1lbWJlcnMsIG9yIHVzZSBhbiBlbnVtIGFsb25n c2lkZSBhIGZhbGxiYWNrPwoKWyAuLi4gXQo+ICtwYXR0ZXJuUHJvcGVydGllczoKPiArICAiXmkz Y0BbMC03XSQiOgo+ICsgICAgdHlwZTogb2JqZWN0Cj4gKyAgICAkcmVmOiAvc2NoZW1hcy9pM2Mv aTNjLnlhbWwjCj4gKyAgICB1bmV2YWx1YXRlZFByb3BlcnRpZXM6IGZhbHNlCj4gKwo+ICsgICAg cHJvcGVydGllczoKPiArICAgICAgcmVnOgo+ICsgICAgICAgIGRlc2NyaXB0aW9uOgo+ICsgICAg ICAgICAgVGhlIEkzQyBIVUIgVGFyZ2V0IFBvcnQgbnVtYmVyLgo+ICsgICAgICAgIG1heGltdW06 IDcKCltTZXZlcml0eTogTG93XQpJcyB0aGlzIG1heGltdW06IDcgY29uc3RyYWludCBlZmZlY3Rp dmUgaGVyZT8gVGhlIHJlZyBwcm9wZXJ0eSBzdHJ1Y3R1cmFsbHkKZXZhbHVhdGVzIGFzIGFuIGFy cmF5LCB3aGVyZWFzIHRoZSBtYXhpbXVtIGtleXdvcmQgb25seSBhcHBsaWVzIHRvIG51bWVyaWMK c2NhbGFyIHR5cGVzIGluIEpTT04gc2NoZW1hIHZhbGlkYXRpb24uIERvZXMgdGhpcyBsaW1pdCBu ZWVkIHRvIGJlIHN0cnVjdHVyZWQKZGlmZmVyZW50bHkgKGZvciBleGFtcGxlLCBhcHBseWluZyBp dCB0byBpdGVtcykgdG8gYmUgZXZhbHVhdGVkPwoKWyAuLi4gXQo+ICsgICJeKGkyY3xzbWJ1cylA WzAtN10kIjoKPiArICAgIHR5cGU6IG9iamVjdAo+ICsgICAgJHJlZjogL3NjaGVtYXMvaTJjL2ky Yy1jb250cm9sbGVyLnlhbWwjCj4gKyAgICB1bmV2YWx1YXRlZFByb3BlcnRpZXM6IGZhbHNlCj4g Kwo+ICsgICAgcHJvcGVydGllczoKPiArICAgICAgcmVnOgo+ICsgICAgICAgIGRlc2NyaXB0aW9u Ogo+ICsgICAgICAgICAgVGhlIEkzQyBIVUIgVGFyZ2V0IFBvcnQgbnVtYmVyLgo+ICsgICAgICAg IG1heGltdW06IDcKCltTZXZlcml0eTogTG93XQpTaW1pbGFybHkgZm9yIHRoZSBpMmMvc21idXMg bm9kZXMsIGlzIGFwcGx5aW5nIG1heGltdW06IDcgZGlyZWN0bHkgdG8gdGhlCnJlZyBwcm9wZXJ0 eSBhcnJheSB2YWxpZCBmb3IgSlNPTiBzY2hlbWEgdmFsaWRhdGlvbj8KCi0tIApTYXNoaWtvIEFJ IHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA3MTQwOTIwNTMu MjQ2MTQ4Mi0xLWxha3NoYXkucGlwbGFuaUBueHAuY29tP3BhcnQ9MwoKLS0gCmxpbnV4LWkzYyBt YWlsaW5nIGxpc3QKbGludXgtaTNjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1pM2MK