Re: [PATCH v12 1/4] HID: hid-msi: Add MSI Claw configuration driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Inconsistent use of `pm_ptr()` for Power Management callbacks.
--

--- Patch [1]: [PATCH v12 1/4] HID: hid-msi: Add MSI Claw configuration driver ---
commit 7e5a7560f52892f9ee5835a5c33181e068f459aa
Author: Derek J. Clark <derekjohn.clark@gmail.com>

HID: hid-msi: Add MSI Claw configuration driver

Adds configuration HID driver for the MSI Claw series of handheld PC's.
In this initial patch add the initial driver outline and attributes for
changing the gamepad mode, M-key behavior, and add a WO reset function.

> diff --git a/drivers/hid/hid-msi.c b/drivers/hid/hid-msi.c
> --- /dev/null
> +++ b/drivers/hid/hid-msi.c

[ ... ]

> +static struct hid_driver msi_driver = {
> +	.name		= "hid-msi",
> +	.id_table	= msi_devices,
> +	.raw_event	= msi_raw_event,
> +	.probe		= msi_probe,
> +	.remove		= msi_remove,
> +	.resume		= msi_resume,

[Severity: Low]
Should msi_resume be wrapped in pm_ptr() here?

The struct assignment for .suspend uses pm_ptr(msi_suspend), but .resume
is assigned msi_resume unconditionally. Missing pm_ptr() on .resume
prevents dead-code elimination on msi_resume and its dependencies when
CONFIG_PM is disabled.

> +	.suspend	= pm_ptr(msi_suspend),
> +};
> +module_hid_driver(msi_driver);
> +
> +MODULE_LICENSE("GPL");

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260714102640.18075-1-derekjohn.clark@gmail.com?part=1