From: sashiko-bot@kernel.org
To: "Rodrigo Alencar" <rodrigo.alencar@analog.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v8 01/17] iio: ABI: add attributes for altcurrent channels
Date: Tue, 14 Jul 2026 11:14:09 +0000 [thread overview]
Message-ID: <20260714111409.F07811F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260714-ad9910-iio-driver-v8-1-36939c3c07d2@analog.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] `out_altcurrentY_raw` is incorrectly documented as an input measurement instead of an output setting.
--
--- Patch [1]: [PATCH v8 01/17] iio: ABI: add attributes for altcurrent channels ---
commit f95abfd3ec5c3cd46b3d0c4a84b154158053f62c
Author: Rodrigo Alencar <rodrigo.alencar@analog.com>
iio: ABI: add attributes for altcurrent channels
Add attributes applicable to altcurrent channels, e.g., frequency, phase,
scale, raw, label and powerdown. Those are going to be used by a DDS
device to be introduced shortly.
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> index 5cc2e82c4997e..90047189c3ebe 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
[ ... ]
> @@ -1736,6 +1743,8 @@ Description:
>
> What: /sys/bus/iio/devices/iio:deviceX/in_currentY_raw
> What: /sys/bus/iio/devices/iio:deviceX/in_currentY_supply_raw
> +What: /sys/bus/iio/devices/iio:deviceX/in_altcurrentY_raw
> +What: /sys/bus/iio/devices/iio:deviceX/out_altcurrentY_raw
[Severity: Low]
Is out_altcurrentY_raw grouped under the wrong description here?
Since it is an output attribute, having it fall under the "Raw current
measurement from channel Y." description below seems inconsistent. Should this
be separated into its own section or grouped with an output setting?
> KernelVersion: 3.17
> Contact: linux-iio@vger.kernel.org
> Description:
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260714-ad9910-iio-driver-v8-0-36939c3c07d2@analog.com?part=1
next prev parent reply other threads:[~2026-07-14 11:14 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 11:02 [PATCH v8 00/17] AD9910 Direct Digital Synthesizer Rodrigo Alencar
2026-07-14 11:02 ` Rodrigo Alencar via B4 Relay
2026-07-14 11:02 ` [PATCH v8 01/17] iio: ABI: add attributes for altcurrent channels Rodrigo Alencar
2026-07-14 11:02 ` Rodrigo Alencar via B4 Relay
2026-07-14 11:14 ` sashiko-bot [this message]
2026-07-14 11:02 ` [PATCH v8 02/17] iio: ABI: raw, scale and offset for frequency/phase channels Rodrigo Alencar
2026-07-14 11:02 ` Rodrigo Alencar via B4 Relay
2026-07-14 11:25 ` sashiko-bot
2026-07-14 11:02 ` [PATCH v8 03/17] iio: ABI: add parent entry for iio channels Rodrigo Alencar
2026-07-14 11:02 ` Rodrigo Alencar via B4 Relay
2026-07-14 11:02 ` [PATCH v8 04/17] iio: add IIO_FREQUENCY channel type Rodrigo Alencar
2026-07-14 11:02 ` Rodrigo Alencar via B4 Relay
2026-07-14 11:02 ` [PATCH v8 05/17] iio: core: support 64-bit register through debugfs Rodrigo Alencar
2026-07-14 11:02 ` Rodrigo Alencar via B4 Relay
2026-07-14 11:02 ` [PATCH v8 06/17] iio: core: create local __iio_chan_prefix_emit() for reuse Rodrigo Alencar
2026-07-14 11:02 ` Rodrigo Alencar via B4 Relay
2026-07-14 11:46 ` Andy Shevchenko
2026-07-14 11:02 ` [PATCH v8 07/17] iio: test: add kunit tests for channel prefix naming generation Rodrigo Alencar
2026-07-14 11:02 ` Rodrigo Alencar via B4 Relay
2026-07-14 12:12 ` sashiko-bot
2026-07-14 11:02 ` [PATCH v8 08/17] iio: core: add hierarchical channel relationships Rodrigo Alencar
2026-07-14 11:02 ` Rodrigo Alencar via B4 Relay
2026-07-14 11:02 ` [PATCH v8 09/17] dt-bindings: iio: frequency: add ad9910 Rodrigo Alencar
2026-07-14 11:02 ` Rodrigo Alencar via B4 Relay
2026-07-14 11:02 ` [PATCH v8 10/17] iio: frequency: ad9910: initial driver implementation Rodrigo Alencar
2026-07-14 11:02 ` Rodrigo Alencar via B4 Relay
2026-07-14 12:29 ` sashiko-bot
2026-07-14 11:02 ` [PATCH v8 11/17] iio: frequency: ad9910: add basic parallel port support Rodrigo Alencar
2026-07-14 11:02 ` Rodrigo Alencar via B4 Relay
2026-07-14 11:02 ` [PATCH v8 12/17] iio: frequency: ad9910: add digital ramp generator support Rodrigo Alencar
2026-07-14 11:02 ` Rodrigo Alencar via B4 Relay
2026-07-14 11:02 ` [PATCH v8 13/17] iio: frequency: ad9910: add RAM mode support Rodrigo Alencar
2026-07-14 11:02 ` Rodrigo Alencar via B4 Relay
2026-07-14 13:17 ` sashiko-bot
2026-07-14 11:02 ` [PATCH v8 14/17] iio: frequency: ad9910: add output shift keying support Rodrigo Alencar
2026-07-14 11:02 ` Rodrigo Alencar via B4 Relay
2026-07-14 11:02 ` [PATCH v8 15/17] iio: frequency: ad9910: show channel priority in debugfs Rodrigo Alencar
2026-07-14 11:02 ` Rodrigo Alencar via B4 Relay
2026-07-14 11:02 ` [PATCH v8 16/17] iio: ABI: add docs for ad9910 sysfs and debugfs entries Rodrigo Alencar
2026-07-14 11:02 ` Rodrigo Alencar via B4 Relay
2026-07-14 11:02 ` [PATCH v8 17/17] docs: iio: add documentation for ad9910 driver Rodrigo Alencar
2026-07-14 11:02 ` Rodrigo Alencar via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260714111409.F07811F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rodrigo.alencar@analog.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.