From: linuxtestproject.agent@gmail.com
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] syscall02: test invalid syscall number -1
Date: Tue, 14 Jul 2026 12:18:27 +0000 [thread overview]
Message-ID: <20260714121827.3999-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260714-syscall_invalid_nr-v2-1-b94a8f60f112@suse.com>
Hi Andrea,
On Tue, 14 Jul 2026 12:56:04 +0200, Andrea Cervesato wrote:
> syscall02: test invalid syscall number -1
> Add a test verifying that a raw syscall() with the reserved number -1
> fails with ENOSYS.
The subject and the doc comment inside the test both say "invalid syscall
number -1", but the commit body says "reserved number -1". These terms
carry different meanings. "Reserved" implies deliberate kernel allocation
for a specific purpose, while "invalid" is the user-facing description
for an out-of-range syscall number. Could "reserved" be changed to
"invalid" here to match the subject and the test description block?
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-07-14 12:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 10:56 [LTP] [PATCH v2] syscall02: test invalid syscall number -1 Andrea Cervesato
2026-07-14 12:18 ` linuxtestproject.agent [this message]
2026-07-14 12:48 ` Cyril Hrubis
-- strict thread matches above, loose matches on Subject: below --
2026-07-14 9:25 [LTP] [PATCH] " Andrea Cervesato
2026-07-14 10:50 ` [LTP] " linuxtestproject.agent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260714121827.3999-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.