Re: [PATCH 1/2] dt-bindings: remoteproc: qcom,milos-pas: Add Eliza CDSP compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Legacy compatible strings silently allow 3 `memory-region` items because they lack an explicit `maxItems: 2` constraint.
--

--- Patch [1]: [PATCH 1/2] dt-bindings: remoteproc: qcom,milos-pas: Add Eliza CDSP compatible ---
commit 035d1273c9ae4354ae4a87c41fd4d9ad57c5bddc
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

dt-bindings: remoteproc: qcom,milos-pas: Add Eliza CDSP compatible

This commit documents the compatible string for the CDSP Peripheral
Authentication Service on the Eliza SoC. It reworks the schema to accommodate
a third memory region (DSM) and the NSP power domain.

> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml
> index 99d7337e58ec5..3ee7be3304c6f 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml

[ ... ]

> @@ -97,7 +99,26 @@ allOf:
>            minItems: 2
>          firmware-name:
>            minItems: 2
> -    else:
> +

[Severity: Medium]
Since adding the third item to the memory-region properties implicitly
raises the maximum limit to 3 globally, should maxItems: 2 be explicitly
specified here for qcom,eliza-adsp-pas and the other legacy devices?

Without an explicit constraint, won't dt_binding_check silently allow
misconfigured device trees for these older devices to incorrectly specify
3 memory regions?

> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - qcom,eliza-cdsp-pas

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260714-remoteproc-eliza-cdsp-v1-0-32eb7a1f2c59@oss.qualcomm.com?part=1