Re: [PATCH v4 17/56] scsi: qla2xxx: Enable init_firmware mailbox for 29xx

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] SFP validation debug logging for QLA29XX is missing in qla2x00_get_firmware_state().
--

--- Patch [17]: [PATCH v4 17/56] scsi: qla2xxx: Enable init_firmware mailbox for 29xx ---
commit 46f14f9f25f252d1cca6f3d9503e629aa6ac9d97
Author: Nilesh Javali <njavali@marvell.com>

scsi: qla2xxx: Enable init_firmware mailbox for 29xx

The init_firmware mailbox command needs 29xx adapter support for reading
back SFP information via mb3 and for validating SFP status on successful
firmware initialization. Add IS_QLA29XX() checks alongside the existing
27xx/28xx checks.

> diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
> index 3fc08120fdf11..9c78aa66e12b3 100644
> --- a/drivers/scsi/qla2xxx/qla_mbx.c
> +++ b/drivers/scsi/qla2xxx/qla_mbx.c
> @@ -1968,7 +1968,7 @@ qla2x00_init_firmware(scsi_qla_host_t *vha, uint16_t size)
>  
>  	/* 1 and 2 should normally be captured. */
>  	mcp->in_mb = MBX_2|MBX_1|MBX_0;
> -	if (IS_QLA83XX(ha) || IS_QLA27XX(ha) || IS_QLA28XX(ha))
> +	if (IS_QLA83XX(ha) || IS_QLA27XX(ha) || IS_QLA28XX(ha) || IS_QLA29XX(ha))
>  		/* mb3 is additional info about the installed SFP. */
>  		mcp->in_mb  |= MBX_3;
>  	mcp->buf_size = size;
> @@ -1992,7 +1992,7 @@ qla2x00_init_firmware(scsi_qla_host_t *vha, uint16_t size)
>  			    0x0104d, ha->ex_init_cb, sizeof(*ha->ex_init_cb));
>  		}
>  	} else {
> -		if (IS_QLA27XX(ha) || IS_QLA28XX(ha)) {
> +		if (IS_QLA27XX(ha) || IS_QLA28XX(ha) || IS_QLA29XX(ha)) {
>  			if (mcp->mb[2] == 6 || mcp->mb[3] == 2)
>  				ql_dbg(ql_dbg_mbx, vha, 0x119d,
>  				    "Invalid SFP/Validation Failed\n");

[Severity: Low]
Does this code also need to update qla2x00_get_firmware_state()?

In qla2x00_get_firmware_state(), there is a similar block that logs a
warning for an invalid SFP, but it currently only checks for 27XX and 28XX:

drivers/scsi/qla2xxx/qla_mbx.c:qla2x00_get_firmware_state() {
...
	} else {
		if (IS_QLA27XX(ha) || IS_QLA28XX(ha)) {
			if (mcp->mb[2] == 6 || mcp->mb[3] == 2)
				ql_dbg(ql_dbg_mbx, vha, 0x119e,
				    "Invalid SFP/Validation Failed\n");
		}
...
}

Will retrieving the firmware state on a QLA29XX adapter with an invalid SFP
fail to produce the expected debug log?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260714095353.289460-1-njavali@marvell.com?part=17