Re: [PATCH net-next 1/2] dt-bindings: net: add DAPU Telecom DAP8211R(I) PHY binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Medium] The example's `compatible` string does not match the schema's required `compatible` string, causing the example to silently bypass this schema's validation.
- [Medium] The example uses an invalid value for `tx-internal-delay-ps` that violates the strict enum constraints.
- [Medium] The vendor-specific property `tx-inverted-clk` lacks the required vendor prefix.
--

--- Patch [1]: [PATCH net-next 1/2] dt-bindings: net: add DAPU Telecom DAP8211R(I) PHY binding ---
commit acf143bd06413ea91d469e7f087d2e96207a1bec
Author: Artem Shimko <a.shimko.dev@gmail.com>

dt-bindings: net: add DAPU Telecom DAP8211R(I) PHY binding

Add device tree binding documentation for the DAPU Telecom DAP8211R(I)
Gigabit Ethernet PHY.

> diff --git a/Documentation/devicetree/bindings/net/dapu,dap8211r.yaml b/Documentation/devicetree/bindings/net/dapu,dap8211r.yaml
> new file mode 100644
> index 0000000000000..208a82f779d61
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/dapu,dap8211r.yaml

[ ... ]

> +  tx-internal-delay-ps:
> +    description:
> +      RGMII TX clock delay in picoseconds. The PHY supports 150 ps steps
> +      from 0 to 2250 ps. If not specified, defaults to 1950 ps. If the
> +      requested value does not exactly match a supported step, the driver
> +      selects the nearest supported value and issues a warning.
> +    enum: [0, 150, 300, 450, 600, 750, 900, 1050, 1200, 1350, 1500,
> +           1650, 1800, 1950, 2100, 2250]
> +    default: 1950
> +
> +  tx-inverted-clk:

[Severity: Medium]
Since this property is a vendor-specific extension, should it include a
vendor prefix like dapu,tx-inverted-clk? Introducing custom properties
without a prefix risks colliding with future standard properties.

> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      If present, the RGMII TX clock to the MAC is inverted (180 degree
> +      phase shift relative to the data lines). This is a vendor-specific

[ ... ]

> +examples:
> +  - |
> +    mdio {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        ethernet-phy@1 {
> +            compatible = "ethernet-phy-ieee802.3-c22";

[Severity: Medium]
Will this compatible string cause the example to bypass validation for this
schema? The schema requires the compatible string to be exactly
"ethernet-phy-id0008.011b". If the example is not evaluated against this
file's schema, it can hide other validation failures.

> +            reg = <1>;
> +            rx-internal-delay-ps = <1050>;
> +            tx-internal-delay-ps = <1150>;

[Severity: Medium]
Will this value trigger a validation error when the compatible string
mismatch is fixed? The tx-internal-delay-ps property enforces an enum with
strict 150 ps steps, and 1150 is not in the list of allowed values.

> +            tx-inverted-clk;
> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713131223.279555-1-a.shimko.dev@gmail.com?part=1