From: Christoph Hellwig <hch@lst.de>
To: Pankaj Raghav <p.raghav@samsung.com>
Cc: aalbersh@kernel.org, pankaj.raghav@linux.dev, djwong@kernel.org,
Zhang Yi <yi.zhang@huaweicloud.com>,
gost.dev@samsung.com, hch@lst.de, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] fiemap: add a nosync option
Date: Tue, 14 Jul 2026 15:17:53 +0200 [thread overview]
Message-ID: <20260714131753.GA31615@lst.de> (raw)
In-Reply-To: <20260714105314.413402-1-p.raghav@samsung.com>
On Tue, Jul 14, 2026 at 12:53:14PM +0200, Pankaj Raghav wrote:
> diff --git a/io/fiemap.c b/io/fiemap.c
> index b41f71bf..7aa8868d 100644
> --- a/io/fiemap.c
> +++ b/io/fiemap.c
> @@ -36,6 +36,7 @@ fiemap_help(void)
> " -a -- prints the attribute fork map instead of the data fork.\n"
> " -l -- also displays the length of each extent in 512-byte blocks.\n"
> " -n -- query n extents.\n"
> +" -s -- do not use FIEMAP_FLAG_SYNC.\n"
The xfs_io manpage refers to the xfs_bmap man page for the argument,
and xfs_bmap already supports a -e option to skip the sync. Maybe we
should match that for consistency?
Otherwise this looks good.
prev parent reply other threads:[~2026-07-14 13:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 10:53 [PATCH] fiemap: add a nosync option Pankaj Raghav
2026-07-14 13:17 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260714131753.GA31615@lst.de \
--to=hch@lst.de \
--cc=aalbersh@kernel.org \
--cc=djwong@kernel.org \
--cc=gost.dev@samsung.com \
--cc=linux-xfs@vger.kernel.org \
--cc=p.raghav@samsung.com \
--cc=pankaj.raghav@linux.dev \
--cc=yi.zhang@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.