All of lore.kernel.org
 help / color / mirror / Atom feed
From: Puranjay Mohan <puranjay@kernel.org>
To: rohit.kuma1313@gmail.com
Cc: jasowangio@gmail.com, qemu-devel@nongnu.org, roohiit@amazon.de,
	Puranjay Mohan <puranjay@kernel.org>
Subject: Re: [PATCH] net: only advertise passt in netdev help when CONFIG_PASST
Date: Tue, 14 Jul 2026 06:34:03 -0700	[thread overview]
Message-ID: <20260714133403.3038095-1-puranjay@kernel.org> (raw)
In-Reply-To: <20260713194511.1058450-1-rohit.kuma1313@gmail.com>

On Mon, Jul 13, 2026 at 07:45:11PM +0000, Rohitashv Kumar wrote:
> From: Rohitashv Kumar <roohiit@amazon.de>
>
> show_netdevs() lists each conditionally-compiled netdev backend behind
> its CONFIG_* guard (CONFIG_SLIRP for "user", CONFIG_L2TPV3 for
> "l2tpv3", CONFIG_NET_BRIDGE for "bridge", ...). The "passt" entry was
> added unconditionally, so "-netdev help" advertises passt even in
> builds configured with --disable-passt. Trying to use it then fails
> with "Parameter 'type' does not accept value 'passt'", since the QAPI
> NetClientDriver enum member "passt" is gated by 'if': 'CONFIG_PASST'.
>
> Guard the help entry with CONFIG_PASST so the advertised backends match
> those actually compiled into the binary.
>
> Signed-off-by: Rohitashv Kumar <roohiit@amazon.de>

Reviewed-by: Puranjay Mohan <puranjay@kernel.org>

Thanks,
Puranjay


      parent reply	other threads:[~2026-07-14 14:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-13 19:45 [PATCH] net: only advertise passt in netdev help when CONFIG_PASST Rohitashv Kumar
2026-07-14  9:17 ` Philippe Mathieu-Daudé
2026-07-14 13:34 ` Puranjay Mohan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260714133403.3038095-1-puranjay@kernel.org \
    --to=puranjay@kernel.org \
    --cc=jasowangio@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rohit.kuma1313@gmail.com \
    --cc=roohiit@amazon.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.