From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB8CE37A82E for ; Tue, 14 Jul 2026 19:54:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784058859; cv=none; b=BPz8y2TeCGPTT7SvNwxYRiEKdq/jGL3iwvKLZegFiFYSx5SshKQhAwv7NQj56R6vsSKChPsFSO9kM/9aU0FO7NZhuhRQMVNOKF4qovQ+yqx6eDTvD/TjFGi1k82a8kzq5EHKO8jxjMRTIeoyxqkbCEb4Sy/hTVFMIw2IoDr7B68= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784058859; c=relaxed/simple; bh=z4TNfT40WeIapgYpi1vgsGm1RQHey1SzmtxNvKdKDVs=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=OrTdOmNI2CefBOuTJOJwOuJhvLpH+XDC/cNmU6ymtToe3akT1KqtEQFUPuWOCWO527HIgdazr0JlpWFcJy1o8648YDxHghvpHsn+xR4/SQG2pJOZQn/ThVF7AE7eRVRm2Bu6hvpLpMI1MbeF8ES3l9jRgIbEcICBXOrHXFetZmA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oxiLstHe; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oxiLstHe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C8C91F000E9; Tue, 14 Jul 2026 19:54:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784058857; bh=GKwk8o438WlpFTg0T9EkOBKX6Io2q4+YhJxzyFYieTI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=oxiLstHe0cfckh7Wn3vAo7vz3m0+4VYY3cTHNwuBkWZYbNb3TsjRhvbHNWpS2qOUW KOh0D/rQPwPBRr3Qu605NMu9Z5Grrvl9wES1+3wR/JXTs12WUCN3N10Py8KdxniBaE KEZyRESctGChYBmtlNWNPHV56td+xAa/SR51URjJTjGkMyUB5a/3pmK1MNHIbG5v2M Gn7dNw/jUd1ARtThZNvuyvMD0MDqAQlopMVMvIBRDrjVQLwApE6vUU1X3iQMdqZrpF kWNgtv+DaS9GFU/j6z+jPagZ4AXYzuBgrg7Jnm+AI3JEuxrsszYbnMBDaAAxkLE5ps srWcC9+lt2Wmw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v13 02/35] phy: rockchip: usbdp: Update mode_change after error handling Reply-To: sashiko-reviews@lists.linux.dev To: "Sebastian Reichel" Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com, linux-phy@lists.infradead.org In-Reply-To: <20260714-rockchip-usbdp-cleanup-v13-2-6cb3e769d4c5@collabora.com> References: <20260714-rockchip-usbdp-cleanup-v13-0-6cb3e769d4c5@collabora.com> <20260714-rockchip-usbdp-cleanup-v13-2-6cb3e769d4c5@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 14 Jul 2026 19:54:16 +0000 Message-Id: <20260714195417.0C8C91F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 7 potential issue(= s) to consider: Pre-existing issues: - [High] State tracking corruption in `rk_udphy_power_on` drops active cons= umer modes. - [High] USB3 port remains disabled in system controller when switching fro= m DP-only to DP+USB mode. - [High] Dynamically disabling PHY clocks without USB controller coordinati= on causes SErrors. - [High] Type-C disconnects (TYPEC_STATE_SAFE) or USB-only transitions are = ignored, stranding PHY state. - [High] Missing mutex protection in `rk_udphy_dp_phy_configure` allows con= current access to shared PHY state. - [Medium] Probe error paths and driver unbind leak clock references. - [Medium] U3 port remains enabled in system controller when initializing i= nto DP-only mode. -- --- Patch [2]: [PATCH v13 02/35] phy: rockchip: usbdp: Update mode_change a= fter error handling --- commit 5e684d6b433ae738bd5f378d7294d9e76a2199d9 Author: Sebastian Reichel phy: rockchip: usbdp: Update mode_change after error handling This commit delays resetting the mode_change flag in rk_udphy_power_on() until after all potential errors are handled. This ensures that if rk_udphy_setup() fails, the reinitialization attempt won't be silently skipped on subsequent tries. Closes: https://lore.kernel.org/linux-phy/20260612163835.8D5471F000E9@smtp.= kernel.org/ > diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rock= chip/phy-rockchip-usbdp.c > --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c > +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c > @@ -1000,15 +1000,14 @@ static int rk_udphy_power_on(struct rk_udphy *udp= hy, u8 mode) [ ... ] > if (udphy->status =3D=3D UDPHY_MODE_NONE) { > - udphy->mode_change =3D false; > ret =3D rk_udphy_setup(udphy); > if (ret) > return ret; > =20 > if (udphy->mode & UDPHY_MODE_USB) > rk_udphy_u3_port_disable(udphy, false); > - } else if (udphy->mode_change) { > udphy->mode_change =3D false; > + } else if (udphy->mode_change) { [Severity: Medium] This is a pre-existing issue, but does this block leave the U3 port enabled when initializing into DP-only mode? If the PHY is completely powered off and the Type-C mux selects DP-only mod= e, the DP consumer calls rk_udphy_power_on(). While this block handles initialization, it lacks the logic to call rk_udphy_u3_port_disable(udphy, true). If the USB consumer is not bound or initialized yet, does the GRF register for the U3 port retain its previous state, potentially causing unexpected behavior or minor power drain? > udphy->status =3D UDPHY_MODE_NONE; [Severity: High] This is a pre-existing issue, but does this aggressively clear the state and drop active consumer modes? If both DP and USB consumers are active, and a Type-C event triggers a mode change, the first consumer to call rk_udphy_power_on() executes this block. By forcefully overwriting udphy->status =3D UDPHY_MODE_NONE before re-initializing, and only appending the caller's mode at the end (udphy->status |=3D mode), isn't the other active consumer's state flag permanently lost? If that first consumer later calls rk_udphy_power_off(), wouldn't the status evaluate to 0 and completely disable the PHY, crashing the other consumer which is still running? > if (udphy->mode =3D=3D UDPHY_MODE_DP) > rk_udphy_u3_port_disable(udphy, true); [ ... ] > rk_udphy_disable(udphy); [Severity: High] This isn't a bug introduced by this patch, but can dynamically disabling PHY clocks without coordinating with the USB controller cause SErrors? When a Type-C mode change occurs while the USB controller (DWC3) is active, this block calls rk_udphy_disable(), which immediately cuts the PHY clocks. Because there is no coordination (like phy_notify_reset) to quiesce DWC3 or reroute its clock via rk_udphy_u3_port_disable(udphy, true) before the disable call, will any active DWC3 register access instantly cause an SError kernel panic? > ret =3D rk_udphy_setup(udphy); > if (ret) > return ret; > + udphy->mode_change =3D false; > } [Severity: High] This is a pre-existing issue, but does this branch leave the USB 3.0 port disabled? When the Type-C port switches from DP-only to DP+USB mode, the USB3 port was previously disabled via GRF registers. This branch resets the PHY and clears mode_change, but it never explicitly calls rk_udphy_u3_port_disable(udphy, false) to re-enable it. Since the USB consumer's initialization relies on rk_udphy_power_on() to handle this, will any dynamic transition from DP-only to DP+USB via cable flip or replug leave the USB3 port broken? [Severity: High] This isn't a bug introduced by this patch, but are Type-C disconnects being ignored in rk_udphy_typec_mux_set()? Looking at rk_udphy_typec_mux_set(), the mode update is improperly gated behind an alt-mode check: drivers/phy/rockchip/phy-rockchip-usbdp.c:rk_udphy_typec_mux_set() { ... if (state->alt && state->alt->svid =3D=3D USB_TYPEC_DP_SID) { struct typec_displayport_data *data =3D state->data; if (!data) { ... } On Type-C cable unplug or a transition to USB-only mode, state->mode is TYPEC_STATE_SAFE or TYPEC_STATE_USB, so state->alt is NULL. Since the mode update logic is strictly guarded by the SVID check, it gets completely bypassed. Does this leave udphy->mode indefinitely retaining the old DP state, breaki= ng subsequent USB connections and preventing proper PHY power down? [Severity: High] This is a pre-existing issue, but is there missing mutex protection in rk_udphy_dp_phy_configure()? This function accesses and mutates shared state without acquiring udphy->mutex: drivers/phy/rockchip/phy-rockchip-usbdp.c:rk_udphy_dp_phy_configure() { ... if (dp->set_rate) { udphy->link_rate =3D dp->link_rate; ... } Since rk_udphy_dp_phy_configure() is invoked by the DP subsystem during link training, it reads shared state like udphy->lane_mux_sel and modifies udphy->bw and udphy->link_rate. Meanwhile, an asynchronous Type-C event running rk_udphy_typec_mux_set() modifies these exact arrays while holding the mutex. Can this race condition lead to reading torn lane mappings and programming incorrect hardware registers? [Severity: Medium] This isn't a bug introduced by this patch, but do the probe error paths and driver unbind leak clock references? In rk_udphy_probe(), clocks can be enabled if the bootloader left the PHY active: drivers/phy/rockchip/phy-rockchip-usbdp.c:rk_udphy_probe() { ... ret =3D rk_udphy_get_initial_status(udphy); if (ret) return ret; mutex_init(&udphy->mutex); platform_set_drvdata(pdev, udphy); ... } If a subsequent step in the probe fails (such as devm_phy_create), or if the driver is unbound, there appears to be no corresponding clk_bulk_disable_unprepare() execution or .remove callback to release these clocks. Does this cause a clock reference count leak? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260714-rockchip-u= sbdp-cleanup-v13-0-6cb3e769d4c5@collabora.com?part=3D2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12F87C44507 for ; Tue, 14 Jul 2026 19:54:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bxAIE9j5Num88ZvOhr15WZir8h/hURJCbJ+ZXGbOsxQ=; b=BoeD09nEv3btIM 8qXOxbx8hfX+Ux+iWMhCy7qvL7UeXyPcx+nnLE+P9018jtsNHSbNlVAHRPlSZBNMgElgPDv6M2aeW 1jTGM7fnf1L6F3+/+Q+hrID6MooMHGiu28qR2G3WxCT3wyqTTTW62DfpJLHQAttCbO8G6Y4rWrHge nqgIIGCRrzQbkDRj12THCGejQ0qVAtoX1GrgpKaml/kkn2mD5c0X14VcfBUHsLWHo1muYrolUXoWz GJUxM0DGvP0hjhtWfAOTcc07hXQws/8ExIzGJ0kiojr0DN020CIIhmF8C3N00PG0PgtzCNhX1NORF N5zuWEolZk6sbuiXt2cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjjCv-0000000DAaX-36L1; Tue, 14 Jul 2026 19:54:21 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjjCt-0000000DAaE-3tQS for linux-phy@lists.infradead.org; Tue, 14 Jul 2026 19:54:19 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 9AD2943BE7; Tue, 14 Jul 2026 19:54:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C8C91F000E9; Tue, 14 Jul 2026 19:54:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784058857; bh=GKwk8o438WlpFTg0T9EkOBKX6Io2q4+YhJxzyFYieTI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=oxiLstHe0cfckh7Wn3vAo7vz3m0+4VYY3cTHNwuBkWZYbNb3TsjRhvbHNWpS2qOUW KOh0D/rQPwPBRr3Qu605NMu9Z5Grrvl9wES1+3wR/JXTs12WUCN3N10Py8KdxniBaE KEZyRESctGChYBmtlNWNPHV56td+xAa/SR51URjJTjGkMyUB5a/3pmK1MNHIbG5v2M Gn7dNw/jUd1ARtThZNvuyvMD0MDqAQlopMVMvIBRDrjVQLwApE6vUU1X3iQMdqZrpF kWNgtv+DaS9GFU/j6z+jPagZ4AXYzuBgrg7Jnm+AI3JEuxrsszYbnMBDaAAxkLE5ps srWcC9+lt2Wmw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v13 02/35] phy: rockchip: usbdp: Update mode_change after error handling To: "Sebastian Reichel" Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com, linux-phy@lists.infradead.org In-Reply-To: <20260714-rockchip-usbdp-cleanup-v13-2-6cb3e769d4c5@collabora.com> References: <20260714-rockchip-usbdp-cleanup-v13-0-6cb3e769d4c5@collabora.com> <20260714-rockchip-usbdp-cleanup-v13-2-6cb3e769d4c5@collabora.com> Date: Tue, 14 Jul 2026 19:54:16 +0000 Message-Id: <20260714195417.0C8C91F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg NyBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBTdGF0ZSB0cmFja2luZyBjb3JydXB0aW9uIGluIGBya191ZHBoeV9wb3dlcl9vbmAg ZHJvcHMgYWN0aXZlIGNvbnN1bWVyIG1vZGVzLgotIFtIaWdoXSBVU0IzIHBvcnQgcmVtYWlucyBk aXNhYmxlZCBpbiBzeXN0ZW0gY29udHJvbGxlciB3aGVuIHN3aXRjaGluZyBmcm9tIERQLW9ubHkg dG8gRFArVVNCIG1vZGUuCi0gW0hpZ2hdIER5bmFtaWNhbGx5IGRpc2FibGluZyBQSFkgY2xvY2tz IHdpdGhvdXQgVVNCIGNvbnRyb2xsZXIgY29vcmRpbmF0aW9uIGNhdXNlcyBTRXJyb3JzLgotIFtI aWdoXSBUeXBlLUMgZGlzY29ubmVjdHMgKFRZUEVDX1NUQVRFX1NBRkUpIG9yIFVTQi1vbmx5IHRy YW5zaXRpb25zIGFyZSBpZ25vcmVkLCBzdHJhbmRpbmcgUEhZIHN0YXRlLgotIFtIaWdoXSBNaXNz aW5nIG11dGV4IHByb3RlY3Rpb24gaW4gYHJrX3VkcGh5X2RwX3BoeV9jb25maWd1cmVgIGFsbG93 cyBjb25jdXJyZW50IGFjY2VzcyB0byBzaGFyZWQgUEhZIHN0YXRlLgotIFtNZWRpdW1dIFByb2Jl IGVycm9yIHBhdGhzIGFuZCBkcml2ZXIgdW5iaW5kIGxlYWsgY2xvY2sgcmVmZXJlbmNlcy4KLSBb TWVkaXVtXSBVMyBwb3J0IHJlbWFpbnMgZW5hYmxlZCBpbiBzeXN0ZW0gY29udHJvbGxlciB3aGVu IGluaXRpYWxpemluZyBpbnRvIERQLW9ubHkgbW9kZS4KLS0KCi0tLSBQYXRjaCBbMl06IFtQQVRD SCB2MTMgMDIvMzVdIHBoeTogcm9ja2NoaXA6IHVzYmRwOiBVcGRhdGUgbW9kZV9jaGFuZ2UgYWZ0 ZXIgZXJyb3IgaGFuZGxpbmcgLS0tCmNvbW1pdCA1ZTY4NGQ2YjQzM2FlNzM4YmQ1ZjM3OGQ3Mjk0 ZDllNzZhMjE5OWQ5CkF1dGhvcjogU2ViYXN0aWFuIFJlaWNoZWwgPHNlYmFzdGlhbi5yZWljaGVs QGNvbGxhYm9yYS5jb20+CgpwaHk6IHJvY2tjaGlwOiB1c2JkcDogVXBkYXRlIG1vZGVfY2hhbmdl IGFmdGVyIGVycm9yIGhhbmRsaW5nCgpUaGlzIGNvbW1pdCBkZWxheXMgcmVzZXR0aW5nIHRoZSBt b2RlX2NoYW5nZSBmbGFnIGluIHJrX3VkcGh5X3Bvd2VyX29uKCkKdW50aWwgYWZ0ZXIgYWxsIHBv dGVudGlhbCBlcnJvcnMgYXJlIGhhbmRsZWQuIFRoaXMgZW5zdXJlcyB0aGF0IGlmCnJrX3VkcGh5 X3NldHVwKCkgZmFpbHMsIHRoZSByZWluaXRpYWxpemF0aW9uIGF0dGVtcHQgd29uJ3QgYmUgc2ls ZW50bHkKc2tpcHBlZCBvbiBzdWJzZXF1ZW50IHRyaWVzLgoKQ2xvc2VzOiBodHRwczovL2xvcmUu a2VybmVsLm9yZy9saW51eC1waHkvMjAyNjA2MTIxNjM4MzUuOEQ1NDcxRjAwMEU5QHNtdHAua2Vy bmVsLm9yZy8KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hp cC11c2JkcC5jIGIvZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJvY2tjaGlwLXVzYmRwLmMKPiAt LS0gYS9kcml2ZXJzL3BoeS9yb2NrY2hpcC9waHktcm9ja2NoaXAtdXNiZHAuYwo+ICsrKyBiL2Ry aXZlcnMvcGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hpcC11c2JkcC5jCj4gQEAgLTEwMDAsMTUgKzEw MDAsMTQgQEAgc3RhdGljIGludCBya191ZHBoeV9wb3dlcl9vbihzdHJ1Y3QgcmtfdWRwaHkgKnVk cGh5LCB1OCBtb2RlKQoKWyAuLi4gXQoKPiAgCWlmICh1ZHBoeS0+c3RhdHVzID09IFVEUEhZX01P REVfTk9ORSkgewo+IC0JCXVkcGh5LT5tb2RlX2NoYW5nZSA9IGZhbHNlOwo+ICAJCXJldCA9IHJr X3VkcGh5X3NldHVwKHVkcGh5KTsKPiAgCQlpZiAocmV0KQo+ICAJCQlyZXR1cm4gcmV0Owo+ICAK PiAgCQlpZiAodWRwaHktPm1vZGUgJiBVRFBIWV9NT0RFX1VTQikKPiAgCQkJcmtfdWRwaHlfdTNf cG9ydF9kaXNhYmxlKHVkcGh5LCBmYWxzZSk7Cj4gLQl9IGVsc2UgaWYgKHVkcGh5LT5tb2RlX2No YW5nZSkgewo+ICAJCXVkcGh5LT5tb2RlX2NoYW5nZSA9IGZhbHNlOwo+ICsJfSBlbHNlIGlmICh1 ZHBoeS0+bW9kZV9jaGFuZ2UpIHsKCltTZXZlcml0eTogTWVkaXVtXQpUaGlzIGlzIGEgcHJlLWV4 aXN0aW5nIGlzc3VlLCBidXQgZG9lcyB0aGlzIGJsb2NrIGxlYXZlIHRoZSBVMyBwb3J0IGVuYWJs ZWQKd2hlbiBpbml0aWFsaXppbmcgaW50byBEUC1vbmx5IG1vZGU/CgpJZiB0aGUgUEhZIGlzIGNv bXBsZXRlbHkgcG93ZXJlZCBvZmYgYW5kIHRoZSBUeXBlLUMgbXV4IHNlbGVjdHMgRFAtb25seSBt b2RlLAp0aGUgRFAgY29uc3VtZXIgY2FsbHMgcmtfdWRwaHlfcG93ZXJfb24oKS4KCldoaWxlIHRo aXMgYmxvY2sgaGFuZGxlcyBpbml0aWFsaXphdGlvbiwgaXQgbGFja3MgdGhlIGxvZ2ljIHRvIGNh bGwKcmtfdWRwaHlfdTNfcG9ydF9kaXNhYmxlKHVkcGh5LCB0cnVlKS4gSWYgdGhlIFVTQiBjb25z dW1lciBpcyBub3QgYm91bmQgb3IKaW5pdGlhbGl6ZWQgeWV0LCBkb2VzIHRoZSBHUkYgcmVnaXN0 ZXIgZm9yIHRoZSBVMyBwb3J0IHJldGFpbiBpdHMgcHJldmlvdXMKc3RhdGUsIHBvdGVudGlhbGx5 IGNhdXNpbmcgdW5leHBlY3RlZCBiZWhhdmlvciBvciBtaW5vciBwb3dlciBkcmFpbj8KCj4gIAkJ dWRwaHktPnN0YXR1cyA9IFVEUEhZX01PREVfTk9ORTsKCltTZXZlcml0eTogSGlnaF0KVGhpcyBp cyBhIHByZS1leGlzdGluZyBpc3N1ZSwgYnV0IGRvZXMgdGhpcyBhZ2dyZXNzaXZlbHkgY2xlYXIg dGhlIHN0YXRlIGFuZApkcm9wIGFjdGl2ZSBjb25zdW1lciBtb2Rlcz8KCklmIGJvdGggRFAgYW5k IFVTQiBjb25zdW1lcnMgYXJlIGFjdGl2ZSwgYW5kIGEgVHlwZS1DIGV2ZW50IHRyaWdnZXJzIGEg bW9kZQpjaGFuZ2UsIHRoZSBmaXJzdCBjb25zdW1lciB0byBjYWxsIHJrX3VkcGh5X3Bvd2VyX29u KCkgZXhlY3V0ZXMgdGhpcyBibG9jay4KQnkgZm9yY2VmdWxseSBvdmVyd3JpdGluZyB1ZHBoeS0+ c3RhdHVzID0gVURQSFlfTU9ERV9OT05FIGJlZm9yZQpyZS1pbml0aWFsaXppbmcsIGFuZCBvbmx5 IGFwcGVuZGluZyB0aGUgY2FsbGVyJ3MgbW9kZSBhdCB0aGUgZW5kCih1ZHBoeS0+c3RhdHVzIHw9 IG1vZGUpLCBpc24ndCB0aGUgb3RoZXIgYWN0aXZlIGNvbnN1bWVyJ3Mgc3RhdGUgZmxhZwpwZXJt YW5lbnRseSBsb3N0PwoKSWYgdGhhdCBmaXJzdCBjb25zdW1lciBsYXRlciBjYWxscyBya191ZHBo eV9wb3dlcl9vZmYoKSwgd291bGRuJ3QgdGhlIHN0YXR1cwpldmFsdWF0ZSB0byAwIGFuZCBjb21w bGV0ZWx5IGRpc2FibGUgdGhlIFBIWSwgY3Jhc2hpbmcgdGhlIG90aGVyIGNvbnN1bWVyCndoaWNo IGlzIHN0aWxsIHJ1bm5pbmc/Cgo+ICAJCWlmICh1ZHBoeS0+bW9kZSA9PSBVRFBIWV9NT0RFX0RQ KQo+ICAJCQlya191ZHBoeV91M19wb3J0X2Rpc2FibGUodWRwaHksIHRydWUpOwoKWyAuLi4gXQoK PiAgCQlya191ZHBoeV9kaXNhYmxlKHVkcGh5KTsKCltTZXZlcml0eTogSGlnaF0KVGhpcyBpc24n dCBhIGJ1ZyBpbnRyb2R1Y2VkIGJ5IHRoaXMgcGF0Y2gsIGJ1dCBjYW4gZHluYW1pY2FsbHkgZGlz YWJsaW5nIFBIWQpjbG9ja3Mgd2l0aG91dCBjb29yZGluYXRpbmcgd2l0aCB0aGUgVVNCIGNvbnRy b2xsZXIgY2F1c2UgU0Vycm9ycz8KCldoZW4gYSBUeXBlLUMgbW9kZSBjaGFuZ2Ugb2NjdXJzIHdo aWxlIHRoZSBVU0IgY29udHJvbGxlciAoRFdDMykgaXMgYWN0aXZlLAp0aGlzIGJsb2NrIGNhbGxz IHJrX3VkcGh5X2Rpc2FibGUoKSwgd2hpY2ggaW1tZWRpYXRlbHkgY3V0cyB0aGUgUEhZIGNsb2Nr cy4KCkJlY2F1c2UgdGhlcmUgaXMgbm8gY29vcmRpbmF0aW9uIChsaWtlIHBoeV9ub3RpZnlfcmVz ZXQpIHRvIHF1aWVzY2UgRFdDMyBvcgpyZXJvdXRlIGl0cyBjbG9jayB2aWEgcmtfdWRwaHlfdTNf cG9ydF9kaXNhYmxlKHVkcGh5LCB0cnVlKSBiZWZvcmUgdGhlCmRpc2FibGUgY2FsbCwgd2lsbCBh bnkgYWN0aXZlIERXQzMgcmVnaXN0ZXIgYWNjZXNzIGluc3RhbnRseSBjYXVzZSBhbiBTRXJyb3IK a2VybmVsIHBhbmljPwoKPiAgCQlyZXQgPSBya191ZHBoeV9zZXR1cCh1ZHBoeSk7Cj4gIAkJaWYg KHJldCkKPiAgCQkJcmV0dXJuIHJldDsKPiArCQl1ZHBoeS0+bW9kZV9jaGFuZ2UgPSBmYWxzZTsK PiAgCX0KCltTZXZlcml0eTogSGlnaF0KVGhpcyBpcyBhIHByZS1leGlzdGluZyBpc3N1ZSwgYnV0 IGRvZXMgdGhpcyBicmFuY2ggbGVhdmUgdGhlIFVTQiAzLjAgcG9ydApkaXNhYmxlZD8KCldoZW4g dGhlIFR5cGUtQyBwb3J0IHN3aXRjaGVzIGZyb20gRFAtb25seSB0byBEUCtVU0IgbW9kZSwgdGhl IFVTQjMgcG9ydCB3YXMKcHJldmlvdXNseSBkaXNhYmxlZCB2aWEgR1JGIHJlZ2lzdGVycy4gVGhp cyBicmFuY2ggcmVzZXRzIHRoZSBQSFkgYW5kIGNsZWFycwptb2RlX2NoYW5nZSwgYnV0IGl0IG5l dmVyIGV4cGxpY2l0bHkgY2FsbHMgcmtfdWRwaHlfdTNfcG9ydF9kaXNhYmxlKHVkcGh5LApmYWxz ZSkgdG8gcmUtZW5hYmxlIGl0LgoKU2luY2UgdGhlIFVTQiBjb25zdW1lcidzIGluaXRpYWxpemF0 aW9uIHJlbGllcyBvbiBya191ZHBoeV9wb3dlcl9vbigpIHRvCmhhbmRsZSB0aGlzLCB3aWxsIGFu eSBkeW5hbWljIHRyYW5zaXRpb24gZnJvbSBEUC1vbmx5IHRvIERQK1VTQiB2aWEgY2FibGUKZmxp cCBvciByZXBsdWcgbGVhdmUgdGhlIFVTQjMgcG9ydCBicm9rZW4/CgoKW1NldmVyaXR5OiBIaWdo XQpUaGlzIGlzbid0IGEgYnVnIGludHJvZHVjZWQgYnkgdGhpcyBwYXRjaCwgYnV0IGFyZSBUeXBl LUMgZGlzY29ubmVjdHMgYmVpbmcKaWdub3JlZCBpbiBya191ZHBoeV90eXBlY19tdXhfc2V0KCk/ CgpMb29raW5nIGF0IHJrX3VkcGh5X3R5cGVjX211eF9zZXQoKSwgdGhlIG1vZGUgdXBkYXRlIGlz IGltcHJvcGVybHkgZ2F0ZWQKYmVoaW5kIGFuIGFsdC1tb2RlIGNoZWNrOgoKZHJpdmVycy9waHkv cm9ja2NoaXAvcGh5LXJvY2tjaGlwLXVzYmRwLmM6cmtfdWRwaHlfdHlwZWNfbXV4X3NldCgpIHsK ICAgIC4uLgogICAgaWYgKHN0YXRlLT5hbHQgJiYgc3RhdGUtPmFsdC0+c3ZpZCA9PSBVU0JfVFlQ RUNfRFBfU0lEKSB7CiAgICAgICAgc3RydWN0IHR5cGVjX2Rpc3BsYXlwb3J0X2RhdGEgKmRhdGEg PSBzdGF0ZS0+ZGF0YTsKCiAgICAgICAgaWYgKCFkYXRhKSB7CiAgICAuLi4KfQoKT24gVHlwZS1D IGNhYmxlIHVucGx1ZyBvciBhIHRyYW5zaXRpb24gdG8gVVNCLW9ubHkgbW9kZSwgc3RhdGUtPm1v ZGUgaXMKVFlQRUNfU1RBVEVfU0FGRSBvciBUWVBFQ19TVEFURV9VU0IsIHNvIHN0YXRlLT5hbHQg aXMgTlVMTC4gU2luY2UgdGhlIG1vZGUKdXBkYXRlIGxvZ2ljIGlzIHN0cmljdGx5IGd1YXJkZWQg YnkgdGhlIFNWSUQgY2hlY2ssIGl0IGdldHMgY29tcGxldGVseQpieXBhc3NlZC4KCkRvZXMgdGhp cyBsZWF2ZSB1ZHBoeS0+bW9kZSBpbmRlZmluaXRlbHkgcmV0YWluaW5nIHRoZSBvbGQgRFAgc3Rh dGUsIGJyZWFraW5nCnN1YnNlcXVlbnQgVVNCIGNvbm5lY3Rpb25zIGFuZCBwcmV2ZW50aW5nIHBy b3BlciBQSFkgcG93ZXIgZG93bj8KCgpbU2V2ZXJpdHk6IEhpZ2hdClRoaXMgaXMgYSBwcmUtZXhp c3RpbmcgaXNzdWUsIGJ1dCBpcyB0aGVyZSBtaXNzaW5nIG11dGV4IHByb3RlY3Rpb24gaW4Kcmtf dWRwaHlfZHBfcGh5X2NvbmZpZ3VyZSgpPwoKVGhpcyBmdW5jdGlvbiBhY2Nlc3NlcyBhbmQgbXV0 YXRlcyBzaGFyZWQgc3RhdGUgd2l0aG91dCBhY3F1aXJpbmcKdWRwaHktPm11dGV4OgoKZHJpdmVy cy9waHkvcm9ja2NoaXAvcGh5LXJvY2tjaGlwLXVzYmRwLmM6cmtfdWRwaHlfZHBfcGh5X2NvbmZp Z3VyZSgpIHsKICAgIC4uLgogICAgaWYgKGRwLT5zZXRfcmF0ZSkgewogICAgICAgIHVkcGh5LT5s aW5rX3JhdGUgPSBkcC0+bGlua19yYXRlOwogICAgLi4uCn0KClNpbmNlIHJrX3VkcGh5X2RwX3Bo eV9jb25maWd1cmUoKSBpcyBpbnZva2VkIGJ5IHRoZSBEUCBzdWJzeXN0ZW0gZHVyaW5nIGxpbmsK dHJhaW5pbmcsIGl0IHJlYWRzIHNoYXJlZCBzdGF0ZSBsaWtlIHVkcGh5LT5sYW5lX211eF9zZWwg YW5kIG1vZGlmaWVzCnVkcGh5LT5idyBhbmQgdWRwaHktPmxpbmtfcmF0ZS4KCk1lYW53aGlsZSwg YW4gYXN5bmNocm9ub3VzIFR5cGUtQyBldmVudCBydW5uaW5nIHJrX3VkcGh5X3R5cGVjX211eF9z ZXQoKQptb2RpZmllcyB0aGVzZSBleGFjdCBhcnJheXMgd2hpbGUgaG9sZGluZyB0aGUgbXV0ZXgu IENhbiB0aGlzIHJhY2UgY29uZGl0aW9uCmxlYWQgdG8gcmVhZGluZyB0b3JuIGxhbmUgbWFwcGlu Z3MgYW5kIHByb2dyYW1taW5nIGluY29ycmVjdCBoYXJkd2FyZQpyZWdpc3RlcnM/CgoKW1NldmVy aXR5OiBNZWRpdW1dClRoaXMgaXNuJ3QgYSBidWcgaW50cm9kdWNlZCBieSB0aGlzIHBhdGNoLCBi dXQgZG8gdGhlIHByb2JlIGVycm9yIHBhdGhzIGFuZApkcml2ZXIgdW5iaW5kIGxlYWsgY2xvY2sg cmVmZXJlbmNlcz8KCkluIHJrX3VkcGh5X3Byb2JlKCksIGNsb2NrcyBjYW4gYmUgZW5hYmxlZCBp ZiB0aGUgYm9vdGxvYWRlciBsZWZ0IHRoZSBQSFkKYWN0aXZlOgoKZHJpdmVycy9waHkvcm9ja2No aXAvcGh5LXJvY2tjaGlwLXVzYmRwLmM6cmtfdWRwaHlfcHJvYmUoKSB7CiAgICAuLi4KICAgIHJl dCA9IHJrX3VkcGh5X2dldF9pbml0aWFsX3N0YXR1cyh1ZHBoeSk7CiAgICBpZiAocmV0KQogICAg ICAgIHJldHVybiByZXQ7CgogICAgbXV0ZXhfaW5pdCgmdWRwaHktPm11dGV4KTsKICAgIHBsYXRm b3JtX3NldF9kcnZkYXRhKHBkZXYsIHVkcGh5KTsKICAgIC4uLgp9CgpJZiBhIHN1YnNlcXVlbnQg c3RlcCBpbiB0aGUgcHJvYmUgZmFpbHMgKHN1Y2ggYXMgZGV2bV9waHlfY3JlYXRlKSwgb3IgaWYg dGhlCmRyaXZlciBpcyB1bmJvdW5kLCB0aGVyZSBhcHBlYXJzIHRvIGJlIG5vIGNvcnJlc3BvbmRp bmcKY2xrX2J1bGtfZGlzYWJsZV91bnByZXBhcmUoKSBleGVjdXRpb24gb3IgLnJlbW92ZSBjYWxs YmFjayB0byByZWxlYXNlIHRoZXNlCmNsb2Nrcy4gRG9lcyB0aGlzIGNhdXNlIGEgY2xvY2sgcmVm ZXJlbmNlIGNvdW50IGxlYWs/CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNo aWtvLmRldi8jL3BhdGNoc2V0LzIwMjYwNzE0LXJvY2tjaGlwLXVzYmRwLWNsZWFudXAtdjEzLTAt NmNiM2U3NjlkNGM1QGNvbGxhYm9yYS5jb20/cGFydD0yCgotLSAKbGludXgtcGh5IG1haWxpbmcg bGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK