From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCF97C43458 for ; Tue, 14 Jul 2026 20:02:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cT+SCykNq19Qst6a0j3HSAo947X/m3QATNSvSy7zIyw=; b=gkCoAtnvQVMrSZ 0G2KzjJM6bXO6cpf2K0G96ZZvobrt4AhYnT1E+CPwTtaKDa+lngziN34pDSzrotOQHxMwvhQ+o9Ae 9vTX72lOhwFpaRVJUUsBLgyvfvbFfvfo2p/k5tQq4CA6EeEMQV2EhV7pAT+CyopDI9tgsTG3buH+c LVYTi7fRZxnAiKzKwZXXNvRKFf8JKbBsz+BH37h37R+RKOn6ub22dAIbqN97o0jNDIWAkU2PAve4V X/xcNSJ+pnUhwTirQETx56LxkTS79cr6W5dZ0oNNoxhPMfSBOueUpx/bJUqSwtr0n+WgnSy6V+NyR hftoYJqA5s5zE/drkoSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjjKK-0000000DBE0-2T04; Tue, 14 Jul 2026 20:02:00 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjjKJ-0000000DBDo-2pJm for linux-phy@lists.infradead.org; Tue, 14 Jul 2026 20:01:59 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 2088F60103; Tue, 14 Jul 2026 20:01:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53F541F00A3A; Tue, 14 Jul 2026 20:01:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784059318; bh=UDJIT3Wc6aA9Q1xwXyK/PSKaA59Lc/tsV5lpmkJ/x1E=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=W9V2CDRjLKRO6lKgQ92L08Lv5pvFWSrHNl3W3wMtpVJvO6roREycuf3hISGeg5GDl P6mC87jNKQQVl38tChnl+VOypPcXftEJ8N67jySLPwi2LsyDjc23imF0rzfCFT/yJs LNlh2D+hYLAr5MwTI26vYBkvTvYOWaBds9IYb2cyXOXWkuLh2cZyMvwHBpkTst/rv4 f2CBuTUAXP9y7jb3pgYez3uKOLzX+YUnGZZ0rLCLYMLevtF9g76VRMYjFf2SuS2R8F Q1MijBMWxmWLjh6/3FXeM8lMXIenHNUKRE7yNOBucRVUF03RXIbI1sUg3hc+Cvki45 7cdofwKVlw52w== From: sashiko-bot@kernel.org Subject: Re: [PATCH v13 06/35] phy: rockchip: usbdp: Drop seamless DP takeover To: "Sebastian Reichel" Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, vkoul@kernel.org, linux-phy@lists.infradead.org, neil.armstrong@linaro.org, olteanv@gmail.com, robh@kernel.org In-Reply-To: <20260714-rockchip-usbdp-cleanup-v13-6-6cb3e769d4c5@collabora.com> References: <20260714-rockchip-usbdp-cleanup-v13-0-6cb3e769d4c5@collabora.com> <20260714-rockchip-usbdp-cleanup-v13-6-6cb3e769d4c5@collabora.com> Date: Tue, 14 Jul 2026 20:01:57 +0000 Message-Id: <20260714200158.53F541F00A3A@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBVbmJhbGFuY2VkIGNsb2NrIGRpc2FibGUgaW4gdGhlIGBya191ZHBoeV9wb3dlcl9v bigpYCBlcnJvciBwYXRoIGR1cmluZyBtb2RlIGNoYW5nZXMsIGxlYWRpbmcgdG8gYSBwb3RlbnRp YWwgY2xvY2sgcmVmZXJlbmNlIGNvdW50IHVuZGVyZmxvdy4KLSBbSGlnaF0gRGF0YSByYWNlIG9u IERQIFBIWSBjb25maWd1cmF0aW9uIGFycmF5cyBgZHBfbGFuZV9zZWxgIGFuZCBgbGFuZV9tdXhf c2VsYCB3aXRob3V0IG11dGV4IHByb3RlY3Rpb24uCi0tCgotLS0gUGF0Y2ggWzZdOiBbUEFUQ0gg djEzIDA2LzM1XSBwaHk6IHJvY2tjaGlwOiB1c2JkcDogRHJvcCBzZWFtbGVzcyBEUCB0YWtlb3Zl ciAtLS0KY29tbWl0IDllYjBiNjgzYzFhMTkwMGVmYzEyYTczMzQ4ZDMyNDE0N2ZmNDA0N2YKQXV0 aG9yOiBTZWJhc3RpYW4gUmVpY2hlbCA8c2ViYXN0aWFuLnJlaWNoZWxAY29sbGFib3JhLmNvbT4K U3ViamVjdDogcGh5OiByb2NrY2hpcDogdXNiZHA6IERyb3Agc2VhbWxlc3MgRFAgdGFrZW92ZXIK ClRoaXMgY29tbWl0IGRyb3BzIHN1cHBvcnQgZm9yIHNlYW1sZXNzIERQIHRha2VvdmVyIGluIHRo ZSBSb2NrY2hpcCBVU0JEUApQSFkgZHJpdmVyLiBUaGUgZmVhdHVyZSB3YXMgbWlzc2luZyBpbXBs ZW1lbnRhdGlvbiBpbiBib3RoIERSTSBkcml2ZXJzCmFuZCBib290bG9hZGVycywgYW5kIHByb3Bl ciBVU0ItQyBzdGF0ZSBtYWNoaW5lIGhhbmRvZmYgd291bGQgcmVxdWlyZQpzaWduaWZpY2FudCB3 b3JrLiBUaGUgdW50ZXN0ZWQgY29kZSBzdXBwb3J0aW5nIGl0IGlzIHRoZXJlZm9yZSByZW1vdmVk LgoKQ2xvc2VzOiBodHRwczovL2xvcmUua2VybmVsLm9yZy9saW51eC1waHkvMjAyNjA2MTIxNjQx MDcuQzdEQjIxRjAwMEU5QHNtdHAua2VybmVsLm9yZy8KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv cGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hpcC11c2JkcC5jIGIvZHJpdmVycy9waHkvcm9ja2NoaXAv cGh5LXJvY2tjaGlwLXVzYmRwLmMKPiBpbmRleCAzZmM4MjIyZmNhZWMyLi42Y2I5ZjZiNGRiZjZk IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvcGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hpcC11c2JkcC5j Cj4gKysrIGIvZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJvY2tjaGlwLXVzYmRwLmMKWyAuLi4g XQo+IEBAIC0xNDk1LDEwICsxNDY4LDYgQEAgc3RhdGljIGludCBya191ZHBoeV9wcm9iZShzdHJ1 Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICAJaWYgKHJldCkKPiAgCQlyZXR1cm4gcmV0Owo+ ICAKPiAtCXJldCA9IHJrX3VkcGh5X2dldF9pbml0aWFsX3N0YXR1cyh1ZHBoeSk7Cj4gLQlpZiAo cmV0KQo+IC0JCXJldHVybiByZXQ7Cj4gLQo+ICAJbXV0ZXhfaW5pdCgmdWRwaHktPm11dGV4KTsK PiAgCXBsYXRmb3JtX3NldF9kcnZkYXRhKHBkZXYsIHVkcGh5KTsKPiAgCgpXaGlsZSByZXZpZXdp bmcgdGhpcyBmaWxlLCBJIG5vdGljZWQgYSBjb3VwbGUgb2YgcHJlLWV4aXN0aW5nIGlzc3VlcyBp bgpvdGhlciBhcmVhcyBvZiB0aGUgZHJpdmVyOgoKZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJv Y2tjaGlwLXVzYmRwLmM6cmtfdWRwaHlfcG93ZXJfb24oKSB7ClsgLi4uIF0KCX0gZWxzZSBpZiAo dWRwaHktPm1vZGVfY2hhbmdlKSB7CgkJaWYgKHVkcGh5LT5tb2RlID09IFVEUEhZX01PREVfRFAp CgkJCXJrX3VkcGh5X3UzX3BvcnRfZGlzYWJsZSh1ZHBoeSwgdHJ1ZSk7CgoJCXJrX3VkcGh5X2Rp c2FibGUodWRwaHkpOwoJCXJldCA9IHJrX3VkcGh5X3NldHVwKHVkcGh5KTsKCQlpZiAocmV0KQoJ CQlyZXR1cm4gcmV0OwoJCXVkcGh5LT5tb2RlX2NoYW5nZSA9IGZhbHNlOwoJfQoKCXVkcGh5LT5z dGF0dXMgfD0gbW9kZTsKCglyZXR1cm4gMDsKfQoKW1NldmVyaXR5OiBIaWdoXQpUaGlzIGlzbid0 IGEgYnVnIGludHJvZHVjZWQgYnkgdGhpcyBwYXRjaCwgYnV0IGRvZXMgdGhlIGVycm9yIHBhdGgg aW4KcmtfdWRwaHlfcG93ZXJfb24oKSBsZWFkIHRvIGFuIHVuYmFsYW5jZWQgY2xvY2sgZGlzYWJs ZSBkdXJpbmcgbW9kZSBjaGFuZ2VzPwoKV2hlbiB0cmFuc2l0aW9uaW5nIG1vZGVzLCBya191ZHBo eV9wb3dlcl9vbigpIGRpc2FibGVzIHRoZSBjbG9ja3MgdmlhCnJrX3VkcGh5X2Rpc2FibGUoKSB0 byByZXNldCB0aGUgc3RhdGUsIGFuZCB0aGVuIGNhbGxzIHJrX3VkcGh5X3NldHVwKCkuCgpJZiBy a191ZHBoeV9zZXR1cCgpIGZhaWxzLCBpdCByZXR1cm5zIGVhcmx5IHdpdGhvdXQgdXBkYXRpbmcg dWRwaHktPnN0YXR1cy4KVGhlIHNvZnR3YXJlIHN0YXRlIHJldGFpbnMgdGhlIGFjdGl2ZSBtb2Rl LCBidXQgdGhlIGhhcmR3YXJlIGNsb2NrcyBhcmUKZGlzYWJsZWQuCgpXaGVuIHRoZSBjb25zdW1l ciBsYXRlciBjYWxscyBya191ZHBoeV9wb3dlcl9vZmYoKSwgaXQgcmVhZHMgdGhlIGFjdGl2ZQpz dGF0dXMsIGNsZWFycyBpdCwgYW5kIGNhbGxzIHJrX3VkcGh5X2Rpc2FibGUoKSBhZ2Fpbi4KCkNv dWxkIHRoaXMgcmVzdWx0IGluIGEgZG91YmxlLWRpc2FibGUgYW5kIGEgcG90ZW50aWFsIGNsb2Nr IHJlZmVyZW5jZSBjb3VudAp1bmRlcmZsb3c/CgoKZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJv Y2tjaGlwLXVzYmRwLmM6cmtfdWRwaHlfZHBfcGh5X2NvbmZpZ3VyZSgpIHsKWyAuLi4gXQoJaWYg KGRwLT5zZXRfdm9sdGFnZXMpIHsKCQlmb3IgKGkgPSAwOyBpIDwgdWRwaHktPmxhbmVzOyBpKysp IHsKCQkJbGFuZSA9IHVkcGh5LT5kcF9sYW5lX3NlbFtpXTsKCQkJc3dpdGNoICh1ZHBoeS0+bGlu a19yYXRlKSB7CgkJCWNhc2UgMTYyMDoKCQkJY2FzZSAyNzAwOgoJCQkJcmVnbWFwX3VwZGF0ZV9i aXRzKHVkcGh5LT5wbWFfcmVnbWFwLAoJCQkJCQkgICBUUlNWX0FOQV9UWF9DTEtfT0ZGU0VUX04o bGFuZSksCgkJCQkJCSAgIExOX0FOQV9UWF9TRVJfVFhDTEtfSU5WLAoJCQkJCQkgICBGSUVMRF9Q UkVQKExOX0FOQV9UWF9TRVJfVFhDTEtfSU5WLAoJCQkJCQkgICB1ZHBoeS0+bGFuZV9tdXhfc2Vs W2xhbmVdKSk7ClsgLi4uIF0KfQoKW1NldmVyaXR5OiBIaWdoXQpUaGlzIGlzIGEgcHJlLWV4aXN0 aW5nIGlzc3VlLCBidXQgaXMgdGhlcmUgYSBkYXRhIHJhY2Ugd2hlbiBhY2Nlc3NpbmcgdGhlCkRQ IFBIWSBjb25maWd1cmF0aW9uIGFycmF5cz8KCnJrX3VkcGh5X2RwX3BoeV9jb25maWd1cmUoKSBp cyBjYWxsZWQgYnkgdGhlIFBIWSBmcmFtZXdvcmsgYW5kIHJlYWRzCnVkcGh5LT5kcF9sYW5lX3Nl bCBhbmQgdWRwaHktPmxhbmVfbXV4X3NlbCB3aXRob3V0IGFjcXVpcmluZyB1ZHBoeS0+bXV0ZXgu CgpDb25jdXJyZW50bHksIHR5cGUtQyB3b3JrcXVldWVzIGNhbiB3cml0ZSB0byB0aGVzZSBzYW1l IGFycmF5cyB3aGlsZSBob2xkaW5nCnVkcGh5LT5tdXRleDoKCmRyaXZlcnMvcGh5L3JvY2tjaGlw L3BoeS1yb2NrY2hpcC11c2JkcC5jOnJrX3VkcGh5X3R5cGVjX211eF9zZXQoKSB7ClsgLi4uIF0K CW11dGV4X2xvY2soJnVkcGh5LT5tdXRleCk7CgoJc3dpdGNoIChzdGF0ZS0+bW9kZSkgewoJY2Fz ZSBUWVBFQ19EUF9TVEFURV9DOgoJY2FzZSBUWVBFQ19EUF9TVEFURV9FOgoJCXVkcGh5LT5sYW5l X211eF9zZWxbMF0gPSBQSFlfTEFORV9NVVhfRFA7CgkJdWRwaHktPmxhbmVfbXV4X3NlbFsxXSA9 IFBIWV9MQU5FX01VWF9EUDsKCQl1ZHBoeS0+bGFuZV9tdXhfc2VsWzJdID0gUEhZX0xBTkVfTVVY X0RQOwoJCXVkcGh5LT5sYW5lX211eF9zZWxbM10gPSBQSFlfTEFORV9NVVhfRFA7ClsgLi4uIF0K fQoKSWYgYW4gYXN5bmNocm9ub3VzIHR5cGUtQyBldmVudCBhcnJpdmVzIHdoaWxlIHRoZSBkaXNw bGF5IGNvbnRyb2xsZXIgaXMKY29uZmlndXJpbmcgdGhlIFBIWSBmb3IgbGluayB0cmFpbmluZywg Y2FuIHRoZSBhcnJheXMgYmUgcmVhZCBpbiBhIHBhcnRpYWxseQp1cGRhdGVkIHN0YXRlPwoKQ291 bGQgdGhpcyByZXN1bHQgaW4gYW4gaW52YWxpZCBEUCBsYW5lIGNvbmZpZ3VyYXRpb24gYmVpbmcg YXBwbGllZCB0byB0aGUKaGFyZHdhcmUsIGxlYWRpbmcgdG8gRFAgYWx0IG1vZGUgZmFpbHVyZSBv ciBkaXNwbGF5IGNvcnJ1cHRpb24/CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9z YXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYwNzE0LXJvY2tjaGlwLXVzYmRwLWNsZWFudXAtdjEz LTAtNmNiM2U3NjlkNGM1QGNvbGxhYm9yYS5jb20/cGFydD02CgotLSAKbGludXgtcGh5IG1haWxp bmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE5A43F54AB for ; Tue, 14 Jul 2026 20:02:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784059325; cv=none; b=ou+YcaXB9TYtzU8UNWfOSVAGqPMOJbWbsecLJDtH1cNDOkCmX3Y3o4eUbUY1a0VRNSzPVCTErqsj39zW/u+JqJulnA4250y2Zyi8ndSzVeNqCTGMErEaOhFgO/wmOgD8a9ii7Zfse3M+N3nNO+RTuZEApK8FiGdUVJ3yGjztzhU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784059325; c=relaxed/simple; bh=aI9nSj2nUAVpg01rZQ2L2M64ckDSR0IK3+KqY1Ot6ZQ=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=t4qcf489icrItencbO4NROAFvaCBoJHDhURsZuQhzpGuSQo7qbzC+xpcUPWjm8XmoLNQGxVmgvsCqUA6cHn4rdguQOgWKwf9ENnY1HOgg0271xr3zdEKwCZm/2bIAhrOp6ztmOv6kppM3R6/ayKzMTAPFNLuaJNdqxj4CM4fEcg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=W9V2CDRj; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="W9V2CDRj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53F541F00A3A; Tue, 14 Jul 2026 20:01:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784059318; bh=UDJIT3Wc6aA9Q1xwXyK/PSKaA59Lc/tsV5lpmkJ/x1E=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=W9V2CDRjLKRO6lKgQ92L08Lv5pvFWSrHNl3W3wMtpVJvO6roREycuf3hISGeg5GDl P6mC87jNKQQVl38tChnl+VOypPcXftEJ8N67jySLPwi2LsyDjc23imF0rzfCFT/yJs LNlh2D+hYLAr5MwTI26vYBkvTvYOWaBds9IYb2cyXOXWkuLh2cZyMvwHBpkTst/rv4 f2CBuTUAXP9y7jb3pgYez3uKOLzX+YUnGZZ0rLCLYMLevtF9g76VRMYjFf2SuS2R8F Q1MijBMWxmWLjh6/3FXeM8lMXIenHNUKRE7yNOBucRVUF03RXIbI1sUg3hc+Cvki45 7cdofwKVlw52w== From: sashiko-bot@kernel.org Subject: Re: [PATCH v13 06/35] phy: rockchip: usbdp: Drop seamless DP takeover Reply-To: sashiko-reviews@lists.linux.dev To: "Sebastian Reichel" Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, vkoul@kernel.org, linux-phy@lists.infradead.org, neil.armstrong@linaro.org, olteanv@gmail.com, robh@kernel.org In-Reply-To: <20260714-rockchip-usbdp-cleanup-v13-6-6cb3e769d4c5@collabora.com> References: <20260714-rockchip-usbdp-cleanup-v13-0-6cb3e769d4c5@collabora.com> <20260714-rockchip-usbdp-cleanup-v13-6-6cb3e769d4c5@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 14 Jul 2026 20:01:57 +0000 Message-Id: <20260714200158.53F541F00A3A@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: Pre-existing issues: - [High] Unbalanced clock disable in the `rk_udphy_power_on()` error path d= uring mode changes, leading to a potential clock reference count underflow. - [High] Data race on DP PHY configuration arrays `dp_lane_sel` and `lane_m= ux_sel` without mutex protection. -- --- Patch [6]: [PATCH v13 06/35] phy: rockchip: usbdp: Drop seamless DP tak= eover --- commit 9eb0b683c1a1900efc12a73348d324147ff4047f Author: Sebastian Reichel Subject: phy: rockchip: usbdp: Drop seamless DP takeover This commit drops support for seamless DP takeover in the Rockchip USBDP PHY driver. The feature was missing implementation in both DRM drivers and bootloaders, and proper USB-C state machine handoff would require significant work. The untested code supporting it is therefore removed. Closes: https://lore.kernel.org/linux-phy/20260612164107.C7DB21F000E9@smtp.= kernel.org/ > diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rock= chip/phy-rockchip-usbdp.c > index 3fc8222fcaec2..6cb9f6b4dbf6d 100644 > --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c > +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c [ ... ] > @@ -1495,10 +1468,6 @@ static int rk_udphy_probe(struct platform_device *= pdev) > if (ret) > return ret; > =20 > - ret =3D rk_udphy_get_initial_status(udphy); > - if (ret) > - return ret; > - > mutex_init(&udphy->mutex); > platform_set_drvdata(pdev, udphy); > =20 While reviewing this file, I noticed a couple of pre-existing issues in other areas of the driver: drivers/phy/rockchip/phy-rockchip-usbdp.c:rk_udphy_power_on() { [ ... ] } else if (udphy->mode_change) { if (udphy->mode =3D=3D UDPHY_MODE_DP) rk_udphy_u3_port_disable(udphy, true); rk_udphy_disable(udphy); ret =3D rk_udphy_setup(udphy); if (ret) return ret; udphy->mode_change =3D false; } udphy->status |=3D mode; return 0; } [Severity: High] This isn't a bug introduced by this patch, but does the error path in rk_udphy_power_on() lead to an unbalanced clock disable during mode changes? When transitioning modes, rk_udphy_power_on() disables the clocks via rk_udphy_disable() to reset the state, and then calls rk_udphy_setup(). If rk_udphy_setup() fails, it returns early without updating udphy->status. The software state retains the active mode, but the hardware clocks are disabled. When the consumer later calls rk_udphy_power_off(), it reads the active status, clears it, and calls rk_udphy_disable() again. Could this result in a double-disable and a potential clock reference count underflow? drivers/phy/rockchip/phy-rockchip-usbdp.c:rk_udphy_dp_phy_configure() { [ ... ] if (dp->set_voltages) { for (i =3D 0; i < udphy->lanes; i++) { lane =3D udphy->dp_lane_sel[i]; switch (udphy->link_rate) { case 1620: case 2700: regmap_update_bits(udphy->pma_regmap, TRSV_ANA_TX_CLK_OFFSET_N(lane), LN_ANA_TX_SER_TXCLK_INV, FIELD_PREP(LN_ANA_TX_SER_TXCLK_INV, udphy->lane_mux_sel[lane])); [ ... ] } [Severity: High] This is a pre-existing issue, but is there a data race when accessing the DP PHY configuration arrays? rk_udphy_dp_phy_configure() is called by the PHY framework and reads udphy->dp_lane_sel and udphy->lane_mux_sel without acquiring udphy->mutex. Concurrently, type-C workqueues can write to these same arrays while holding udphy->mutex: drivers/phy/rockchip/phy-rockchip-usbdp.c:rk_udphy_typec_mux_set() { [ ... ] mutex_lock(&udphy->mutex); switch (state->mode) { case TYPEC_DP_STATE_C: case TYPEC_DP_STATE_E: udphy->lane_mux_sel[0] =3D PHY_LANE_MUX_DP; udphy->lane_mux_sel[1] =3D PHY_LANE_MUX_DP; udphy->lane_mux_sel[2] =3D PHY_LANE_MUX_DP; udphy->lane_mux_sel[3] =3D PHY_LANE_MUX_DP; [ ... ] } If an asynchronous type-C event arrives while the display controller is configuring the PHY for link training, can the arrays be read in a partially updated state? Could this result in an invalid DP lane configuration being applied to the hardware, leading to DP alt mode failure or display corruption? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260714-rockchip-u= sbdp-cleanup-v13-0-6cb3e769d4c5@collabora.com?part=3D6