From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C7B8C44507 for ; Tue, 14 Jul 2026 20:09:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LgZM3GYzGgUWy3XjUK801bOPMoAy3jAl5xJ+QuSCKHY=; b=quFszc5pnOwLZ7 t3VcBciyRJ52Y1lSmVHG4YCmkyePfytokOR2LsYaCtGoYatH+NtZqpm1q1lWp9S07001iUGi6PMBr vAlBrQNjk5BR3yGr3lt0OnFpx4Nw4NwbYhMscLY18KSR3nlzPyxxV0sMHokxJnPxkrr6pO/U49m9C ZgDHWFem43/PObzt2dEO9/r6DGAtzM/6v1c6FcZcnL7ZWV20NuI2pq7BTXxLNLrHSYtpZ9amJCIyF q9jzo+Y2XFLbFP9Oyuasa4P+VdOP6yCeSO39qXd41DaEYaW0NqyUumxzAvyyp9Sd8IcvqVd5m90WK 4D3saMScQmdBa2braCfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjjRm-0000000DC4J-0w1H; Tue, 14 Jul 2026 20:09:42 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjjRl-0000000DC4C-2BSa for linux-phy@lists.infradead.org; Tue, 14 Jul 2026 20:09:41 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 82B20601D9; Tue, 14 Jul 2026 20:09:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B857F1F000E9; Tue, 14 Jul 2026 20:09:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784059780; bh=pxrjdEhQ20BdCU9qiayJEDZ+LSAkaqGbClsBBdZHk/E=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=nx03Wv/dH0KAw6m9I1/bZqokrtC56pdV84qwpNrcIrsMOU+H0ktaYxefurhqH4G0m fQZTcsiz/u1SkHY1cfknu+nCIKH3I3lZ/uGtmkLqdxHcN0kPyvhJ54qtdaoLzuGmtC aBtjn1tKfVZXA9ZRtdC6H2UzVbAf1rjmiLQMlq6IYRHeFmxAOCmrFLyYZ7de0K9DNg wNKN/6e1bZj6OJmf0YKV4unzS+/KgL0z1uAM2IGu5oGkVc+eQ3JApKo8xKodv0FiGq oWP7OTK9gTHZ1uNx4kDBDcEbUUNo+wABteuQjPoV/BB1/yJcdFUIbUC8dUz5+cUExs jTFPz0WuFou0g== From: sashiko-bot@kernel.org Subject: Re: [PATCH v13 19/35] phy: rockchip: usbdp: Re-init the PHY on orientation change To: "Sebastian Reichel" Cc: neil.armstrong@linaro.org, vkoul@kernel.org, olteanv@gmail.com, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, robh@kernel.org In-Reply-To: <20260714-rockchip-usbdp-cleanup-v13-19-6cb3e769d4c5@collabora.com> References: <20260714-rockchip-usbdp-cleanup-v13-0-6cb3e769d4c5@collabora.com> <20260714-rockchip-usbdp-cleanup-v13-19-6cb3e769d4c5@collabora.com> Date: Tue, 14 Jul 2026 20:09:39 +0000 Message-Id: <20260714200939.B857F1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBUaGUgVVNCMyBwb3J0IGlzIG5vdCByZS1lbmFibGVkIGluIHRoZSBzeXN0ZW0gR1JG IHdoZW4gdGhlIFBIWSBkeW5hbWljYWxseSB0cmFuc2l0aW9ucyBmcm9tIERQLW9ubHkgdG8gRFAr VVNCIG1vZGUsIHBlcm1hbmVudGx5IGJyZWFraW5nIFN1cGVyU3BlZWQgVVNCIGZ1bmN0aW9uYWxp dHkuCi0tCgotLS0gUGF0Y2ggWzE5XTogW1BBVENIIHYxMyAxOS8zNV0gcGh5OiByb2NrY2hpcDog dXNiZHA6IFJlLWluaXQgdGhlIFBIWSBvbiBvcmllbnRhdGlvbiBjaGFuZ2UgLS0tCmNvbW1pdCBk ZDUyNTc0N2RmNDVlNTdiM2VkYzY0ZGI0NjBjMjZkZDQzNzNjM2RmCkF1dGhvcjogU2ViYXN0aWFu IFJlaWNoZWwgPHNlYmFzdGlhbi5yZWljaGVsQGNvbGxhYm9yYS5jb20+CgpwaHk6IHJvY2tjaGlw OiB1c2JkcDogUmUtaW5pdCB0aGUgUEhZIG9uIG9yaWVudGF0aW9uIGNoYW5nZQoKQ2hhbmdpbmcg dGhlIGNhYmxlIG9yaWVudGF0aW9uIHJlY29uZmlndXJlcyB0aGUgbGFuZSBtdXhpbmcsIHdoaWNo CnJlcXVpcmVzIHJlLWluaXRpYWxpemluZyB0aGUgUEhZLiBXaXRob3V0IHRoaXMgRFAgZnVuY3Rp b25hbGl0eQpicmVha3MsIGlmIHRoZSBjYWJsZSBpcyByZS1wbHVnZ2VkIHdpdGggc3dhcHBlZCBv cmllbnRhdGlvbi4KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGh5L3JvY2tjaGlwL3BoeS1yb2Nr Y2hpcC11c2JkcC5jIGIvZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJvY2tjaGlwLXVzYmRwLmMK PiBpbmRleCBlNDRkMTljOWQxMTkzLi40YjQ1NDc5OGM0ZWQ0IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvcGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hpcC11c2JkcC5jCj4gKysrIGIvZHJpdmVycy9waHkv cm9ja2NoaXAvcGh5LXJvY2tjaGlwLXVzYmRwLmMKPiBAQCAtNjIwLDYgKzYyMCw3IEBAIHN0YXRp YyBpbnQgcmtfdWRwaHlfb3JpZW5fc3dfc2V0KHN0cnVjdCB0eXBlY19zd2l0Y2hfZGV2ICpzdywK PiAgCQkJCSBlbnVtIHR5cGVjX29yaWVudGF0aW9uIG9yaWVuKQo+ICB7Cj4gIAlzdHJ1Y3Qgcmtf dWRwaHkgKnVkcGh5ID0gdHlwZWNfc3dpdGNoX2dldF9kcnZkYXRhKHN3KTsKPiArCWJvb2wgZmxp cHBlZCA9IG9yaWVuID09IFRZUEVDX09SSUVOVEFUSU9OX1JFVkVSU0U7Cj4gIAo+ICAJbXV0ZXhf bG9jaygmdWRwaHktPm11dGV4KTsKPiAgCj4gQEAgLTYzMSw3ICs2MzIsMTAgQEAgc3RhdGljIGlu dCBya191ZHBoeV9vcmllbl9zd19zZXQoc3RydWN0IHR5cGVjX3N3aXRjaF9kZXYgKnN3LAo+ICAJ CWdvdG8gdW5sb2NrX3JldDsKPiAgCX0KPiAgCj4gLQl1ZHBoeS0+ZmxpcCA9IG9yaWVuID09IFRZ UEVDX09SSUVOVEFUSU9OX1JFVkVSU0U7Cj4gKwlpZiAodWRwaHktPmZsaXAgIT0gZmxpcHBlZCkK PiArCQl1ZHBoeS0+cGh5X25lZWRzX3JlaW5pdCA9IHRydWU7CgpbU2V2ZXJpdHk6IEhpZ2hdClRo aXMgaXMgYSBwcmUtZXhpc3RpbmcgaXNzdWUsIGJ1dCBkb2VzIHNldHRpbmcgcGh5X25lZWRzX3Jl aW5pdCB0byB0cnVlIGV4cG9zZQphIGJ1ZyBpbiBya191ZHBoeV9wb3dlcl9vbigpIHdoZXJlIHRo ZSBVU0IzIHBvcnQgaXMgbm90IHJlLWVuYWJsZWQgd2hlbgp0cmFuc2l0aW9uaW5nIGZyb20gRFAt b25seSB0byBEUCtVU0IgbW9kZT8KCklmIHRoZSBUeXBlLUMgY29ubmVjdGlvbiBkeW5hbWljYWxs eSB0cmFuc2l0aW9ucyBmcm9tIERQLW9ubHkgKHdoZXJlIHRoZSBVMyBwb3J0CmlzIGRpc2FibGVk IHZpYSBya191ZHBoeV91M19wb3J0X2Rpc2FibGUodWRwaHksIHRydWUpKSB0byBEUCtVU0IKKFVE UEhZX01PREVfRFBfVVNCKSwgcmtfdWRwaHlfcG93ZXJfb24oKSB0YWtlcyB0aGlzIGJyYW5jaDoK CmRyaXZlcnMvcGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hpcC11c2JkcC5jOnJrX3VkcGh5X3Bvd2Vy X29uKCkgewogICAgLi4uCgl9IGVsc2UgaWYgKHVkcGh5LT5waHlfbmVlZHNfcmVpbml0KSB7CgkJ aWYgKHVkcGh5LT5tb2RlID09IFVEUEhZX01PREVfRFApCgkJCXJrX3VkcGh5X3UzX3BvcnRfZGlz YWJsZSh1ZHBoeSwgdHJ1ZSk7CgoJCXJldCA9IHJrX3VkcGh5X2luaXQodWRwaHkpOwogICAgLi4u Cn0KCkl0IGV4cGxpY2l0bHkgZGlzYWJsZXMgdGhlIFUzIHBvcnQgaWYgdGhlIG5ldyBtb2RlIGlz IERQLW9ubHksIGJ1dCBpdApjb21wbGV0ZWx5IGxhY2tzIHRoZSBsb2dpYyB0byByZS1lbmFibGUg dGhlIHBvcnQKKHJrX3VkcGh5X3UzX3BvcnRfZGlzYWJsZSh1ZHBoeSwgZmFsc2UpKSBpZiB0aGUg bW9kZSBpbmNsdWRlcyBVU0IuCgpDb3VsZCB0aGlzIGNhdXNlIFN1cGVyU3BlZWQgVVNCIHRyYWZm aWMgdG8gZmFpbCBiZWNhdXNlIHRoZSBVMyBwb3J0IHJlbWFpbnMKZGlzYWJsZWQgaW4gdGhlIHVz YmdyZiByZWdpc3Rlcj8KCj4gKwo+ICsJdWRwaHktPmZsaXAgPSBmbGlwcGVkOwo+ICAJcmtfdWRw aHlfc2V0X3R5cGVjX2RlZmF1bHRfbWFwcGluZyh1ZHBoeSk7Cj4gIAlya191ZHBoeV91c2JfYnZh bGlkX2VuYWJsZSh1ZHBoeSwgdHJ1ZSk7Cj4KCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRw czovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA3MTQtcm9ja2NoaXAtdXNiZHAtY2xlYW51 cC12MTMtMC02Y2IzZTc2OWQ0YzVAY29sbGFib3JhLmNvbT9wYXJ0PTE5CgotLSAKbGludXgtcGh5 IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54C0B423E8B for ; Tue, 14 Jul 2026 20:09:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784059781; cv=none; b=SFgWP0MyBmM1iN87YEYVaHDiGrTb1z/SqERgO65qCxahjW2OdJZOVimez9+ohZm0y1ovtwmJnwLPlYUsk3pCUvPGj59QiS5jIS+woJMT9EZ2Z7ZSWJEp2W1NkuoDNOHHez6IlHIkyoCNPLAkLU8gHHJIzhHlcpon2OKw4nMF0V4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784059781; c=relaxed/simple; bh=Lk6/NzUSqSKhxGY+ppBbANU+Ev4gHYoMVj48/H4QyX8=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=pCQ0EsO1SNSFTz2FMl4/nmoBslsSnIBGW4UH1VhnKLC8RI4Jo4YijZPECsT2h05ejY7VMv2jyQcOhwgMtSlTpFq3Gvdgx6ugkpFLUB8M04RSf9TG4SN/gLA+XhlibC2jNZiJidra6IpVz/DeKnqcn/i7bvfjFGtyBRAMqCYc44A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nx03Wv/d; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nx03Wv/d" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B857F1F000E9; Tue, 14 Jul 2026 20:09:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784059780; bh=pxrjdEhQ20BdCU9qiayJEDZ+LSAkaqGbClsBBdZHk/E=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=nx03Wv/dH0KAw6m9I1/bZqokrtC56pdV84qwpNrcIrsMOU+H0ktaYxefurhqH4G0m fQZTcsiz/u1SkHY1cfknu+nCIKH3I3lZ/uGtmkLqdxHcN0kPyvhJ54qtdaoLzuGmtC aBtjn1tKfVZXA9ZRtdC6H2UzVbAf1rjmiLQMlq6IYRHeFmxAOCmrFLyYZ7de0K9DNg wNKN/6e1bZj6OJmf0YKV4unzS+/KgL0z1uAM2IGu5oGkVc+eQ3JApKo8xKodv0FiGq oWP7OTK9gTHZ1uNx4kDBDcEbUUNo+wABteuQjPoV/BB1/yJcdFUIbUC8dUz5+cUExs jTFPz0WuFou0g== From: sashiko-bot@kernel.org Subject: Re: [PATCH v13 19/35] phy: rockchip: usbdp: Re-init the PHY on orientation change Reply-To: sashiko-reviews@lists.linux.dev To: "Sebastian Reichel" Cc: neil.armstrong@linaro.org, vkoul@kernel.org, olteanv@gmail.com, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, robh@kernel.org In-Reply-To: <20260714-rockchip-usbdp-cleanup-v13-19-6cb3e769d4c5@collabora.com> References: <20260714-rockchip-usbdp-cleanup-v13-0-6cb3e769d4c5@collabora.com> <20260714-rockchip-usbdp-cleanup-v13-19-6cb3e769d4c5@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 14 Jul 2026 20:09:39 +0000 Message-Id: <20260714200939.B857F1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: Pre-existing issues: - [High] The USB3 port is not re-enabled in the system GRF when the PHY dyn= amically transitions from DP-only to DP+USB mode, permanently breaking Supe= rSpeed USB functionality. -- --- Patch [19]: [PATCH v13 19/35] phy: rockchip: usbdp: Re-init the PHY on = orientation change --- commit dd525747df45e57b3edc64db460c26dd4373c3df Author: Sebastian Reichel phy: rockchip: usbdp: Re-init the PHY on orientation change Changing the cable orientation reconfigures the lane muxing, which requires re-initializing the PHY. Without this DP functionality breaks, if the cable is re-plugged with swapped orientation. > diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rock= chip/phy-rockchip-usbdp.c > index e44d19c9d1193..4b454798c4ed4 100644 > --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c > +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c > @@ -620,6 +620,7 @@ static int rk_udphy_orien_sw_set(struct typec_switch_= dev *sw, > enum typec_orientation orien) > { > struct rk_udphy *udphy =3D typec_switch_get_drvdata(sw); > + bool flipped =3D orien =3D=3D TYPEC_ORIENTATION_REVERSE; > =20 > mutex_lock(&udphy->mutex); > =20 > @@ -631,7 +632,10 @@ static int rk_udphy_orien_sw_set(struct typec_switch= _dev *sw, > goto unlock_ret; > } > =20 > - udphy->flip =3D orien =3D=3D TYPEC_ORIENTATION_REVERSE; > + if (udphy->flip !=3D flipped) > + udphy->phy_needs_reinit =3D true; [Severity: High] This is a pre-existing issue, but does setting phy_needs_reinit to true exp= ose a bug in rk_udphy_power_on() where the USB3 port is not re-enabled when transitioning from DP-only to DP+USB mode? If the Type-C connection dynamically transitions from DP-only (where the U3= port is disabled via rk_udphy_u3_port_disable(udphy, true)) to DP+USB (UDPHY_MODE_DP_USB), rk_udphy_power_on() takes this branch: drivers/phy/rockchip/phy-rockchip-usbdp.c:rk_udphy_power_on() { ... } else if (udphy->phy_needs_reinit) { if (udphy->mode =3D=3D UDPHY_MODE_DP) rk_udphy_u3_port_disable(udphy, true); ret =3D rk_udphy_init(udphy); ... } It explicitly disables the U3 port if the new mode is DP-only, but it completely lacks the logic to re-enable the port (rk_udphy_u3_port_disable(udphy, false)) if the mode includes USB. Could this cause SuperSpeed USB traffic to fail because the U3 port remains disabled in the usbgrf register? > + > + udphy->flip =3D flipped; > rk_udphy_set_typec_default_mapping(udphy); > rk_udphy_usb_bvalid_enable(udphy, true); > --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260714-rockchip-u= sbdp-cleanup-v13-0-6cb3e769d4c5@collabora.com?part=3D19