Re: [PATCH v2 08/12] perf vendor events intel: Update meteorlake events from 1.21 to 1.22

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The metric `tma_uc_bound` is referenced as a related metric in multiple `PublicDescription` fields, but it is not defined for the Meteor Lake architecture.
--

--- Patch [8]: [PATCH v2 08/12] perf vendor events intel: Update meteorlake events from 1.21 to 1.22 ---
commit cb395fd3e26bd66c71e3cfa53c9dba3acded6104
Author: Chun-Tse Shao <ctshao@google.com>

perf vendor events intel: Update meteorlake events from 1.21 to 1.22
    
The updated events were published in:
https://github.com/intel/perfmon/commit/704ef43e4c0738065a0575622cf7d31867b8d48b

> diff --git a/tools/perf/pmu-events/arch/x86/meteorlake/mtl-metrics.json b/tools/perf/pmu-events/arch/x86/meteorlake/mtl-metrics.json
> index 948c16a1f95ba..a23691052237e 100644
> --- a/tools/perf/pmu-events/arch/x86/meteorlake/mtl-metrics.json
> +++ b/tools/perf/pmu-events/arch/x86/meteorlake/mtl-metrics.json
> @@ -797,16 +797,16 @@
>      },
>      {
>          "BriefDescription": "Total pipeline cost of external Memory- or Cache-Bandwidth related bottlenecks",
> -        "MetricExpr": "100 * (tma_memory_bound * (tma_dram_bound / (tma_dram_bound + tma_l1_bound + tma_l2_bound + tma_l3_bound + tma_store_bound)) * (tma_mem_bandwidth / (tma_mem_bandwidth + tma_mem_latency)) + tma_memory_bound * (tma_l3_bound / (tma_dram_bound + tma_l1_bound + tma_l2_bound + tma_l3_bound + tma_store_bound)) * (tma_sq_full / (tma_contested_accesses + tma_data_sharing + tma_l3_hit_latency + tma_sq_full)) + tma_memory_bound * (tma_l1_bound / (tma_dram_bound + tma_l1_bound + tma_l2_bound + tma_l3_bound + tma_store_bound)) * (tma_fb_full / (tma_dtlb_load + tma_fb_full + tma_l1_latency_dependency + tma_lock_latency + tma_split_loads + tma_store_fwd_blk)))",
> +        "MetricExpr": "100 * (tma_memory_bound * (tma_l3_miss_bound / (tma_l1_bound + tma_l2_bound + tma_l3_bound + tma_l3_miss_bound + tma_store_bound)) * (tma_mem_bandwidth / (tma_mem_bandwidth + tma_mem_latency)) + tma_memory_bound * (tma_l3_bound / (tma_l1_bound + tma_l2_bound + tma_l3_bound + tma_l3_miss_bound + tma_store_bound)) * (tma_sq_full / (tma_contested_accesses + tma_data_sharing + tma_l3_hit_latency + tma_sq_full)) + tma_memory_bound * (tma_l1_bound / (tma_l1_bound + tma_l2_bound + tma_l3_bound + tma_l3_miss_bound + tma_store_bound)) * (tma_fb_full / (tma_dtlb_load + tma_fb_full + tma_l1_latency_dependency + tma_lock_latency + tma_split_loads + tma_store_fwd_blk)))",
>          "MetricGroup": "BvMB;Mem;MemoryBW;Offcore;tma_issueBW",
>          "MetricName": "tma_bottleneck_data_cache_memory_bandwidth",
>          "MetricThreshold": "tma_bottleneck_data_cache_memory_bandwidth > 20",
> -        "PublicDescription": "Total pipeline cost of external Memory- or Cache-Bandwidth related bottlenecks. Related metrics: tma_fb_full, tma_info_system_dram_bw_use, tma_mem_bandwidth, tma_sq_full",
> +        "PublicDescription": "Total pipeline cost of external Memory- or Cache-Bandwidth related bottlenecks. Related metrics: tma_fb_full, tma_info_system_dram_bw_use, tma_mem_bandwidth, tma_sq_full, tma_uc_bound",

[Severity: Low]
This isn't a bug, but this adds a reference to tma_uc_bound which doesn't
appear to be defined in the Meteor Lake JSON files. Will this cause a
dangling documentation reference for users looking up the related metrics?

(Note: This same tma_uc_bound reference is also added to the
PublicDescription fields for tma_fb_full, tma_info_system_dram_bw_use,
tma_mem_bandwidth, and tma_sq_full below).

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260714204044.1952031-1-ctshao@google.com?part=8