From: sashiko-bot@kernel.org
To: "Douglas Anderson" <dianders@chromium.org>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH 1/7] dt-bindings: mailbox: Don't require #mbox-cells to be 1
Date: Tue, 14 Jul 2026 22:32:29 +0000 [thread overview]
Message-ID: <20260714223229.EF4141F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260714152138.1.I814d768336e8de933580d467140ce340f3d4f55d@changeid>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message contains a typo and is missing the value '0' after '#mbox-cells', making the sentence incomplete and confusing.
--
--- Patch [1]: [PATCH 1/7] dt-bindings: mailbox: Don't require #mbox-cells to be 1 ---
commit 6ada1cfb4e312b11f6e334039168356fbbe9bd88
Author: Douglas Anderson <dianders@chromium.org>
dt-bindings: mailbox: Don't require #mbox-cells to be 1
This commit updates the mailbox bindings to clarify that #mbox-cells does
not need to be strictly 1, allowing 0 when a mailbox only provides one
channel.
Link: https://lore.kernel.org/all/20260322-mailbox-v1-1-c6251f18187c@gmail.com/
> Existing mailboxes have #mbox-cells and this makes sense if a mailbox
> only exposes one channel. Update the bindings to match.
[Severity: Low]
This isn't a bug, but is this sentence missing the value 0 after #mbox-cells?
It currently reads as though the intended value was omitted, which makes the
description slightly confusing.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260714222338.2965707-1-dianders@chromium.org?part=1
next prev parent reply other threads:[~2026-07-14 22:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 22:21 [PATCH 0/7] mailbox: Improve the mbox core then introduce the goog-mba driver Douglas Anderson
2026-07-14 22:21 ` [PATCH 1/7] dt-bindings: mailbox: Don't require #mbox-cells to be 1 Douglas Anderson
2026-07-14 22:32 ` sashiko-bot [this message]
2026-07-14 22:21 ` [PATCH 2/7] mailbox: Allow #mbox-cells = <0> without specifying a custom xlate Douglas Anderson
2026-07-14 22:21 ` [PATCH 3/7] mailbox: Find a matching mailbox by fwnode rather than device Douglas Anderson
2026-07-14 22:21 ` [PATCH 4/7] mailbox: Simplify circular queue math with mod arithmetic Douglas Anderson
2026-07-14 22:21 ` [PATCH 5/7] mailbox: Add support for mailbox controllers that can queue Douglas Anderson
2026-07-14 22:21 ` [PATCH 6/7] dt-bindings: mailbox: goog-mba: Add goog-mba mailbox bindings Douglas Anderson
2026-07-15 4:51 ` Krzysztof Kozlowski
2026-07-15 16:49 ` Doug Anderson
2026-07-16 5:46 ` Krzysztof Kozlowski
2026-07-16 16:31 ` Doug Anderson
2026-07-14 22:21 ` [PATCH 7/7] mailbox: goog-mba: Introduce the goog-mba mailbox driver Douglas Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260714223229.EF4141F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.