From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24CEB370ADA for ; Tue, 14 Jul 2026 23:46:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784072774; cv=none; b=jzLYbvn7CRcCMJLumq40SVbmhsZPfOiHrR0+HyrOFIYSUDGilLzqYM4WRnsGxsZYiCSO6nWY4OxfS1dQmDTUFSHmN87BRu8tGpYvCLwb6LcIK6gqxK/Wn2/zfiOgUhkXMg/W8XRlNct/GOCloprhAO9hehqgNjVkLu13txCHF8g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784072774; c=relaxed/simple; bh=xz5rGf8Wc+mjpEoKjw/Hm6IDCdOr4kMxjrR6BxaTuSo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qs0OXfJuThau7G8caZ0PAs54JM1xsJGMp024WR8uoU9ZAq02mDN6sGLpNP5ynKXLUjrV3JeXeUYBE5Kcw0WTPQnX84SZpvu57IPWjPQx5DmrvfUij3Zl7Y8hhueJ9ycNVfuwQFHRWIyGSGcnYb0xyCGghoNsdkq8L0VQbTiKyP8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Gd/wrKym; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gd/wrKym" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c9d1fc053e0so1335176a12.1 for ; Tue, 14 Jul 2026 16:46:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784072772; x=1784677572; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=kzUE7I1k14QX134cx6l+OWLqB5vco662yBKK277qQ00=; b=Gd/wrKymvElJKI56wQhmD2n+Dtck8hRrmJaPoOG6DSWUVoDGkk6HZjAkAvb1246wdR b3hPicL4wBhwg8iL+feR6t2kmIguhEPk2M65+B8+4TPamnY+81+6eM2aFx3NllbnPHf8 MjctkJ/Sh7kvzLmwPfxpPSbVJfgKdd9sN7pYV+VGnSkRgXGQz3Sy4RaYvbtgv7swuNsH knUzEBz0kiwKnj2+mkQZmKDfOdVERGcSimimoYxdlJNCRIHMt06ktXwJWAoAwKbHgY/Z OK3C3CkJ0RRsS/3Wh3wrxHIxxOWZPx6UMIvaw3+7UlJ9PWlmAG0yJCurE0GksaYp7R4S K5Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784072772; x=1784677572; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kzUE7I1k14QX134cx6l+OWLqB5vco662yBKK277qQ00=; b=Dy9ZZ5a1tktwZaM3faVHDYdb3YUQWTz3QsEfXUMmOq54CX6Ej/jvgaY7ViwsJqozIO qLSte+S7PvKCJJFHZ3Ci4jjns3JsggGLJI4f6zrLQn+9GQB8TRccq6TGUlberfR6smL0 AQfhNhiNrHumQhDCwEKJbkaRm3ybttPgOa+BjQHeVtdpz2RP4CLx3dzKGSwuLj+rMqCa QDYqIXJee0g2oFbmaa+F7uMghre9EXatDxxxTuu4IoPKQzlXHTXDBH6K1mKpsn1g5CUf zW99av7FUBLGw/FGX64vZq7axpmnt58sD+cydvP14VwXtgroUtFQxFAs5Bzx/2ur/heL hr3Q== X-Forwarded-Encrypted: i=1; AHgh+RoCPABDMkKIytbST1vyCcYzNRQrIXkXJB9nCx5zphzqynmAsynhnI/pyPR/Vz6swGTwy2M=@lists.linux.dev X-Gm-Message-State: AOJu0Yw/+GZPa+0K+Nok3BcJdyiN3i2bAUyOHPIBu+eEcGA+Juq/Zrrn v7PVYNcgb2e4H54VuFmRvYFwv4HkC/M9Vep+hi18khexfT2bQvWl7do/ X-Gm-Gg: AfdE7cmxOQyBsBxR7QXdJFIWmsadS6dmah+R3fwiDA52Hwxvm4aLQf1CfddFXDtOz2r mP2m72ssYOJMbVFfiu+AseCoYXmVF7l7/CLZ3EyHXHOb6WWzwmDrO59hc01QRltHwAwVZpSYRYx bgksrjnWlleqLbm+0B9Mb052QU873gdVv+Ed+vQZHMgrZ//WxRFgvDBFOIdE/nHfz75wCsneWFc Uq6Z4pGf2ddDXkVrPvtnRM4uSbq3Mx2ZgvaTddG/7xhp6BI4ZrNoVqA3mvrMa83SC18wJ1L9IuF eWIfPeM2dAfAV7J4zmA6LoFAWJvxlH21wjrtr47IioliKqzlbj+a674yhTDJc/60jkKdVjrCEAs tYewBTxKZ5gGcZmpt6ascKEPVqz4X1fmPUhlA0GBYIMlYpp0n8rXu2nzNBkKnGHSFSmwN1GPxEs K4J0P0ZTNsETC/mvsJBHcI+KfnsCBRpPJda9bqy4I4IBzvTvIb0sn0OCsfMJDMrNL0HU4oLy6Bh 4pg4gmj3tzMoSGP9IEIq3XxS9X22P74LKWH8LQAYauvTqxCSmDKIOurBHjjrQKLrdOlKigq3ORP X-Received: by 2002:a05:6a20:3d0c:b0:3c0:9c1b:d0be with SMTP id adf61e73a8af0-3c110a24bb4mr17834018637.73.1784072772474; Tue, 14 Jul 2026 16:46:12 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e34]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3643399sm10988858a12.22.2026.07.14.16.46.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 16:46:11 -0700 (PDT) From: Rosen Penev To: linux-edac@vger.kernel.org Cc: Frank Li , Borislav Petkov , Tony Luck , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , imx@lists.linux.dev (open list:EDAC-FSL_DDR), linux-kernel@vger.kernel.org (open list), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCH] EDAC: fsl_ddr: use devm_platform_ioremap_resource() Date: Tue, 14 Jul 2026 16:46:09 -0700 Message-ID: <20260714234609.902367-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the open-coded of_address_to_resource() plus devm_request_mem_region() and devm_ioremap() sequence with devm_platform_ioremap_resource(), which folds the resource lookup, region reservation and mapping into one step and returns an ERR_PTR checked with IS_ERR()/PTR_ERR(). Behaviorally equivalent with respect to region reservation: the driver already reserved the region, so the non-overlapping reg requirement was already satisfied. Drop the now-unused linux/of_address.h include. Built for arm64 (defconfig + CONFIG_EDAC_FSL_DDR) with LLVM=1; drivers/edac/fsl_ddr_edac.o compiles cleanly. Assisted-by: opencode:hy3-free Signed-off-by: Rosen Penev --- drivers/edac/fsl_ddr_edac.c | 30 ++++++------------------------ 1 file changed, 6 insertions(+), 24 deletions(-) diff --git a/drivers/edac/fsl_ddr_edac.c b/drivers/edac/fsl_ddr_edac.c index b27dff96aeb6..ae1d54434e38 100644 --- a/drivers/edac/fsl_ddr_edac.c +++ b/drivers/edac/fsl_ddr_edac.c @@ -22,7 +22,6 @@ #include #include -#include #include "edac_module.h" #include "fsl_ddr_edac.h" @@ -495,11 +494,15 @@ int fsl_mc_err_probe(struct platform_device *op) struct mem_ctl_info *mci; struct edac_mc_layer layers[2]; struct fsl_mc_pdata *pdata; - struct resource r; + void __iomem *mc_vbase; u32 ecc_en_mask; u32 sdram_ctl; int res; + mc_vbase = devm_platform_ioremap_resource(op, 0); + if (IS_ERR(mc_vbase)) + return PTR_ERR(mc_vbase); + if (!devres_open_group(&op->dev, fsl_mc_err_probe, GFP_KERNEL)) return -ENOMEM; @@ -531,28 +534,7 @@ int fsl_mc_err_probe(struct platform_device *op) * Default is big endian. */ pdata->little_endian = of_property_read_bool(op->dev.of_node, "little-endian"); - - res = of_address_to_resource(op->dev.of_node, 0, &r); - if (res) { - pr_err("%s: Unable to get resource for MC err regs\n", - __func__); - goto err; - } - - if (!devm_request_mem_region(&op->dev, r.start, resource_size(&r), - pdata->name)) { - pr_err("%s: Error while requesting mem region\n", - __func__); - res = -EBUSY; - goto err; - } - - pdata->mc_vbase = devm_ioremap(&op->dev, r.start, resource_size(&r)); - if (!pdata->mc_vbase) { - pr_err("%s: Unable to setup MC err regs\n", __func__); - res = -ENOMEM; - goto err; - } + pdata->mc_vbase = mc_vbase; if (pdata->flag == TYPE_IMX9) { pdata->inject_vbase = devm_platform_ioremap_resource_byname(op, "inject"); -- 2.55.0