From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01363318EFF for ; Wed, 15 Jul 2026 01:13:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784078028; cv=none; b=DsLGUed0zYoovRo0uxYJD6EVA6hdjE0CM9t2arjVoI9ipTTV9hWtfjW5w5G9uDZregxEWaDEUYo3E4qVrj5EHHVlYXtKbnUSPjN1HWzSlybyVwys2Z3ZIuI11dvFBqb43JhW8g2xLRJL106S1ZJuO000oGgA6/ehmd2meOhFJ9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784078028; c=relaxed/simple; bh=P43JCHOf5w5P2ZjP5fROoPb0nb32cDjMMB3GL/AOF+M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jXAJWGSUCV8flChapopJeu7rI5upHNQ0ePcOxNKE6eJe9UsCwnCP5leWvzmKC8uW+IvEsUSQuEstq5ckiCTJ3sKHXw6C2WmggoZCtgMZpXIJFtQlDARU89ADJC5kXE498eQCZJqm9N8EdExdSilnl4Hd/Y5a59ushwzRIvwN3p0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qGIpM0iT; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qGIpM0iT" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-385ea3ce80dso5078083a91.2 for ; Tue, 14 Jul 2026 18:13:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784078026; x=1784682826; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=LIHLfJs4cYwuricbvRyPu6UapQ2vEVELHf2OcqtSJ/8=; b=qGIpM0iT4+66WN0u/ooEU8xUjwwXklXS6NF8gzEFlB7VmQcavJS0FmrHTf/E21XwL3 DL3+2gw8lELuqPWnBuiIlI16vFAFOK7yZUmRdWnhPPGpybpdtuhxD+zJk6N7lBlh/Bw0 TnBnhh0UUj+Q0b+oe8oEfbJY5NUuLW+LYDgUH94cydeYXulfQhgM1qscq/qGJpIGplFk xzI4XC4YtAwtJt3aif0UTMXo9eH0WTSEn/X+gK7sLYq240MfMkmfA7KM1zzqy6AD0aj0 S0vFqgdyzwNw7qF8GI+dIhsLM2gSZzNA+txMaoCiivwpqL2FMOyi87elET3N89jJEPeM l9KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784078026; x=1784682826; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LIHLfJs4cYwuricbvRyPu6UapQ2vEVELHf2OcqtSJ/8=; b=tJz0JcwCG8UDtRBZlbEtk+4OI7LLEwUN15ADh5U1y3fEIyD0mS0J07a3bYaIL2GHC8 MHLUupx3HWOF+1BNhlS7pncpY0RPVDPERe6VfakVkmmefu/cRtFJY/J1uOaGSKIDs+Pb uGS2s5t1MxtxTkk4ry0kqDXtF/Okt/ANFU17l8hi5QmlXS0FuzWPQntrxYYMopvzBmLC zkI8Z0+Q6b2pb6q4rAxSFcHMthh+Q6vk8Yugm1lqwAFkyZVtCg4hLTaPA6XeiYnVRJcf UcO/CtQ0bpk3tkBz6LiAm6Py1C5U43HfMgx+6caMQ3kjqaLvtkcDYxEUzbzwZh7cfq08 bo6A== X-Forwarded-Encrypted: i=1; AHgh+RrcLHFU999Wm9c4LRkn+elkBDeN2rg8whJGQL0vyW/CzbsqLbBtvW5zDaXaOVit3nUYR+A/wcZ+iApQgMA=@vger.kernel.org X-Gm-Message-State: AOJu0YwyPq8Wrfs8pdmXESOZM5baqPIsMQqeyMfjC0yJ0rRdyilEYRw8 ubn1jOOdHuztRAeVKtnbU6cfvHBdyT4HjXkvZzU2JLzJ+LSVbWJ1BTx5ymPq4g== X-Gm-Gg: AfdE7cl0l2pHnDsKYYJuaRUz88kJq94yYgJuz7r1nUdxKk3Mn0XBMJEm0H577QL9OQ2 55p4BwgF0qGh1kMZbDMpzEvt80ZlUBDJgJD6xphA8unpWH1Mu6ETKmL/qLYZ4rNOr0dVIqN6hEr yLrUmLIeH4+p7bUgv+VUeJQ5ET5Xnn4jGlFH1VFZT+P62hki6V6TAUk1uOnwTLxqVWz5n+TBjZp VFzZ2NLqyIoE0Q+EUV0EzikKHhaCYHPb0E09ljhFEx07S3gyMnl0yQGhHaMoCcsXvt390VaonZS mUFGiqrUj2OqfgTPKMCqmg64fBzNCLsmE0UO07R+gXaDnJvnO+1VrHDxYaJAw5QdtiVjrFnQD8h FTALPN+mkN/3fF2d7onbhxtSeEy2hL8mtcx+rxPlKku6AT55nK9EEc6JCSeryE6JSbgj7GJgsfK 6C21ts/KEwUV0KN0/pHHG8107eewe2rX29zb3Ajce3jMY6BQdiKv+uHHNUgqatd/3kbVgehRB3j Y1ZRpibzksnz0DjdsGrVwkAh4kdRiHHnWUX0RvO4mVyKB9+EeaURy4GOI2byYYk0ME7viSfnYoP X-Received: by 2002:a17:90b:534d:b0:387:e0cb:7f6 with SMTP id 98e67ed59e1d1-38e17fabbd6mr5420793a91.42.1784078026383; Tue, 14 Jul 2026 18:13:46 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e34]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e1730acfesm2185900a91.14.2026.07.14.18.13.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 18:13:45 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org (open list), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCH] ata: pata_pxa: use devm_platform_ioremap_resource Date: Tue, 14 Jul 2026 18:13:43 -0700 Message-ID: <20260715011343.1270261-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the open-coded platform_get_resource() plus devm_ioremap() sequences for the CMD and CTL ports with devm_platform_ioremap_resource(), which fetches the resource, requests the region and maps it in one call. Switch the error checks to IS_ERR()/PTR_ERR() accordingly and drop the now-unused cmd_res and ctl_res variables. The DMA port keeps using devm_ioremap() as its resource is IORESOURCE_DMA. The CMD (res 0) and CTL (res 1) MEM resources are disjoint in the ATA task-file layout, so the added region reservation in devm_ioremap_resource() does not introduce overlap failures. Built for ARM (drivers/ata/pata_pxa.o) with LLVM=1. Assisted-by: opencode:hy3-free Signed-off-by: Rosen Penev --- drivers/ata/pata_pxa.c | 30 ++++++------------------------ 1 file changed, 6 insertions(+), 24 deletions(-) diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c index 9f63bdfb8576..c816997dc0a9 100644 --- a/drivers/ata/pata_pxa.c +++ b/drivers/ata/pata_pxa.c @@ -161,8 +161,6 @@ static int pxa_ata_probe(struct platform_device *pdev) struct ata_host *host; struct ata_port *ap; struct pata_pxa_data *data; - struct resource *cmd_res; - struct resource *ctl_res; struct resource *dma_res; struct pata_pxa_pdata *pdata = dev_get_platdata(&pdev->dev); struct dma_slave_config config; @@ -181,20 +179,6 @@ static int pxa_ata_probe(struct platform_device *pdev) return -EINVAL; } - /* - * CMD port base address - */ - cmd_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (unlikely(cmd_res == NULL)) - return -EINVAL; - - /* - * CTL port base address - */ - ctl_res = platform_get_resource(pdev, IORESOURCE_MEM, 1); - if (unlikely(ctl_res == NULL)) - return -EINVAL; - /* * DMA port base address */ @@ -221,14 +205,12 @@ static int pxa_ata_probe(struct platform_device *pdev) ap->pio_mask = ATA_PIO4; ap->mwdma_mask = ATA_MWDMA2; - ap->ioaddr.cmd_addr = devm_ioremap(&pdev->dev, cmd_res->start, - resource_size(cmd_res)); - if (!ap->ioaddr.cmd_addr) - return -ENOMEM; - ap->ioaddr.ctl_addr = devm_ioremap(&pdev->dev, ctl_res->start, - resource_size(ctl_res)); - if (!ap->ioaddr.ctl_addr) - return -ENOMEM; + ap->ioaddr.cmd_addr = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(ap->ioaddr.cmd_addr)) + return PTR_ERR(ap->ioaddr.cmd_addr); + ap->ioaddr.ctl_addr = devm_platform_ioremap_resource(pdev, 1); + if (IS_ERR(ap->ioaddr.ctl_addr)) + return PTR_ERR(ap->ioaddr.ctl_addr); ap->ioaddr.bmdma_addr = devm_ioremap(&pdev->dev, dma_res->start, resource_size(dma_res)); if (!ap->ioaddr.bmdma_addr) -- 2.55.0