Re: [PATCH 2/3] clk: qcom: tcsrcc-x1e80100: Migrate to clk_ref helper

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch relies on an undeclared structure, an undeclared function, and a non-existent header file, which will cause a fatal build error.
--

--- Patch [2]: [PATCH 2/3] clk: qcom: tcsrcc-x1e80100: Migrate to clk_ref helper ---
commit c9be5146280c763b773fd80f0650fab3bbb0c928
Author: Qiang Yu <qiang.yu@oss.qualcomm.com>

clk: qcom: tcsrcc-x1e80100: Migrate to clk_ref helper

Replaces local clk_branch-based clkref definitions with descriptor-based
registration via qcom_clk_ref_probe(). This simplifies the driver to
focus on metadata and reuses common runtime logic.

> diff --git a/drivers/clk/qcom/tcsrcc-x1e80100.c b/drivers/clk/qcom/tcsrcc-x1e80100.c
> index 0b05c27b619b6..ad1f6be83a53e 100644
> --- a/drivers/clk/qcom/tcsrcc-x1e80100.c
> +++ b/drivers/clk/qcom/tcsrcc-x1e80100.c
> @@ -5,252 +5,141 @@
>   */
>  
>  #include <linux/clk-provider.h>
> +#include <linux/clk/qcom.h>

[Severity: Low]
Does this header exist in the kernel tree? It appears that <linux/clk/qcom.h>
is missing, which will cause a fatal build error.

>  #include <linux/module.h>
> +#include <linux/of.h>

[ ... ]

> +static const struct regmap_config tcsr_cc_x1e80100_regmap_config = {
> +	.reg_bits = 32,
> +	.reg_stride = 4,
> +	.val_bits = 32,
> +	.max_register = 0x2f000,
> +	.fast_io = true,
> +};
>  
> +static const struct qcom_clk_ref_desc * const tcsr_cc_x1e80100_clk_descs[] = {

[Severity: Low]
Since the header is missing, is struct qcom_clk_ref_desc defined anywhere?
This seems to also cause a build error.

> +	[TCSR_EDP_CLKREF_EN] = &(const struct qcom_clk_ref_desc) {
> +		.name = "tcsr_edp_clkref_en",

[ ... ]

>  static int tcsr_cc_x1e80100_probe(struct platform_device *pdev)
>  {
> -	return qcom_cc_probe(pdev, &tcsr_cc_x1e80100_desc);
> +	return qcom_clk_ref_probe(pdev, &tcsr_cc_x1e80100_regmap_config,
> +				  tcsr_cc_x1e80100_clk_descs,
> +				  ARRAY_SIZE(tcsr_cc_x1e80100_clk_descs));

[Severity: Low]
Is qcom_clk_ref_probe() declared elsewhere? It seems to be missing along with
the header and the struct definition. Should there be a prerequisite patch
introducing these helpers?

>  }
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260714-hamoa_tcsr_qref_0714_2-v1-0-13047922a376@oss.qualcomm.com?part=2