From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sendmail.purelymail.com (sendmail.purelymail.com [34.202.193.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB4ED3B27E2 for ; Wed, 15 Jul 2026 03:55:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=34.202.193.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784087710; cv=none; b=fO1TJQYoKMkk2GZ046ixLxqNlJeteqGBUZc4cN3BNKj2jdqVQJKUCPOFRkFam9LtOo5lukexj7GzJlmtDni0An1tI0EIVzIK7tjwzVo6ZwCLVAvvlrNk6NY8Depr629ejP4OUzE27sU+r3uRQRIEBt7HKtKP5br4WBNsLITilMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784087710; c=relaxed/simple; bh=V3l0vRaNsb+KxcFpVRCPW94I6B8ykPoj+jjgvioMF+U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FOLDf9yhiEHFx1qioQkRnWv/bfgFQATh5oSCabotIwoy6EMHkS5RWPe1ace5TSamNSM36R0Me34BzuhvoYvApdGTb+mEmggROSr8JiYpz1X7m126ZtNm8UVZuFwFehzgYZhbgJQyoZPfwROGROMmNWQPSKxPDjoWx5367VHcQsg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=malon.dev; spf=pass smtp.mailfrom=malon.dev; dkim=pass (2048-bit key) header.d=malon.dev header.i=@malon.dev header.b=DqFUkwpp; dkim=pass (2048-bit key) header.d=purelymail.com header.i=@purelymail.com header.b=RO4ngr4W; arc=none smtp.client-ip=34.202.193.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=malon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=malon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=malon.dev header.i=@malon.dev header.b="DqFUkwpp"; dkim=pass (2048-bit key) header.d=purelymail.com header.i=@purelymail.com header.b="RO4ngr4W" Authentication-Results: purelymail.com; auth=pass DKIM-Signature: a=rsa-sha256; b=DqFUkwppUW3enCfkOXACFYv/3Egq1ppbV7gDoiyFeAaQJoyTwB0FmGONAls6slpFea1yN/eckhzmbJTe5EjQxaVlp0eAUCPCMeY/a7+9vCopsnM74r4+H/qhUpozyuaCQVCbitWIjREk00HbaLOqWyVPMYec+STiZYwwNVach8IXxlV3iuJk3VQjoVpLkjtGzCm+4arh/V4AaS1d9oQO8TYw07WHxtUMslSnnyvHGQxsMmQFuXVwgXmlouviqP+G0R6K+BDWZbLob6PpwX3Qn6fkWNmYCUNuve5G0AF7jIGZzIzwD184eTl0MgNNIHLpulw3APgGuXcGj1wXK9VXdA==; s=purelymail1; d=malon.dev; v=1; bh=V3l0vRaNsb+KxcFpVRCPW94I6B8ykPoj+jjgvioMF+U=; h=Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=RO4ngr4WqJvPZqj/23oXwnvprtrOqavh9A/J/I15OCsGOtCroazatGhsYXid8qdbhhRXM+aqaPTxXVJgUH2zZd+hS1X5kfhSfq9alL3NawY1pjD+LiLUT3jKOG5SU0oPL2YTVjr3PGQQMLyp19iFJGyXufgYlDtXNcHbNntGmDteF8mFia6+7ztTgAVuSjA2eTUTmTNmK9No+QI9vDyQbu95Bifo4VomYHqEHUn8CHv1bf0sIS039zq0Q0CBAGbjXIF9uVo/JvqcUROgJPbI4zHNRahbc3nVdqIx7KADYZOw3xSJ9gW/gSXdH4Ft6HB9mdb38Q5i9Os6D/7TYmyJug==; s=purelymail1; d=purelymail.com; v=1; bh=V3l0vRaNsb+KxcFpVRCPW94I6B8ykPoj+jjgvioMF+U=; h=Feedback-ID:Received:From:To:Subject:Date; Feedback-ID: 599969:32685:null:purelymail X-Pm-Original-To: git@vger.kernel.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1876003495; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 15 Jul 2026 03:55:06 +0000 (UTC) From: Tian Yuchen To: git@vger.kernel.org Cc: ps@pks.im, cirnovskyv@gmail.com, Tian Yuchen Subject: [PATCH v5 0/4] environment: migrate 'trust_executable_bit' and 'has_symlinks' into 'repo_config_values' Date: Wed, 15 Jul 2026 11:54:57 +0800 Message-ID: <20260715035501.48271-1-cat@malon.dev> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260619162105.648495-1-cat@malon.dev> References: <20260619162105.648495-1-cat@malon.dev> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by Purelymail Content-Type: text/plain; charset=UTF-8 This series moves 'trust_executable_bit' and 'has_symlinks' into 'struct repo_config_values' to tie them to the specific repository instance they were read from. Eager parsing is maintained because these two flags are heavily consulted in hot paths. Note: 'repo_config_values()' still does not support any struct repository other than the_repository due to how deeply these flags are accessed. In other words, this series of patches is laying the groundwork for the eventual elimination of the_repository. Previous related work: [PATCH 2/6] config: add trust_executable_bit to global config [1] [PATCH] Refactor 'trust_executable_bit' to repository-scoped setting [2] (This previous attempt was unsuccessful because the target location selected was 'struct repo_settings', which our analysis indicated was not the optimal choice. For further details, please see: [3]) [PATCH 5/6] config: move has_symlinks [4] RFC: - I wonder if there is a better way to deal with compat/mingw.c in commit 4/4. Is it possible not to introduce a fallback variable? Change since V4: - the migration of has_symlinks is back [5], as a commit 4/4; - drop the comment for repo_executable_bit(); - do not always pass the_repository to the getters. Use 'repo' when possib= le.=20 Thanks! [1] https://lore.kernel.org/git/837b5360b40f992351f489a0ae05fedf49884c6e.16= 85716420.git.gitgitgadget@gmail.com/ [2] https://lore.kernel.org/git/20260301190017.53539-1-dronarajgyawali@gmai= l.com/ [3] https://lore.kernel.org/git/xmqq1pht6nyx.fsf@gitster.g/ [4] https://lore.kernel.org/git/a154008619790f7a60f2bba91db7b0fe29e67e1a.16= 85716420.git.gitgitgadget@gmail.com/ [5] https://lore.kernel.org/git/xmqq7bokebct.fsf@gitster.g/ Tian Yuchen (4): read-cache: remove redundant extern declarations read-cache: move 'ce_mode_from_stat()' to 'read-cache.c' environment: move trust_executable_bit into repo_config_values environment: move has_symlinks into repo_config_values apply.c | 4 ++-- combine-diff.c | 2 +- compat/mingw.c | 7 ++++--- entry.c | 2 +- environment.c | 28 ++++++++++++++++++++++++---- environment.h | 9 +++++++-- read-cache.c | 33 ++++++++++++++++++++++++++------- read-cache.h | 16 ++-------------- 8 files changed, 67 insertions(+), 34 deletions(-) --=20 2.43.0