Re: [RESEND PATCH v7 02/16] arm64: dts: st: add power-domains to sdmmc1 on stm32mp231

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Incomplete fix: missing `power-domains` property in `sdmmc1` for `stm32mp251.dtsi`
--

--- Patch [2]: [RESEND PATCH v7 02/16] arm64: dts: st: add power-domains to sdmmc1 on stm32mp231 ---
commit 769d56084241db8b67f4b5d03d7c0c7f1c901c53
Author: Dario Binacchi <dario.binacchi@amarulasolutions.com>

arm64: dts: st: add power-domains to sdmmc1 on stm32mp231

This commit adds the missing power-domains property to the sdmmc1 node in
stm32mp231.dtsi to map the power domain that was missed during early bring-up.

> diff --git a/arch/arm64/boot/dts/st/stm32mp231.dtsi b/arch/arm64/boot/dts/st/stm32mp231.dtsi
> index 9e1d240888ff2..0feb8943efae6 100644
> --- a/arch/arm64/boot/dts/st/stm32mp231.dtsi
> +++ b/arch/arm64/boot/dts/st/stm32mp231.dtsi
> @@ -727,6 +727,7 @@ sdmmc1: mmc@48220000 {
>  				cap-mmc-highspeed;
>  				max-frequency = <120000000>;
>  				access-controllers = <&rifsc 76>;
> +				power-domains = <&cluster_pd>;

[Severity: High]
This isn't a bug introduced by this patch, but should the same power-domains
property be added to sdmmc1 in arch/arm64/boot/dts/st/stm32mp251.dtsi?

Looking at sdmmc1 in stm32mp251.dtsi:

			sdmmc1: mmc@48220000 {
				compatible = "st,stm32mp25-sdmmc2", "arm,pl18x", "arm,primecell";
				arm,primecell-periphid = <0x00353180>;
				reg = <0x48220000 0x400>, <0x44230400 0x8>;
				interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>;
				clocks = <&rcc CK_KER_SDMMC1 >;
				clock-names = "apb_pclk";
				resets = <&rcc SDMMC1_R>;
				cap-sd-highspeed;
				cap-mmc-highspeed;
				max-frequency = <120000000>;
				access-controllers = <&rifsc 76>;
				status = "disabled";
			};

It appears to suffer from the same omission described in the commit message.

If a board includes stm32mp251.dtsi, enables sdmmc1, and the kernel attempts
to probe the controller while its power domain is off, could this cause a
synchronous external abort or kernel panic?

>  				status = "disabled";
>  			};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260715062201.3599458-1-dario.binacchi@amarulasolutions.com?part=2