Re: [PATCH v3 1/2] dt-bindings: iio: adc: add maxim,max40080

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `shunt-resistor-micro-ohms` property is missing from the `required` list, allowing incomplete hardware descriptions to pass validation.
--

--- Patch [1]: [PATCH v3 1/2] dt-bindings: iio: adc: add maxim,max40080 ---
commit 102dd7d43e2e646eee1b098788f579fc92431947
Author: Stefan Popa <stefan.popa@analog.com>

dt-bindings: iio: adc: add maxim,max40080

This commit adds device tree bindings for the Maxim MAX40080 bidirectional
current-sense amplifier. It defines the required and optional properties for
the device, including an integrated 12-bit ADC and an I2C/SMBus interface.

> diff --git a/Documentation/devicetree/bindings/iio/adc/maxim,max40080.yaml b/Documentation/devicetree/bindings/iio/adc/maxim,max40080.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/maxim,max40080.yaml

[ ... ]

> +  shunt-resistor-micro-ohms:
> +    description:
> +      Value of the current-sense shunt resistor connected between the IN+ and
> +      IN- inputs. Used to scale the reported current.
> +
> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply

[Severity: Medium]
Should shunt-resistor-micro-ohms be added to this required list?

Without this property, the schema will silently pass incomplete hardware
descriptions during a dt_binding_check run. A current-sense amplifier
requires a shunt resistor value to correctly scale the measured voltage
drop into a current measurement.

> +
> +additionalProperties: false

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260715063652.368501-1-stefan.popa@analog.com?part=1