Re: [PATCH v6 4/8] KVM: arm64: Move PSCI helper functions to a shared header

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The header `include/kvm/arm_psci.h` is not self-contained because it uses `vcpu_set_reg()` and `vcpu_get_reg()` without including `<asm/kvm_emulate.h>`.
--

--- Patch [4]: [PATCH v6 4/8] KVM: arm64: Move PSCI helper functions to a shared header ---
(Note: The format of this report has been altered to a free-form summary without direct patch quotation due to automated system recitation restrictions.)

commit 41ab99d154503d49e14931a3e9bb6c067e760b44
Author: Fuad Tabba <fuad.tabba@linux.dev>

KVM: arm64: Move PSCI helper functions to a shared header

This patch moves several PSCI helper functions out of psci.c and into the
shared include/kvm/arm_psci.h header. It renames the file-local
psci_affinity_mask() to kvm_psci_affinity_mask() to support follow-up work
for protected-guest PSCI calls.

[Severity: Low]
In the newly moved kvm_psci_narrow_to_32bit() function within
include/kvm/arm_psci.h, the code makes use of vcpu_set_reg() and
vcpu_get_reg(). Does this new header location need an explicit include
for asm/kvm_emulate.h to ensure it remains self-contained?

If a C file includes kvm/arm_psci.h without having already included
asm/kvm_emulate.h, it looks like it might lead to a build failure due to
missing function declarations.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260715081238.1891918-1-fuad.tabba@linux.dev?part=4