Re: [PATCH v5 01/16] device property: Add fwnode_graph_get_port_by_id()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch adds two conflicting declarations for `fwnode_graph_get_port_by_id` in `include/linux/property.h`, which will break the build.
--

--- Patch [1]: [PATCH v5 01/16] device property: Add fwnode_graph_get_port_by_id() ---
commit 88979df4c2fc6de15d7726e00adc783bff896bbd
Author: Chen-Yu Tsai <wenst@chromium.org>

device property: Add fwnode_graph_get_port_by_id()

This commit introduces a helper function to retrieve a reference to a port 
firmware node by its ID. It includes a flags parameter to allow callers to 
specify whether incomplete ports should be returned.

[ ... ]
> diff --git a/include/linux/property.h b/include/linux/property.h
> index 14c304db46648..480ba8646bcc8 100644
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
> @@ -505,6 +505,9 @@ int fwnode_get_phy_mode(const struct fwnode_handle *fwnode);
>  
>  void __iomem *fwnode_iomap(struct fwnode_handle *fwnode, int index);
>  
> +struct fwnode_handle *fwnode_graph_get_port_by_id(struct fwnode_handle *fwnode, u32 id);
> +struct fwnode_handle *fwnode_graph_get_port_by_id(struct fwnode_handle *fwnode, u32 id,
> +						  unsigned long flags);

[Severity: Low]
Does this cause a build failure? It looks like there are two conflicting 
declarations for fwnode_graph_get_port_by_id() with different signatures. 
Since C doesn't support function overloading, will this result in a 
'conflicting types' compilation error when the header is included?

>  struct fwnode_handle *fwnode_graph_get_next_endpoint(
>  	const struct fwnode_handle *fwnode, struct fwnode_handle *prev);
>  struct fwnode_handle *

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260715085348.3457359-1-wenst@chromium.org?part=1