From: sashiko-bot@kernel.org
To: "Janne Grunau" <j@jannau.net>
Cc: robh@kernel.org, linux-watchdog@vger.kernel.org,
devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 05/10] dt-bindings: power: apple,pmgr-pwrstate: Add t6030 and t6031 compatibles
Date: Wed, 15 Jul 2026 09:17:59 +0000 [thread overview]
Message-ID: <20260715091800.661C21F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260715-apple-t603x-initial-devices-v2-5-df65b2485710@jannau.net>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message incorrectly duplicates 'apple,t6030-pmgr-pwrstate' when explaining the new compatible strings.
--
--- Patch [5]: [PATCH v2 05/10] dt-bindings: power: apple,pmgr-pwrstate: Add t6030 and t6031 compatibles ---
commit 0f321dd30362858c61b0d6995914cf56752d651f
Author: Janne Grunau <j@jannau.net>
dt-bindings: power: apple,pmgr-pwrstate: Add t6030 and t6031 compatibles
This commit adds "apple,t6030-pmgr-pwrstate" and "apple,t6031-pmgr-pwrstate"
compatible strings for Apple M3 Pro, Max, and Ultra SoCs.
> The pmgr-powerstate registers on Apple M3 Pro, Max and Ultra SoCs are
> compatible with "apple,t8103-pmgr-pwrstate". Add
> "apple,t6030-pmgr-pwrstate" for M3 Pro and "apple,t6030-pmgr-pwrstate"
> for M3 Max and Ultra as per-SoC compatibles.
[Severity: Low]
This isn't a bug, but there appears to be a typo in the commit message. It
duplicates "apple,t6030-pmgr-pwrstate" instead of mentioning
"apple,t6031-pmgr-pwrstate" for the M3 Max and Ultra.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260715-apple-t603x-initial-devices-v2-0-df65b2485710@jannau.net?part=5
next prev parent reply other threads:[~2026-07-15 9:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 9:11 [PATCH v2 00/10] Initial Apple M3 Pro, Max and Ultra device trees Janne Grunau
2026-07-15 9:11 ` [PATCH v2 01/10] dt-bindings: arm: apple: Add M3 Pro/Max/Ultra devices (T603x) Janne Grunau
2026-07-15 9:11 ` [PATCH v2 02/10] dt-bindings: interrupt-controller: apple,aic2: Invert #interrupt-cells condition Janne Grunau
2026-07-15 9:24 ` sashiko-bot
2026-07-15 9:11 ` [PATCH v2 03/10] dt-bindings: interrupt-controller: apple,aic2: Add apple,t6031-aic3 compatible Janne Grunau
2026-07-15 9:11 ` [PATCH v2 04/10] dt-bindings: arm: apple: apple,pmgr: Add t6030 and t6031 compatibles Janne Grunau
2026-07-15 9:19 ` sashiko-bot
2026-07-15 9:11 ` [PATCH v2 05/10] dt-bindings: power: apple,pmgr-pwrstate: " Janne Grunau
2026-07-15 9:17 ` sashiko-bot [this message]
2026-07-15 9:11 ` [PATCH v2 06/10] dt-bindings: watchdog: apple,wdt: " Janne Grunau
2026-07-15 16:35 ` Guenter Roeck
2026-07-15 9:11 ` [PATCH v2 07/10] dt-bindings: i2c: apple,i2c: " Janne Grunau
2026-07-15 9:11 ` [PATCH v2 08/10] dt-bindings: pwm: apple,s5l-fpwm: " Janne Grunau
2026-07-15 9:11 ` [PATCH v2 09/10] arm64: dts: apple: Initial T603[124] (M3 Max and Ultra) device trees Janne Grunau
2026-07-15 14:46 ` Sven Peter
2026-07-15 9:11 ` [PATCH v2 10/10] arm64: dts: apple: Initial T6030 (M3 Pro) " Janne Grunau
2026-07-15 9:27 ` sashiko-bot
2026-07-15 14:46 ` Sven Peter
2026-07-15 15:55 ` [PATCH v2 00/10] Initial Apple M3 Pro, Max and Ultra " Guenter Roeck
2026-07-15 15:59 ` Sven Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260715091800.661C21F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j@jannau.net \
--cc=linux-watchdog@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.