From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] iio: light: opt3001: split opt3001_get_processed() logic
Date: Wed, 15 Jul 2026 10:09:58 +0200 [thread overview]
Message-ID: <20260715100958.000046d9@gmail.com> (raw)
In-Reply-To: <alZsCghbqDBF6X0d@ashevche-desk.local>
On Tue, 14 Jul 2026 20:04:10 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> > - if (ret < 0) {
> > + if (ret < 0)
>
> At some point consider dropping ' < 0' pieces for the i2c_smbus_write_*() cases.
> Read cases are different, of course.
>
> > dev_err(dev, "failed to write register %02x\n",
> > OPT3001_CONFIGURATION);
> > +
> > + return ret;
>
Even after an 8-part patch set, this driver still needs cleaning up!
--
Kind regards
CJD
prev parent reply other threads:[~2026-07-15 8:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 15:36 [PATCH v4] iio: light: opt3001: split opt3001_get_processed() logic Joshua Crofts
2026-07-14 17:04 ` Andy Shevchenko
2026-07-15 8:09 ` Joshua Crofts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260715100958.000046d9@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.