From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5205313E1D for ; Wed, 15 Jul 2026 08:11:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784103083; cv=none; b=JG3zqU87dSiTTdWLqxrOGIIivTIY8lzg4Kbs4IOAVbeHwHNobJhEa7xapYLEakK/aykbijfktt8OFLaniJuZjCdYXwuHil6FD4fORAoHosIVi8BqxTTuMVmJzv6QFW1dYU/koTtLphblvojD9K3voeTmJObUb25gudgjplIRzrA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784103083; c=relaxed/simple; bh=v1VKY3EffdDvVnOSKjraOPTXXHHgByCtxpkOMDUhsmM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KRKbXgxrRPsijA5gHc2ffBCStwF/2mLzUxMjxSP4eXr90TiSKuvwi3dOSblIDZjKV/BnsZFnOeNE1z/Nbs7hX6YrbIjRQggwyE7DgqdevmKdtHE9DchCmICsZX5nOUWAT9bpCOCV4xv9gIVsI/ZEwZMjlqXh9Dr2nDk24CIOaRQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jiz8S7qU; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jiz8S7qU" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-493b1710405so27593125e9.2 for ; Wed, 15 Jul 2026 01:11:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784103080; x=1784707880; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=g5vj+GIH7jbJ8BHVZT5sX3ucem46R0CpdI8IPEs9c7Q=; b=jiz8S7qUrtO4AJrSWoparVpATMjzM4DWHa4QuE4EjzD+6mGaZNX19u4ZfdZDlgj+Bb 07wfMxZZOwaITAuk6On2tw07/ya8Su2H/pemNJ/xz4jZo02Uo01cYeD1/TqVlPZKMpf3 oIO7mCQzbk82Ba60WtN1RIy/JMUSQT0ROYuruu3JHURphnDyv32f950dG82UUuYRyWTR HHOeC9/BxiR6OgwvMTTUF4Fkm0iORymaAhenuB9Ef7bQqDMshMo4ZSsoYwbmx8qX14/3 D/b2I71D9pqaFNlujQYvDX1I3fcalXwQvpOehNoXNqh4nk8i5dsDJCInvyRFldbpZJ8I U1GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784103080; x=1784707880; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=g5vj+GIH7jbJ8BHVZT5sX3ucem46R0CpdI8IPEs9c7Q=; b=ZH9QFNyNA9M3n9mNzC1dN7Yl7GToVReG4T0zA5dEy0a/q8PiW0lBmv09Q5I6PYMQ8g sPPFmWSpgcv9eVluM3+7jcFPSIjyjrXJlcyKI6p1PS2QpoZkrLfh3gk61NvCG9D2yS2a HXAPfCAwkvhPzgneIEFjR/Zv9i2pkUH4P3WH/i6bE7lgJk6B+84i1c9vIx+FhYvaKH3w cjPsorjx35sX0P/woO9Z5pduiXKBRnv2bV8n3fDjwBXuCwfoBTmxzr1uv/A+A1wkY4Ar X0flQxyONeSaChFycurPM89ijn5h8euuZXYB83wlEFFy8HY9KrJRFLP7XUVqtF2hXZ5Y kJ1g== X-Forwarded-Encrypted: i=1; AHgh+RoUVuVASubmftC+fqmONx+6uvrAG+mDY9JC9U+H8CjBuJsSma1SVkiBLBFTWXqBXEkVk/OmO0/Z0NHYUUs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6fSbh1uBwQACQ4+d2KTwMGlQLVR7MwcazRTFWYyRoFJ9t2HET jEt8Qu167Kx/oT3FFF14MT9s/zwobUuaA/P6g/aL+62SFcGNTzc886so X-Gm-Gg: AfdE7cmplXxdu/7mu7dFThDnFukMNPDdhbjQa3YZd7xEZATDtDqs100DUXCEyfTOIdQ LyZ4sVCh6lKnZwkcdAhohGT2YhjXpz3zyrVS5xkTvq/E2NFerVdZgfgiZgUv71SwklE1Kgmk7lG W2u9P5mT/4JjbQMLhlYMGI5oQgooDGNcqAd3F2N+Kl1ZYijnGD2Vdhm1UzNb5qDD+igM1WVXn0b tYlptVD+mu3OL62OIpx+Uv9RBRY7TbmCn3PFbBb1IFvQg41W5/X/cKN81SQe88enkS+u/PE+9Uk OAlvZ9gqHNwaYqqGFLUvQ5A9xWbLnLvoVJi9zjuU6u6nbAUxQrqNN6lgz/GMVmKROqBVlr0VuST pVeZwOR5tSe70lU2VRe2l3EqW5Qtm2ZOUhAMlF3rHZoYLpJFPOcvGc7Xnl5GjybW+3gWUX2Hp6g rXBLw8PtoLjNkMOGieU/FPZjTSWvQZB2GOCByDd/oMtJRKVdM2vUieZmnWolRK4xd2A7YaXlpY5 blr/WBLQY4zd5obwzj2Z8rOM6y3BPT2nurAyPJEJ+4Pe1ZZmsg5C5O9LQaT9sg/X0E+imqsAb2d ZPafyJeBlaIC6jXFNz2r6ubUBXpG7pxDU16nwEMMhetzSxqP34NVU1gmwtAtJw2bg8yIbl3kSn5 D/ZCPuzotEdM23TiIz3BLSP8= X-Received: by 2002:a05:600c:8119:b0:493:f744:e7d5 with SMTP id 5b1f17b1804b1-49518324f47mr71637325e9.38.1784103079789; Wed, 15 Jul 2026 01:11:19 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4953c704bfasm37195675e9.2.2026.07.15.01.11.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 01:11:19 -0700 (PDT) Date: Wed, 15 Jul 2026 10:11:19 +0200 From: Joshua Crofts To: Can Peng Cc: nuno.sa@analog.com, Michael.Hennerich@analog.com, jic23@kernel.org, dlechner@baylibre.com, andy@kernel.org, linux@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: dac: ad5446: fix OF module device table Message-ID: <20260715101119.00001b6f@gmail.com> In-Reply-To: <20260714091846.136278-1-pengcan@kylinos.cn> References: <20260714091846.136278-1-pengcan@kylinos.cn> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 14 Jul 2026 17:18:45 +0800 Can Peng wrote: > The ad5446 I2C driver exports its OF match table with > MODULE_DEVICE_TABLE(OF, ...). > > The device table type is used by modpost when generating module aliases, > and scripts/mod/file2alias.c matches the lowercase "of" type. Using > "OF" prevents the OF table from being recognized, so no OF module alias is > generated for the I2C driver. > > Use the lowercase "of" type so OF-based module autoloading works. > > Fixes: 876d94024087 ("iio: dac: ad5446: Separate I2C/SPI into different drivers") > Signed-off-by: Can Peng > --- This needs a Cc: stable tag, perhaps Jonathan can add it when applying. FWIW, Reviewed-by: Joshua Crofts -- Kind regards CJD