Re: [PATCH bpf-next 3/4] selftests/bpf: Silence array bounds warning in global_map_resize

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Multi-line comment opening '/*' is not on its own line.
--

--- Patch [3]: [PATCH bpf-next 3/4] selftests/bpf: Silence array bounds warning in global_map_resize ---
commit 477df4be9ab84dd41e948528c2cecec30f56ae6a
Author: Viktor Malik <vmalik@redhat.com>

selftests/bpf: Silence array bounds warning in global_map_resize

This commit silences a GCC false positive array bounds violation warning in
global_map_resize. It achieves this by accessing the BPF map array via a
plain pointer after it has been resized from within the BPF program.

> diff --git a/tools/testing/selftests/bpf/prog_tests/global_map_resize.c b/tools/testing/selftests/bpf/prog_tests/global_map_resize.c
> --- a/tools/testing/selftests/bpf/prog_tests/global_map_resize.c
> +++ b/tools/testing/selftests/bpf/prog_tests/global_map_resize.c

[ ... ]

> @@ -58,10 +59,13 @@ static void global_map_resize_bss_subtest(void)
>  		goto teardown;
>  
>  	/* fill the newly resized array with ones,
> -	 * skipping the first element which was previously set
> +	 * skipping the first element which was previously set;
> +	 * access through a plain pointer to avoid -Warray-bounds
> +	 * since the array was resized beyond its declared length.
>  	 */

[Severity: Low]
This isn't a bug, but does this multi-line comment follow the preferred BPF
coding style? 

The BPF subsystem guidelines require that multi-line comments have the
opening '/*' on its own line, even when modifying surrounding code that
uses the old style.

> +	array = skel->bss->array;
>  	for (int i = 1; i < array_len; i++)
> -		skel->bss->array[i] = 1;
> +		array[i] = 1;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1784112948.git.vmalik@redhat.com?part=3