From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F33AC44501 for ; Wed, 15 Jul 2026 11:44:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YxQyf/U5btFqpvcxZdqs607ygDsYZn3H7GdCOlSr0RA=; b=2WlT92LKZ2VCPF zYHlDi/OaVYtl6qW037ntJgqCSM34FmDF/HCdV4M4CHMCEjT0Ec6+Dn1fH1hy4SqjUek8HJtibEaR 1OtHMrvXyzuT20NCfxPRS8KWVxAxLCNvo4rBoamN31Fw/AT12Ik9pkoM/eZzlKU7gIxbHQYeZTuqN QbUBlano/5G93JkRoWUwbB2PMdW4YjP5Ykj/nWsIZ5ROVrWvUqOz0gLSsGHAFvpT3UngybOyl+rwl v2HkFWwxj9gcHQzgJmRMU6bR79uUUZf43xphQdLXoBtzooBlzKbNSBaDy5E0nfCr5w804PKv/+9Pp jA2zjLmYs6Kjs/G6g38Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjy24-0000000Ec2a-0GqI; Wed, 15 Jul 2026 11:44:08 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjy23-0000000Ec2L-1AlE for linux-phy@lists.infradead.org; Wed, 15 Jul 2026 11:44:07 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 86C1A601C6; Wed, 15 Jul 2026 11:44:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEA621F000E9; Wed, 15 Jul 2026 11:44:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784115846; bh=r+/6qQC6HLRiLXIPUgApYTcI4qIN+f3MQWNzB9RdFOg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=H73eGrODA4mU6vuc/JaRiPfIR3+5OVbE+r4y/QOfFIG3XJjUSaGNZFMKovX7fzGv0 mp2VUydPN5xw83e94q6a/Qis/Bs9viTjGB88xqZC8Ek+/CmU77y8zGExxSXRh+vE63 YFvEF2hNgiyQjFZRqgBm0j/wr9IyAVQ2DmQ50No4cRjMln1t5yuD68+hDZa0Q57J+P Aw/5txnHbu9H15yI63381id4QpeCTuW1mUm0DxdeCCiuw9t+vK8R8I57PQ4tCfamxc 4ij8Ce93yzirnqgIBHrDwcOmq7UDWAA5Cn8lmgcU45F/0SJy/H7i80RLJ4Z20yKXpz RAIFPh1keCoMg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 6/6] phy: fsl-imx8mq-usb: keep PHY power domain runtime always-on for i.MX8MP To: "Xu Yang" Cc: olteanv@gmail.com, vkoul@kernel.org, Frank.Li@kernel.org, linux-phy@lists.infradead.org, imx@lists.linux.dev, neil.armstrong@linaro.org In-Reply-To: <20260715-imx8mp-usb-phy-improvement-v6-6-00d95e270e4c@nxp.com> References: <20260715-imx8mp-usb-phy-improvement-v6-0-00d95e270e4c@nxp.com> <20260715-imx8mp-usb-phy-improvement-v6-6-00d95e270e4c@nxp.com> Date: Wed, 15 Jul 2026 11:44:05 +0000 Message-Id: <20260715114405.CEA621F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIFRoZSBkcml2ZXIgdW5j b25kaXRpb25hbGx5IGZhaWxzIHByb2JlIGlmIGRldl9wbV9nZW5wZF9ycG1fYWx3YXlzX29uKCkg cmV0dXJucyBhbiBlcnJvci4gVGhpcyBicmVha3MgYmFja3dhcmQgY29tcGF0aWJpbGl0eSBvbiBj b25maWd1cmF0aW9ucyB3aXRob3V0IGdlbmVyaWMgcG93ZXIgZG9tYWlucyBvciB3aGVuIHRoZSBk ZXZpY2UgdHJlZSBsYWNrcyBhIHBvd2VyLWRvbWFpbnMgcHJvcGVydHkuCi0tCgotLS0gUGF0Y2gg WzZdOiBbUEFUQ0ggdjYgNi82XSBwaHk6IGZzbC1pbXg4bXEtdXNiOiBrZWVwIFBIWSBwb3dlciBk b21haW4gcnVudGltZSBhbHdheXMtb24gZm9yIGkuTVg4TVAgLS0tCmNvbW1pdCAxNDUxNGY4ZTMz MDYwMDM3YTczNGFjYWQyMTk5ZTdmZWJjNTZkZWY4CkF1dGhvcjogWHUgWWFuZyA8eHUueWFuZ18y QG54cC5jb20+ClN1YmplY3Q6IHBoeTogZnNsLWlteDhtcS11c2I6IGtlZXAgUEhZIHBvd2VyIGRv bWFpbiBydW50aW1lIGFsd2F5cy1vbiBmb3IgaS5NWDhNUAoKVGhpcyBjb21taXQgbWFya3MgdGhl IFBIWSBwb3dlciBkb21haW4gYXMgcnVudGltZSBhbHdheXMtb24gZm9yIHRoZSBpLk1YOE1QCnBs YXRmb3JtIHRvIHByZXZlbnQgaXQgZnJvbSBiZWluZyBwb3dlcmVkIG9mZiBkdXJpbmcgcnVudGlt ZSBzdXNwZW5kLiBUaGlzIGlzCmludGVuZGVkIHRvIHByZXNlcnZlIFVTQiB3YWtldXAgZnVuY3Rp b25hbGl0eSBvbiBpLk1YOE1QLgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9waHkvZnJlZXNjYWxl L3BoeS1mc2wtaW14OG1xLXVzYi5jIGIvZHJpdmVycy9waHkvZnJlZXNjYWxlL3BoeS1mc2wtaW14 OG1xLXVzYi5jCj4gLS0tIGEvZHJpdmVycy9waHkvZnJlZXNjYWxlL3BoeS1mc2wtaW14OG1xLXVz Yi5jCj4gKysrIGIvZHJpdmVycy9waHkvZnJlZXNjYWxlL3BoeS1mc2wtaW14OG1xLXVzYi5jCgpb IC4uLiBdCgo+IEBAIC03MzksNiArNzQyLDEyIEBAIHN0YXRpYyBpbnQgaW14OG1xX3VzYl9waHlf cHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgCWlmICghcGh5X2RhdGEpCj4g IAkJcmV0dXJuIC1FSU5WQUw7Cj4gIAo+ICsJaWYgKHBoeV9kYXRhLT5uZWVkX2dlbnBkX3JwbV9v bikgewo+ICsJCXJldCA9IGRldl9wbV9nZW5wZF9ycG1fYWx3YXlzX29uKGRldiwgdHJ1ZSk7Cj4g KwkJaWYgKHJldCkKPiArCQkJcmV0dXJuIGRldl9lcnJfcHJvYmUoZGV2LCByZXQsICJmYWlsZWQg dG8gc2V0IGdlbnBkIHJwbSBhbHdheXMgb25cbiIpOwoKW1NldmVyaXR5OiBIaWdoXQpEb2VzIHRo aXMgY29kZSBjYXVzZSBwcm9iZSB0byBmYWlsIHVubmVjZXNzYXJpbHkgd2hlbiBnZW5lcmljIHBv d2VyIGRvbWFpbnMKYXJlIGRpc2FibGVkIG9yIG5vdCBjb25maWd1cmVkIGluIHRoZSBkZXZpY2Ug dHJlZT8KCklmIHRoZSBrZXJuZWwgaXMgY29tcGlsZWQgd2l0aG91dCBDT05GSUdfUE1fR0VORVJJ Q19ET01BSU5TLApkZXZfcG1fZ2VucGRfcnBtX2Fsd2F5c19vbigpIHdpbGwgcmV0dXJuIC1FT1BO T1RTVVBQLiBTaW1pbGFybHksIGlmIHRoZQpkZXZpY2UgdHJlZSBsYWNrcyBhICdwb3dlci1kb21h aW5zJyBwcm9wZXJ0eSBmb3IgdGhlIFBIWSBub2RlLCBpdCBtYXkgcmV0dXJuCi1FTk9ERVYuCgpT aW5jZSB0aGUgcG93ZXIgZG9tYWluIHdvbid0IGJlIHJ1bnRpbWUtc3VzcGVuZGVkIGJ5IHRoZSBn ZW5lcmljIHBvd2VyIGRvbWFpbgpmcmFtZXdvcmsgaW4gdGhlc2UgY2FzZXMsIHRoZSB3YWtldXAg aXNzdWUgdGhpcyBwYXRjaCBpbnRlbmRzIHRvIGZpeCBkb2Vzbid0CmV4aXN0LgoKU2hvdWxkIHRo aXMgY2hlY2sgaWdub3JlIG5vbi1mYXRhbCBlcnJvcnMgbGlrZSAtRU9QTk9UU1VQUCBhbmQgLUVO T0RFViB0bwpwcmVzZXJ2ZSBiYWNrd2FyZCBjb21wYXRpYmlsaXR5IHdpdGggb2xkZXIgZGV2aWNl IHRyZWVzIGFuZCBtaW5pbWFsIGtlcm5lbApjb25maWd1cmF0aW9ucz8KCj4gKwl9Cj4gKwo+ICAJ aW14X3BoeS0+cGh5ID0gZGV2bV9waHlfY3JlYXRlKGRldiwgTlVMTCwgcGh5X2RhdGEtPm9wcyk7 Cj4gIAlpZiAoSVNfRVJSKGlteF9waHktPnBoeSkpCj4gIAkJcmV0dXJuIFBUUl9FUlIoaW14X3Bo eS0+cGh5KTsKCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMv cGF0Y2hzZXQvMjAyNjA3MTUtaW14OG1wLXVzYi1waHktaW1wcm92ZW1lbnQtdjYtMC0wMGQ5NWUy NzBlNGNAbnhwLmNvbT9wYXJ0PTYKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBo eUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 920F4332ED6 for ; Wed, 15 Jul 2026 11:44:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784115847; cv=none; b=dTa53wW8/zTn0HK5z/dLi/p3W84JYBynrCEkqFfNKwXpnSkh2+TEFSROV6RDTafXpxIHSdDPB/7nkqLLtewnHdzx8627L4PZVvmpMfwgqWpE7cZHXeqG800pMpw6FY/qkXrzq9Tw//hQ2t1WsYnEyWoQFVXbiDFLnTKkELeAjOI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784115847; c=relaxed/simple; bh=FZoewq6gZuI9zAp/nRm/iF6Uuq8Ct5gCHbn8v298jBI=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=TDjdjeOkhxdMsqxiZHEwaJiJ1rZ7OfotyNSmIxXrNMiV/39gp64bEDSWIFAeuuh7psbRu6diw3YoHrdfks3zujzW932yj7ChFUmTbF+LWQGGKdq105y0xioQ36e6vyECvP8qN7hFuATjiBuIT0UEbQF1GcdbEUF1NuE60Y6lvZc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=H73eGrOD; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="H73eGrOD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEA621F000E9; Wed, 15 Jul 2026 11:44:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784115846; bh=r+/6qQC6HLRiLXIPUgApYTcI4qIN+f3MQWNzB9RdFOg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=H73eGrODA4mU6vuc/JaRiPfIR3+5OVbE+r4y/QOfFIG3XJjUSaGNZFMKovX7fzGv0 mp2VUydPN5xw83e94q6a/Qis/Bs9viTjGB88xqZC8Ek+/CmU77y8zGExxSXRh+vE63 YFvEF2hNgiyQjFZRqgBm0j/wr9IyAVQ2DmQ50No4cRjMln1t5yuD68+hDZa0Q57J+P Aw/5txnHbu9H15yI63381id4QpeCTuW1mUm0DxdeCCiuw9t+vK8R8I57PQ4tCfamxc 4ij8Ce93yzirnqgIBHrDwcOmq7UDWAA5Cn8lmgcU45F/0SJy/H7i80RLJ4Z20yKXpz RAIFPh1keCoMg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 6/6] phy: fsl-imx8mq-usb: keep PHY power domain runtime always-on for i.MX8MP Reply-To: sashiko-reviews@lists.linux.dev To: "Xu Yang" Cc: olteanv@gmail.com, vkoul@kernel.org, Frank.Li@kernel.org, linux-phy@lists.infradead.org, imx@lists.linux.dev, neil.armstrong@linaro.org In-Reply-To: <20260715-imx8mp-usb-phy-improvement-v6-6-00d95e270e4c@nxp.com> References: <20260715-imx8mp-usb-phy-improvement-v6-0-00d95e270e4c@nxp.com> <20260715-imx8mp-usb-phy-improvement-v6-6-00d95e270e4c@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 15 Jul 2026 11:44:05 +0000 Message-Id: <20260715114405.CEA621F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] The driver unconditionally fails probe if dev_pm_genpd_rpm_always_= on() returns an error. This breaks backward compatibility on configurations= without generic power domains or when the device tree lacks a power-domain= s property. -- --- Patch [6]: [PATCH v6 6/6] phy: fsl-imx8mq-usb: keep PHY power domain ru= ntime always-on for i.MX8MP --- commit 14514f8e33060037a734acad2199e7febc56def8 Author: Xu Yang Subject: phy: fsl-imx8mq-usb: keep PHY power domain runtime always-on for i= .MX8MP This commit marks the PHY power domain as runtime always-on for the i.MX8MP platform to prevent it from being powered off during runtime suspend. This = is intended to preserve USB wakeup functionality on i.MX8MP. > diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/fre= escale/phy-fsl-imx8mq-usb.c > --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c > +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c [ ... ] > @@ -739,6 +742,12 @@ static int imx8mq_usb_phy_probe(struct platform_devi= ce *pdev) > if (!phy_data) > return -EINVAL; > =20 > + if (phy_data->need_genpd_rpm_on) { > + ret =3D dev_pm_genpd_rpm_always_on(dev, true); > + if (ret) > + return dev_err_probe(dev, ret, "failed to set genpd rpm always on\n"); [Severity: High] Does this code cause probe to fail unnecessarily when generic power domains are disabled or not configured in the device tree? If the kernel is compiled without CONFIG_PM_GENERIC_DOMAINS, dev_pm_genpd_rpm_always_on() will return -EOPNOTSUPP. Similarly, if the device tree lacks a 'power-domains' property for the PHY node, it may return -ENODEV. Since the power domain won't be runtime-suspended by the generic power doma= in framework in these cases, the wakeup issue this patch intends to fix doesn't exist. Should this check ignore non-fatal errors like -EOPNOTSUPP and -ENODEV to preserve backward compatibility with older device trees and minimal kernel configurations? > + } > + > imx_phy->phy =3D devm_phy_create(dev, NULL, phy_data->ops); > if (IS_ERR(imx_phy->phy)) > return PTR_ERR(imx_phy->phy); --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260715-imx8mp-usb= -phy-improvement-v6-0-00d95e270e4c@nxp.com?part=3D6